[GitHub] [airflow] feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-53364 > Maybe we can use `.airflowignore` for that? @feluelle @nuclearpinguin That's exactly what I thought of, too. 

[GitHub] [airflow] feluelle commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator

2019-09-20 Thread GitBox
feluelle commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator URL: https://github.com/apache/airflow/pull/6153#discussion_r326724478 ## File path: airflow/contrib/operators/awsbatch_operator.py ## @@ -81,8 +85,8 @@

[GitHub] [airflow] feluelle commented on issue #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator

2019-09-20 Thread GitBox
feluelle commented on issue #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator URL: https://github.com/apache/airflow/pull/6153#issuecomment-533641546 @mik-laj do you have any other comments regarding the changes?

[GitHub] [airflow] feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-53364 > Maybe we can use `.airflowignore` for that? @feluelle @nuclearpinguin That's exactly what I thought of, too.  >

[GitHub] [airflow] ashb commented on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
ashb commented on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#issuecomment-533650837 @feng-tao The same metric is emited in multiple places. If you look you will find both (one eith the filename and one without)

[GitHub] [airflow] pingzh opened a new pull request #6159: [AIRFLOW-5528] end_of_log_mark should not be a log record

2019-09-20 Thread GitBox
pingzh opened a new pull request #6159: [AIRFLOW-5528] end_of_log_mark should not be a log record URL: https://github.com/apache/airflow/pull/6159 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Assigned] (AIRFLOW-5528) end of log mark in broken in es_task_handler

2019-09-20 Thread Ping Zhang (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ping Zhang reassigned AIRFLOW-5528: --- Assignee: Ping Zhang > end of log mark in broken in es_task_handler >

[jira] [Created] (AIRFLOW-5528) end of log mark in broken in es_task_handler

2019-09-20 Thread Ping Zhang (Jira)
Ping Zhang created AIRFLOW-5528: --- Summary: end of log mark in broken in es_task_handler Key: AIRFLOW-5528 URL: https://issues.apache.org/jira/browse/AIRFLOW-5528 Project: Apache Airflow Issue

[GitHub] [airflow] codecov-io edited a comment on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name URL: https://github.com/apache/airflow/pull/5879#issuecomment-532257616 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5879?src=pr=h1) Report > Merging

[GitHub] [airflow] feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-53364 > Maybe we can use `.airflowignore` for that? @feluelle @nuclearpinguin That's exactly what I thought of, too. 

[GitHub] [airflow] feng-tao commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
feng-tao commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#discussion_r326740849 ## File path: UPDATING.md ## @@ -40,6 +40,16 @@ assists users migrating to a new version.

[GitHub] [airflow] feng-tao commented on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
feng-tao commented on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#issuecomment-533652907 @ashb Ah I see, thanks for the info. Yeah, internally we still emit the metric from webserver side instead of scheduler side

[GitHub] [airflow] feng-tao commented on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
feng-tao commented on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#issuecomment-533653516 And haven't followed with latest progress, but is the stateless webserver code in 1.10.5?

[jira] [Commented] (AIRFLOW-5519) Fix missing apply default in sql_to_gcs operator

2019-09-20 Thread Yiming Liu (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934671#comment-16934671 ] Yiming Liu commented on AIRFLOW-5519: - [~higrys]  Hi, thanks for the quick approval. Shall we pick

[GitHub] [airflow] feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-53364 > Maybe we can use `.airflowignore` for that? @feluelle @nuclearpinguin That's exactly what I thought of, too. 

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-20 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533690184 I've updated `TestPubSubPullSensor` (hook mocking).

[GitHub] [airflow] codecov-io edited a comment on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-531411977 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6096?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-5528) end of log mark in broken in es_task_handler

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934766#comment-16934766 ] ASF GitHub Bot commented on AIRFLOW-5528: - pingzh commented on pull request #6159:

[GitHub] [airflow] feluelle commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
feluelle commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-53364 > I agree with that, especially that when everything will be moved to core we will need not only gcp but also other dependencies. Maybe

[GitHub] [airflow] feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
feluelle edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-53364 > I agree with that, especially that when everything will be moved to core we will need not only gcp but also other

[GitHub] [airflow] ashb edited a comment on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
ashb edited a comment on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#issuecomment-533650837 @feng-tao The same metric is emited in multiple places. If you look you will find both (one eith the filename and one

[GitHub] [airflow] ashb commented on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
ashb commented on issue #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#issuecomment-533672136 Stateless webserver is not in 1.10.5 but will be an option for 1.10.6 (or more likely .7)

[GitHub] [airflow] mrshu commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

2019-09-20 Thread GitBox
mrshu commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name URL: https://github.com/apache/airflow/pull/5879#issuecomment-533715114 @ashb I've just noticed there was a conflict in the `UPDATING.md` file -- I've just resolved it. Please do let me

[GitHub] [airflow] codecov-io commented on issue #6159: [AIRFLOW-5528] end_of_log_mark should not be a log record

2019-09-20 Thread GitBox
codecov-io commented on issue #6159: [AIRFLOW-5528] end_of_log_mark should not be a log record URL: https://github.com/apache/airflow/pull/6159#issuecomment-533738557 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6159?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-5528) end of log mark in broken in es_task_handler

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934837#comment-16934837 ] ASF GitHub Bot commented on AIRFLOW-5528: - KevinYang21 commented on pull request #6159:

[jira] [Commented] (AIRFLOW-5528) end of log mark in broken in es_task_handler

2019-09-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934839#comment-16934839 ] ASF subversion and git services commented on AIRFLOW-5528: -- Commit

[GitHub] [airflow] KevinYang21 commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports

2019-09-20 Thread GitBox
KevinYang21 commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports URL: https://github.com/apache/airflow/pull/5944#discussion_r326841343 ## File path: airflow/__init__.py ## @@ -23,39 +23,39 @@ implement their own login mechanisms by providing an

[GitHub] [airflow] codecov-io edited a comment on issue #6160: [AIRFLOW-XXX] Fix Prerequisites link in BREEZE.rst

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #6160: [AIRFLOW-XXX] Fix Prerequisites link in BREEZE.rst URL: https://github.com/apache/airflow/pull/6160#issuecomment-533760746 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6160?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6160: [AIRFLOW-XXX] Fix Prerequisites link in BREEZE.rst

2019-09-20 Thread GitBox
codecov-io commented on issue #6160: [AIRFLOW-XXX] Fix Prerequisites link in BREEZE.rst URL: https://github.com/apache/airflow/pull/6160#issuecomment-533760746 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6160?src=pr=h1) Report > Merging

[GitHub] [airflow] KevinYang21 commented on issue #5908: Revert "[AIRFLOW-4797] Improve performance and behaviour of zombie de…

2019-09-20 Thread GitBox
KevinYang21 commented on issue #5908: Revert "[AIRFLOW-4797] Improve performance and behaviour of zombie de… URL: https://github.com/apache/airflow/pull/5908#issuecomment-533755919 @kaxil Do you think I can just update 4797? So that we have full context in one jira end to end.

[GitHub] [airflow] codecov-io commented on issue #6161: [AIRFLOW-XXX] Fix incorrect backticks in BREEZE.rst

2019-09-20 Thread GitBox
codecov-io commented on issue #6161: [AIRFLOW-XXX] Fix incorrect backticks in BREEZE.rst URL: https://github.com/apache/airflow/pull/6161#issuecomment-533762224 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6161?src=pr=h1) Report > Merging

[GitHub] [airflow] XD-DENG merged pull request #6161: [AIRFLOW-XXX] Fix incorrect backticks in BREEZE.rst

2019-09-20 Thread GitBox
XD-DENG merged pull request #6161: [AIRFLOW-XXX] Fix incorrect backticks in BREEZE.rst URL: https://github.com/apache/airflow/pull/6161 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] XD-DENG commented on issue #6149: [AIRFLOW-XXX] Fix typo and format error

2019-09-20 Thread GitBox
XD-DENG commented on issue #6149: [AIRFLOW-XXX] Fix typo and format error URL: https://github.com/apache/airflow/pull/6149#issuecomment-533767923 Re-triggered the Travis build and green now. Thanks @haoliang7 This is

[GitHub] [airflow] XD-DENG merged pull request #6149: [AIRFLOW-XXX] Fix typo and format error

2019-09-20 Thread GitBox
XD-DENG merged pull request #6149: [AIRFLOW-XXX] Fix typo and format error URL: https://github.com/apache/airflow/pull/6149 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] KevinYang21 commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports

2019-09-20 Thread GitBox
KevinYang21 commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports URL: https://github.com/apache/airflow/pull/5944#discussion_r326841550 ## File path: airflow/__init__.py ## @@ -23,39 +23,39 @@ implement their own login mechanisms by providing an

[GitHub] [airflow] kaxil opened a new pull request #6160: [AIRFLOW-XXX] Fix Prerequisites link in BREEZE.rst

2019-09-20 Thread GitBox
kaxil opened a new pull request #6160: [AIRFLOW-XXX] Fix Prerequisites link in BREEZE.rst URL: https://github.com/apache/airflow/pull/6160 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] KevinYang21 merged pull request #6159: [AIRFLOW-5528] end_of_log_mark should not be a log record

2019-09-20 Thread GitBox
KevinYang21 merged pull request #6159: [AIRFLOW-5528] end_of_log_mark should not be a log record URL: https://github.com/apache/airflow/pull/6159 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kaxil opened a new pull request #6161: [AIRFLOW-XXX] Fix incorrect backticks in BREEZE.rst

2019-09-20 Thread GitBox
kaxil opened a new pull request #6161: [AIRFLOW-XXX] Fix incorrect backticks in BREEZE.rst URL: https://github.com/apache/airflow/pull/6161 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] XD-DENG merged pull request #6160: [AIRFLOW-XXX] Fix Prerequisites link in BREEZE.rst

2019-09-20 Thread GitBox
XD-DENG merged pull request #6160: [AIRFLOW-XXX] Fix Prerequisites link in BREEZE.rst URL: https://github.com/apache/airflow/pull/6160 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] XD-DENG commented on issue #6156: remove _last_zombie_query_time arg

2019-09-20 Thread GitBox
XD-DENG commented on issue #6156: remove _last_zombie_query_time arg URL: https://github.com/apache/airflow/pull/6156#issuecomment-533764495 @liubotao Thanks for the PR. Please follow the instructions in the PR template (creating JIRA and attach the ticket number properly in commit

[GitHub] [airflow] nuclearpinguin edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
nuclearpinguin edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533285705 > Maybe we should differentiate between example dags for minimal installation and advanced installation enabling advanced

[jira] [Commented] (AIRFLOW-2910) models.Connection cannot use https

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934112#comment-16934112 ] ASF GitHub Bot commented on AIRFLOW-2910: - mik-laj commented on pull request #5239:

[GitHub] [airflow] TobKed commented on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs

2019-09-20 Thread GitBox
TobKed commented on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs URL: https://github.com/apache/airflow/pull/6154#issuecomment-533432635 Great point @mik-laj . I've measured times (for loading resources phase only) and removed unused libraries. Please

[GitHub] [airflow] codecov-io edited a comment on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs URL: https://github.com/apache/airflow/pull/6154#issuecomment-533426995 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6154?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs URL: https://github.com/apache/airflow/pull/6154#issuecomment-533426995 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6154?src=pr=h1) Report > Merging

[GitHub] [airflow] mikedias edited a comment on issue #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

2019-09-20 Thread GitBox
mikedias edited a comment on issue #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#issuecomment-53350 > Random point: Could you find a name to use other than "whitelist" - perhaps "allow_list"? Hum, I don't

[GitHub] [airflow] nuclearpinguin opened a new pull request #6155: [AIRFLOW-5527] Improve mocking in GCP test to avoid db queries

2019-09-20 Thread GitBox
nuclearpinguin opened a new pull request #6155: [AIRFLOW-5527] Improve mocking in GCP test to avoid db queries URL: https://github.com/apache/airflow/pull/6155 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-5527) Improve mocking in GCP test to avoid db queries

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934176#comment-16934176 ] ASF GitHub Bot commented on AIRFLOW-5527: - nuclearpinguin commented on pull request #6155:

[GitHub] [airflow] mik-laj commented on issue #6145: [AIRFLOW-5518] Use correct scheme for Http connection parsed from URI

2019-09-20 Thread GitBox
mik-laj commented on issue #6145: [AIRFLOW-5518] Use correct scheme for Http connection parsed from URI URL: https://github.com/apache/airflow/pull/6145#issuecomment-533428081 @K3UL In my opinion, it will be more valuable if you finish working on my PR. This PR solves more problems. Are

[GitHub] [airflow] liubotao opened a new pull request #6156: remove _last_zombie_query_time arg

2019-09-20 Thread GitBox
liubotao opened a new pull request #6156: remove _last_zombie_query_time arg URL: https://github.com/apache/airflow/pull/6156 dag_processing class _last_zombie_query_time arg no used Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the

[GitHub] [airflow] mik-laj edited a comment on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs

2019-09-20 Thread GitBox
mik-laj edited a comment on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs URL: https://github.com/apache/airflow/pull/6154#issuecomment-533418637 Are we use all these libraries? Can you check it? `pip freeze|grep google-cloud` I'm afraid of build

[GitHub] [airflow] codecov-io commented on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs

2019-09-20 Thread GitBox
codecov-io commented on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs URL: https://github.com/apache/airflow/pull/6154#issuecomment-533426995 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6154?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #6154: [AIRFLOW-5526] Update docs configuration due to migration of GCP docs URL: https://github.com/apache/airflow/pull/6154#issuecomment-533426995 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6154?src=pr=h1) Report > Merging

[GitHub] [airflow] mik-laj opened a new pull request #5239: [WIP][AIRFLOW-2910] Add HTTP URI support

2019-09-20 Thread GitBox
mik-laj opened a new pull request #5239: [WIP][AIRFLOW-2910] Add HTTP URI support URL: https://github.com/apache/airflow/pull/5239 Make sure you have checked _all_ steps below. ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-2910 ### Description - [ ]

[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

2019-09-20 Thread GitBox
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#discussion_r326501769 ## File path: scripts/ci/kubernetes/kube/templates/configmaps.template.yaml ## @@

[GitHub] [airflow] mikedias commented on issue #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

2019-09-20 Thread GitBox
mikedias commented on issue #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#issuecomment-53350 > Random point: Could you find a name to use other than "whitelist" - perhaps "allow_list"? Hum, I don't know.

[jira] [Created] (AIRFLOW-5527) Improve mocking in GCP test to avoid db queries

2019-09-20 Thread Tomasz Urbaszek (Jira)
Tomasz Urbaszek created AIRFLOW-5527: Summary: Improve mocking in GCP test to avoid db queries Key: AIRFLOW-5527 URL: https://issues.apache.org/jira/browse/AIRFLOW-5527 Project: Apache Airflow

[GitHub] [airflow] mik-laj merged pull request #6093: [AIRFLOW-5475] Normalize gcp_conn_id in operators and hooks

2019-09-20 Thread GitBox
mik-laj merged pull request #6093: [AIRFLOW-5475] Normalize gcp_conn_id in operators and hooks URL: https://github.com/apache/airflow/pull/6093 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-20 Thread GitBox
mik-laj commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533473570 Everything looks good, but can you do rebase? This is

[jira] [Commented] (AIRFLOW-5475) Normalize gcp_conn_id in operators and hooks

2019-09-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934220#comment-16934220 ] ASF subversion and git services commented on AIRFLOW-5475: -- Commit

[jira] [Commented] (AIRFLOW-5475) Normalize gcp_conn_id in operators and hooks

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934219#comment-16934219 ] ASF GitHub Bot commented on AIRFLOW-5475: - mik-laj commented on pull request #6093:

[jira] [Closed] (AIRFLOW-5515) Add stacklevel to GCP deprecation warnings

2019-09-20 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5515. -- Fix Version/s: 1.10.6 Resolution: Fixed > Add stacklevel to GCP deprecation warnings

[jira] [Closed] (AIRFLOW-5513) Move example_pubsub_flow.py to GCP package

2019-09-20 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5513. -- Fix Version/s: 2.0.0 Resolution: Fixed > Move example_pubsub_flow.py to GCP package >

[jira] [Closed] (AIRFLOW-5475) Normalize gcp_conn_id in operators and hooks

2019-09-20 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5475. -- Fix Version/s: 2.0.0 Resolution: Fixed > Normalize gcp_conn_id in operators and hooks

[GitHub] [airflow] mik-laj merged pull request #6148: [AIRFLOW-XXX] Add link to GCP Example DAGs source code

2019-09-20 Thread GitBox
mik-laj merged pull request #6148: [AIRFLOW-XXX] Add link to GCP Example DAGs source code URL: https://github.com/apache/airflow/pull/6148 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Closed] (AIRFLOW-5521) Fix link to GCP documentation

2019-09-20 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5521. -- Fix Version/s: 1.10.6 Resolution: Fixed > Fix link to GCP documentation >

[GitHub] [airflow] codecov-io commented on issue #6155: [AIRFLOW-5527] Improve mocking in GCP test to avoid db queries

2019-09-20 Thread GitBox
codecov-io commented on issue #6155: [AIRFLOW-5527] Improve mocking in GCP test to avoid db queries URL: https://github.com/apache/airflow/pull/6155#issuecomment-533477299 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6155?src=pr=h1) Report > Merging

[jira] [Assigned] (AIRFLOW-774) dagbag_size/collect_dags/dagbag_import_errors stats incorrect

2019-09-20 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reassigned AIRFLOW-774: - Assignee: Ash Berlin-Taylor (was: Taylor Edmiston) >

[GitHub] [airflow] ashb opened a new pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
ashb opened a new pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157 Make sure you have checked _all_ steps below. ### Jira - [x] https://issues.apache.org/jira/browse/AIRFLOW-774 ###

[jira] [Commented] (AIRFLOW-774) dagbag_size/collect_dags/dagbag_import_errors stats incorrect

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934342#comment-16934342 ] ASF GitHub Bot commented on AIRFLOW-774: ashb commented on pull request #6157: [AIRFLOW-774] Fix

[GitHub] [airflow] feluelle commented on a change in pull request #6097: [AIRFLOW-5478] Decode PythonVirtualenvOperator Output to Logs

2019-09-20 Thread GitBox
feluelle commented on a change in pull request #6097: [AIRFLOW-5478] Decode PythonVirtualenvOperator Output to Logs URL: https://github.com/apache/airflow/pull/6097#discussion_r326606426 ## File path: airflow/operators/python_operator.py ## @@ -334,7 +334,7 @@ def

[GitHub] [airflow] mik-laj commented on issue #6155: [AIRFLOW-5527] Improve mocking in GCP test to avoid db queries

2019-09-20 Thread GitBox
mik-laj commented on issue #6155: [AIRFLOW-5527] Improve mocking in GCP test to avoid db queries URL: https://github.com/apache/airflow/pull/6155#issuecomment-533589160 I think, we should set up mock of get connection at class level. This is strict requirements with almost all hook

[GitHub] [airflow] chatnuere commented on issue #4437: AIRFLOW-3632 Adding replace_microseconds parameter to dag_runs endpoint

2019-09-20 Thread GitBox
chatnuere commented on issue #4437: AIRFLOW-3632 Adding replace_microseconds parameter to dag_runs endpoint URL: https://github.com/apache/airflow/pull/4437#issuecomment-533551454 any news ? this pull request will be very usefull to a lot of people I'm using a small hack for

[GitHub] [airflow] potiuk opened a new pull request #6158: [AIRFLOW-XXX] Update documentation about variables forcing answer

2019-09-20 Thread GitBox
potiuk opened a new pull request #6158: [AIRFLOW-XXX] Update documentation about variables forcing answer URL: https://github.com/apache/airflow/pull/6158 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] [airflow] potiuk commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
potiuk commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533591385 How about moving the whole set of transfer operators/examples into a separate "transfer" sub-package- following AIP-21 principles. We have

[GitHub] [airflow] ashb commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
ashb commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#discussion_r326672549 ## File path: airflow/utils/dag_processing.py ## @@ -445,6 +446,7 @@ def file_path(self):

[GitHub] [airflow] feng-tao commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
feng-tao commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#discussion_r326714689 ## File path: airflow/models/dagbag.py ## @@ -389,24 +388,19 @@ def collect_dags(

[GitHub] [airflow] feluelle commented on a change in pull request #6097: [AIRFLOW-5478] Decode PythonVirtualenvOperator Output to Logs

2019-09-20 Thread GitBox
feluelle commented on a change in pull request #6097: [AIRFLOW-5478] Decode PythonVirtualenvOperator Output to Logs URL: https://github.com/apache/airflow/pull/6097#discussion_r326603942 ## File path: airflow/operators/python_operator.py ## @@ -334,7 +334,7 @@ def

[GitHub] [airflow] feluelle commented on issue #6014: [AIRFLOW-5342] Fix MSSQL breaking task_instance db migration

2019-09-20 Thread GitBox
feluelle commented on issue #6014: [AIRFLOW-5342] Fix MSSQL breaking task_instance db migration URL: https://github.com/apache/airflow/pull/6014#issuecomment-533557131 @potiuk If we do edit these `airflow/migrations/versions` files. We should re-enable Pylint for them.

[GitHub] [airflow] mik-laj commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
mik-laj commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#discussion_r326665354 ## File path: airflow/utils/dag_processing.py ## @@ -445,6 +446,7 @@ def file_path(self):

[GitHub] [airflow] feluelle commented on a change in pull request #6097: [AIRFLOW-5478] Decode PythonVirtualenvOperator Output to Logs

2019-09-20 Thread GitBox
feluelle commented on a change in pull request #6097: [AIRFLOW-5478] Decode PythonVirtualenvOperator Output to Logs URL: https://github.com/apache/airflow/pull/6097#discussion_r326606426 ## File path: airflow/operators/python_operator.py ## @@ -334,7 +334,7 @@ def

[GitHub] [airflow] feluelle commented on issue #6066: [AIRFLOW-XXX] Update to new logo

2019-09-20 Thread GitBox
feluelle commented on issue #6066: [AIRFLOW-XXX] Update to new logo URL: https://github.com/apache/airflow/pull/6066#issuecomment-533564803 From their [Trailmap](https://github.com/cncf/landscape#trail-map): ![Screenshot 2019-09-20 at 15 55

[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-20 Thread GitBox
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-533570181 I've rebased but due to fact than previous commits impacted PubSub significantly I had to make some changes (remove

[GitHub] [airflow] mik-laj edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
mik-laj edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533622830 I agree. I think, it's a good idea to move transfer operators to separate python package. This division now exists in

[GitHub] [airflow] mik-laj edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
mik-laj edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533622830 I agree. I think, it's a good idea to move transfer operators to separate python package. This division now exists in

[GitHub] [airflow] ashb commented on issue #6066: [AIRFLOW-XXX] Update to new logo

2019-09-20 Thread GitBox
ashb commented on issue #6066: [AIRFLOW-XXX] Update to new logo URL: https://github.com/apache/airflow/pull/6066#issuecomment-533537535 Happy to if they accept it - do we need to be "Cloud Native" (what ever the _hell_ that means) for it to be accepted?

[GitHub] [airflow] ashb commented on issue #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

2019-09-20 Thread GitBox
ashb commented on issue #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#issuecomment-533536969 Please change the setting name. This is an automated

[GitHub] [airflow] TobKed commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-20 Thread GitBox
TobKed commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r326613723 ## File path: airflow/gcp/operators/pubsub.py ## @@ -403,29 +617,43 @@ class

[GitHub] [airflow] TobKed commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

2019-09-20 Thread GitBox
TobKed commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r326613470 ## File path: airflow/gcp/operators/pubsub.py ## @@ -326,34 +505,68 @@ class

[GitHub] [airflow] potiuk edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
potiuk edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533591385 How about moving the whole set of transfer operators/examples into a separate "transfer" sub-package- following AIP-21 principles.

[jira] [Resolved] (AIRFLOW-2278) Add possibility to edit DAGs in webapp

2019-09-20 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-2278. Resolution: Won't Do > Add possibility to edit DAGs in webapp >

[GitHub] [airflow] ashb commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics

2019-09-20 Thread GitBox
ashb commented on a change in pull request #6157: [AIRFLOW-774] Fix long-broken DAG parsing Statsd metrics URL: https://github.com/apache/airflow/pull/6157#discussion_r326607539 ## File path: airflow/models/dagbag.py ## @@ -389,24 +388,19 @@ def collect_dags(

[GitHub] [airflow] codecov-io edited a comment on issue #6158: [AIRFLOW-XXX] Update documentation about variables forcing answer

2019-09-20 Thread GitBox
codecov-io edited a comment on issue #6158: [AIRFLOW-XXX] Update documentation about variables forcing answer URL: https://github.com/apache/airflow/pull/6158#issuecomment-533609046 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6158?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6158: [AIRFLOW-XXX] Update documentation about variables forcing answer

2019-09-20 Thread GitBox
codecov-io commented on issue #6158: [AIRFLOW-XXX] Update documentation about variables forcing answer URL: https://github.com/apache/airflow/pull/6158#issuecomment-533609046 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6158?src=pr=h1) Report > Merging

[GitHub] [airflow] mik-laj commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator

2019-09-20 Thread GitBox
mik-laj commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator URL: https://github.com/apache/airflow/pull/6153#discussion_r326699348 ## File path: airflow/contrib/operators/awsbatch_operator.py ## @@ -81,8 +85,8 @@

[jira] [Work started] (AIRFLOW-774) dagbag_size/collect_dags/dagbag_import_errors stats incorrect

2019-09-20 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-774 started by Ash Berlin-Taylor. - > dagbag_size/collect_dags/dagbag_import_errors stats incorrect >

[GitHub] [airflow] feluelle commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator

2019-09-20 Thread GitBox
feluelle commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator URL: https://github.com/apache/airflow/pull/6153#discussion_r326624268 ## File path: airflow/contrib/operators/awsbatch_operator.py ## @@ -81,8 +85,8 @@

[GitHub] [airflow] mik-laj edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
mik-laj edited a comment on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533622830 I agree. I think, it's a good idea to move transfer operators to separate python package. This division now exists in

[GitHub] [airflow] mik-laj commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel

2019-09-20 Thread GitBox
mik-laj commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533622830 I agree. I think, it's a good idea to move transfer operators to separate python package. This division now exists in integration.rst.

[jira] [Reopened] (AIRFLOW-2278) Add possibility to edit DAGs in webapp

2019-09-20 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-2278: Changing resolution > Add possibility to edit DAGs in webapp >

  1   2   >