[GitHub] [airflow] mik-laj commented on issue #15590: Documentation for Configuration JSON when triggering a DAG manually

2021-04-29 Thread GitBox
mik-laj commented on issue #15590: URL: https://github.com/apache/airflow/issues/15590#issuecomment-829323829 https://github.com/apache/airflow/pull/13365 Is it related? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk opened a new pull request #15592: Better description of UID/GID behaviour in image and quickstart

2021-04-29 Thread GitBox
potiuk opened a new pull request #15592: URL: https://github.com/apache/airflow/pull/15592 Following the discussion in https://github.com/apache/airflow/discussions/15579 seems that the AIRFLOW_UID/GID parameters were not clearly explained in the Docker Quick-start guide and some

[GitHub] [airflow] kaxil commented on a change in pull request #15592: Better description of UID/GID behaviour in image and quickstart

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #15592: URL: https://github.com/apache/airflow/pull/15592#discussion_r623158453 ## File path: docs/apache-airflow/start/docker.rst ## @@ -207,3 +211,45 @@ What's Next? From this point, you can head to the

[GitHub] [airflow] kaxil commented on a change in pull request #15592: Better description of UID/GID behaviour in image and quickstart

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #15592: URL: https://github.com/apache/airflow/pull/15592#discussion_r623158247 ## File path: docs/apache-airflow/start/docker.rst ## @@ -207,3 +211,45 @@ What's Next? From this point, you can head to the

[GitHub] [airflow-ci-infra] hmike96 commented on pull request #14: Automation for runner AMI creation and CI Infra

2021-04-29 Thread GitBox
hmike96 commented on pull request #14: URL: https://github.com/apache/airflow-ci-infra/pull/14#issuecomment-829352034 Closing this as packer is already merged will open a new one when terraform is finished for aws infrastructure. -- This is an automated message from the Apache Git

[GitHub] [airflow] waleedsamy commented on pull request #6317: [AIRFLOW-5644] Simplify TriggerDagRunOperator usage

2021-04-29 Thread GitBox
waleedsamy commented on pull request #6317: URL: https://github.com/apache/airflow/pull/6317#issuecomment-829364149 @BasPH > Setting DAG Run ids via the old TriggerDagRunOperator feels like one big hack. Both from a code perspective (the Python callable to provide is odd to read), and

[GitHub] [airflow] waleedsamy edited a comment on pull request #6317: [AIRFLOW-5644] Simplify TriggerDagRunOperator usage

2021-04-29 Thread GitBox
waleedsamy edited a comment on pull request #6317: URL: https://github.com/apache/airflow/pull/6317#issuecomment-829364149 @BasPH > Setting DAG Run ids via the old TriggerDagRunOperator feels like one big hack. Both from a code perspective (the Python callable to provide is odd to

[jira] [Commented] (AIRFLOW-5644) Simplify TriggerDagRunOperator usage

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335613#comment-17335613 ] ASF GitHub Bot commented on AIRFLOW-5644: - waleedsamy commented on pull request #6317: URL:

[GitHub] [airflow] malthe commented on pull request #15581: Add bindvars Xcom result to Oracle operator

2021-04-29 Thread GitBox
malthe commented on pull request #15581: URL: https://github.com/apache/airflow/pull/15581#issuecomment-829203997 The following is an example of an alternative implementation that works with the existing codebase, specifically addressing the requirement of calling a stored procedure that

[GitHub] [airflow] eladkal commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
eladkal commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829225488 hi @dstandish question/thoughts on the current situation. In order to use `MsSqlOperator` we are forced to install also `odbc` provider though we don't have any odbc

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335459#comment-17335459 ] ASF GitHub Bot commented on AIRFLOW-6296: - eladkal commented on pull request #6850: URL:

[GitHub] [airflow] KIRY4 edited a comment on issue #15451: No module named 'airflow.providers.google.common.hooks.leveldb'

2021-04-29 Thread GitBox
KIRY4 edited a comment on issue #15451: URL: https://github.com/apache/airflow/issues/15451#issuecomment-829278278 @potiuk fixed! now everything works perfect! thank you! I mean that I successfully login but warning still exist in logs: WARNING - Exception when importing

[GitHub] [airflow] github-actions[bot] commented on pull request #15582: Add more typing to airflow.utils.helpers

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15582: URL: https://github.com/apache/airflow/pull/15582#issuecomment-829373535 [The Workflow run](https://github.com/apache/airflow/actions/runs/796620491) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow-site] scouvreur opened a new issue #415: Links not updated on page footer

2021-04-29 Thread GitBox
scouvreur opened a new issue #415: URL: https://github.com/apache/airflow-site/issues/415 There seems to be an issue in this page's footer - https://airflow.apache.org/docs/apache-airflow/stable/index.html ![Screenshot 2021-04-29 at 15 09

[GitHub] [airflow] ianstanton commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
ianstanton commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623014557 ## File path: chart/tests/test_annotations.py ## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] KIRY4 edited a comment on issue #15451: No module named 'airflow.providers.google.common.hooks.leveldb'

2021-04-29 Thread GitBox
KIRY4 edited a comment on issue #15451: URL: https://github.com/apache/airflow/issues/15451#issuecomment-829278278 @potiuk fixed! now everything works perfect! thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] bbovenzi opened a new pull request #15591: Add ability to quickly trigger a DAG

2021-04-29 Thread GitBox
bbovenzi opened a new pull request #15591: URL: https://github.com/apache/airflow/pull/15591 From talking with some Airflow users, most of the time people don't need to edit the config when manually triggering a DAG. To save users from an unnecessary step, I turned the `Trigger DAG`

[GitHub] [airflow] potiuk commented on a change in pull request #15592: Better description of UID/GID behaviour in image and quickstart

2021-04-29 Thread GitBox
potiuk commented on a change in pull request #15592: URL: https://github.com/apache/airflow/pull/15592#discussion_r623154921 ## File path: docs/docker-stack/entrypoint.rst ## @@ -96,6 +96,28 @@ Airflow image is Open-Shift compatible, which means that you can start it with r

[GitHub] [airflow] potiuk commented on a change in pull request #15592: Better description of UID/GID behaviour in image and quickstart

2021-04-29 Thread GitBox
potiuk commented on a change in pull request #15592: URL: https://github.com/apache/airflow/pull/15592#discussion_r623154362 ## File path: docs/docker-stack/entrypoint.rst ## @@ -96,6 +96,28 @@ Airflow image is Open-Shift compatible, which means that you can start it with r

[GitHub] [airflow] github-actions[bot] commented on pull request #15582: Add more typing to airflow.utils.helpers

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15582: URL: https://github.com/apache/airflow/pull/15582#issuecomment-829372792 [The Workflow run](https://github.com/apache/airflow/actions/runs/796535728) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] github-actions[bot] commented on pull request #15582: Add more typing to airflow.utils.helpers

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15582: URL: https://github.com/apache/airflow/pull/15582#issuecomment-829373193 [The Workflow run](https://github.com/apache/airflow/actions/runs/796537907) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] kaxil merged pull request #15585: `func.sum` may returns `Decimal` that break rest APIs.

2021-04-29 Thread GitBox
kaxil merged pull request #15585: URL: https://github.com/apache/airflow/pull/15585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow-site] potiuk commented on issue #414: Transparency/better description of airflow on the website.

2021-04-29 Thread GitBox
potiuk commented on issue #414: URL: https://github.com/apache/airflow-site/issues/414#issuecomment-829303348 Closing ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow-site] potiuk closed issue #414: Transparency/better description of airflow on the website.

2021-04-29 Thread GitBox
potiuk closed issue #414: URL: https://github.com/apache/airflow-site/issues/414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] kaxil commented on pull request #15556: Add ``serve-logs`` CLI command to serve logs

2021-04-29 Thread GitBox
kaxil commented on pull request #15556: URL: https://github.com/apache/airflow/pull/15556#issuecomment-829316376 Closing in favor of https://github.com/apache/airflow/pull/15557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] kaxil closed pull request #15556: Add ``serve-logs`` CLI command to serve logs

2021-04-29 Thread GitBox
kaxil closed pull request #15556: URL: https://github.com/apache/airflow/pull/15556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil merged pull request #15557: Serve logs with Scheduler when using Local or Sequential Executor

2021-04-29 Thread GitBox
kaxil merged pull request #15557: URL: https://github.com/apache/airflow/pull/15557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil closed issue #13331: Helm Chart uses unsupported commands for Airflow 2.0 - serve_logs

2021-04-29 Thread GitBox
kaxil closed issue #13331: URL: https://github.com/apache/airflow/issues/13331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] kaxil closed pull request #15070: Add serve_logs endpoint for scheduler when using LocalExecutor

2021-04-29 Thread GitBox
kaxil closed pull request #15070: URL: https://github.com/apache/airflow/pull/15070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] kaxil closed issue #15071: Run serve_logs process as part of scheduler command

2021-04-29 Thread GitBox
kaxil closed issue #15071: URL: https://github.com/apache/airflow/issues/15071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] mik-laj commented on a change in pull request #15582: Add more typing to airflow.utils.helpers

2021-04-29 Thread GitBox
mik-laj commented on a change in pull request #15582: URL: https://github.com/apache/airflow/pull/15582#discussion_r623146456 ## File path: airflow/utils/helpers.py ## @@ -31,10 +31,17 @@ from airflow.exceptions import AirflowException from airflow.utils.module_loading

[GitHub] [airflow] kaxil commented on a change in pull request #15585: `func.sum` may returns `Decimal` that break rest APIs.

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #15585: URL: https://github.com/apache/airflow/pull/15585#discussion_r622980931 ## File path: airflow/models/pool.py ## @@ -161,12 +161,13 @@ def occupied_slots(self, session: Session): """ from

[GitHub] [airflow-site] isConic commented on issue #414: Transparency/better description of airflow on the website.

2021-04-29 Thread GitBox
isConic commented on issue #414: URL: https://github.com/apache/airflow-site/issues/414#issuecomment-829294482 Oh wow. Yes. This is everything I needed. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] github-actions[bot] commented on pull request #15591: Add ability to quickly trigger a DAG

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15591: URL: https://github.com/apache/airflow/pull/15591#issuecomment-829354484 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] malthe commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
malthe commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829167561 @uranusjr it seems to me that `conn.schema` should be added there as well: ```python if conn.schema is not None: dsn += "/" + conn.schema ``` E.g.

[GitHub] [airflow] JavierLopezT opened a new issue #15590: Documentation for Configuration JSON when triggering a DAG manually

2021-04-29 Thread GitBox
JavierLopezT opened a new issue #15590: URL: https://github.com/apache/airflow/issues/15590 When you click on 'Trigger Dag', you are redirected to a section in which you can introduce a configuration JSON, and you see a message like this: `To access configuration in your DAG use {{

[GitHub] [airflow] KIRY4 commented on issue #15451: No module named 'airflow.providers.google.common.hooks.leveldb'

2021-04-29 Thread GitBox
KIRY4 commented on issue #15451: URL: https://github.com/apache/airflow/issues/15451#issuecomment-829278278 @potiuk fixed, now everything works perfect! thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[airflow] branch master updated: Serve logs with Scheduler when using Local or Sequential Executor (#15557)

2021-04-29 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 414bb20 Serve logs with Scheduler when

[GitHub] [airflow] kaxil closed issue #14222: Scheduler Logging Unimplemented in Helm Chart with Airflow V2 & SequentialExecutor (serve_log)

2021-04-29 Thread GitBox
kaxil closed issue #14222: URL: https://github.com/apache/airflow/issues/14222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] potiuk commented on pull request #15592: Better description of UID/GID behaviour in image and quickstart

2021-04-29 Thread GitBox
potiuk commented on pull request #15592: URL: https://github.com/apache/airflow/pull/15592#issuecomment-829351054 All resolved @kaxil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow-ci-infra] hmike96 closed pull request #14: Automation for runner AMI creation and CI Infra

2021-04-29 Thread GitBox
hmike96 closed pull request #14: URL: https://github.com/apache/airflow-ci-infra/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (AIRFLOW-5644) Simplify TriggerDagRunOperator usage

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335614#comment-17335614 ] ASF GitHub Bot commented on AIRFLOW-5644: - waleedsamy edited a comment on pull request #6317:

[GitHub] [airflow] potiuk commented on pull request #15576: Prepares provider release after PIP 21 compatibility

2021-04-29 Thread GitBox
potiuk commented on pull request #15576: URL: https://github.com/apache/airflow/pull/15576#issuecomment-829375354 I'd love to release those :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] malthe commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
malthe commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829388253 @potiuk yes, but when you're just providing a connection string, `service_name` is not what gets populated, `conn.schema` is. So if we want `host:port/` to be translated

[GitHub] [airflow] uranusjr commented on a change in pull request #15585: `func.sum` may returns `Decimal` that break rest APIs.

2021-04-29 Thread GitBox
uranusjr commented on a change in pull request #15585: URL: https://github.com/apache/airflow/pull/15585#discussion_r622996974 ## File path: airflow/models/pool.py ## @@ -161,12 +161,13 @@ def occupied_slots(self, session: Session): """ from

[GitHub] [airflow] potiuk commented on issue #15463: Inconsistency between the setup.py and the constraints file

2021-04-29 Thread GitBox
potiuk commented on issue #15463: URL: https://github.com/apache/airflow/issues/15463#issuecomment-829197269 For all interested seems that there is an early attempt to implement constraints in Poetry: https://github.com/python-poetry/poetry/pull/4005 resulting from this discussion:

[GitHub] [airflow] potiuk commented on issue #15451: No module named 'airflow.providers.google.common.hooks.leveldb'

2021-04-29 Thread GitBox
potiuk commented on issue #15451: URL: https://github.com/apache/airflow/issues/15451#issuecomment-829334514 > WARNING - Exception when importing 'airflow.providers.google.common.hooks.leveldb.LevelDBHook' from 'apache-airflow-providers-google' package: No module named

[GitHub] [airflow] kaxil commented on pull request #15562: Fix changing the parent dag state on subdag clear

2021-04-29 Thread GitBox
kaxil commented on pull request #15562: URL: https://github.com/apache/airflow/pull/15562#issuecomment-829289629 Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[airflow] branch master updated: `func.sum` may returns `Decimal` that break rest APIs (#15585)

2021-04-29 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 053d903 `func.sum` may returns `Decimal`

[GitHub] [airflow] JavierLopezT commented on issue #15590: Documentation for Configuration JSON when triggering a DAG manually

2021-04-29 Thread GitBox
JavierLopezT commented on issue #15590: URL: https://github.com/apache/airflow/issues/15590#issuecomment-829418518 > #13365 > Is it related? Indeed, it seems to be what I want. However, I think there isn't any documentation, is it? -- This is an automated message from the

[GitHub] [airflow] DerekHeldtWerle commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
DerekHeldtWerle commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623262956 ## File path: chart/tests/test_annotations.py ## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] turbaszek commented on a change in pull request #14521: Add Asana Provider

2021-04-29 Thread GitBox
turbaszek commented on a change in pull request #14521: URL: https://github.com/apache/airflow/pull/14521#discussion_r623285483 ## File path: airflow/providers/asana/hooks/asana.py ## @@ -0,0 +1,271 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ahayasic commented on issue #12309: TaskGroup does not support dynamically generated tasks

2021-04-29 Thread GitBox
ahayasic commented on issue #12309: URL: https://github.com/apache/airflow/issues/12309#issuecomment-829507253 @ssiddiqui-apixio I'm having the same problem on Airflow 2.0.2. Any chance of the Issue being reopened for a new solution? -- This is an automated message from the Apache Git

[GitHub] [airflow] jedcunningham opened a new pull request #15595: Adds log persistence to helm chart

2021-04-29 Thread GitBox
jedcunningham opened a new pull request #15595: URL: https://github.com/apache/airflow/pull/15595 This adds the option to use a PVC (one provisioned by the chart or an existing claim) to persist Airflow logs. This provides an executor agnostic way to persist all of the Airflow logs.

[GitHub] [airflow] jedcunningham opened a new pull request #15597: Change helm chart logging level back to default (INFO)

2021-04-29 Thread GitBox
jedcunningham opened a new pull request #15597: URL: https://github.com/apache/airflow/pull/15597 The chart shouldn't default the logging level to DEBUG. Instead, we will elect DEBUG when we are running with breeze and let normal releases use the Airflow default of INFO. -- This is

[GitHub] [airflow] potiuk edited a comment on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk edited a comment on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the

[GitHub] [airflow] potiuk edited a comment on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk edited a comment on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the

[GitHub] [airflow] turbaszek commented on a change in pull request #14521: Add Asana Provider

2021-04-29 Thread GitBox
turbaszek commented on a change in pull request #14521: URL: https://github.com/apache/airflow/pull/14521#discussion_r623283331 ## File path: airflow/providers/asana/hooks/asana.py ## @@ -0,0 +1,271 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] dstandish opened a new pull request #15594: Put odbc import behind guard in MsSqlOperator

2021-04-29 Thread GitBox
dstandish opened a new pull request #15594: URL: https://github.com/apache/airflow/pull/15594 MsSqlOperator uses odbc hook when conn_type = 'odbc' The import here of OdbcHook, used only for type hinting, should be behind `TYPE_CHECKING` guard see:

[GitHub] [airflow] dstandish edited a comment on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish edited a comment on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009 @eladkal for background, the original thought was that we would deprecate support for pymssql and switch to pyodbc since the pymssql project, at the time, had been

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335811#comment-17335811 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish commented on pull request #6850: URL:

[GitHub] [airflow] JavierLopezT edited a comment on issue #15590: Documentation for Configuration JSON when triggering a DAG manually

2021-04-29 Thread GitBox
JavierLopezT edited a comment on issue #15590: URL: https://github.com/apache/airflow/issues/15590#issuecomment-829418518 > #13365 > Is it related? Indeed. However, it seems that it would render the entire documentation of the dag, isn't it? What I propose is a separate doc

[GitHub] [airflow] DerekHeldtWerle commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
DerekHeldtWerle commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623262956 ## File path: chart/tests/test_annotations.py ## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335812#comment-17335812 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish edited a comment on pull request #6850:

[GitHub] [airflow] potiuk commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the oracle

[GitHub] [airflow] potiuk opened a new pull request #15593: Add docker-context-files detection and cleanup flag.

2021-04-29 Thread GitBox
potiuk opened a new pull request #15593: URL: https://github.com/apache/airflow/pull/15593 When building images for production we are using docker-context-files where we build packages to install. However if those context files are not cleaned up, they unnecessary increase size and

[GitHub] [airflow] kaxil commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations

2021-04-29 Thread GitBox
kaxil commented on pull request #15238: URL: https://github.com/apache/airflow/pull/15238#issuecomment-829493407 @DerekHeldtWerle Can you fix the failing static checks please: https://github.com/apache/airflow/pull/15238/checks?check_run_id=2301349726#step:10:245 ```diff diff

[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish commented on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829582644 OK @eladkal i think in #15594 i have successfully removed the interdependency while maintaining verification of _compatibility_ in the mssql operator test. Please take

[GitHub] [airflow] malthe commented on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
malthe commented on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829590431 @potiuk just a quick question – the Oracle-specific fields in the connection documentation (e.g. "Sid" and "Service_name"), those don't make sense to me at all looking at:

[GitHub] [airflow] levyitay opened a new issue #15598: Qubole Hook Does Not Support 'include_headers'

2021-04-29 Thread GitBox
levyitay opened a new issue #15598: URL: https://github.com/apache/airflow/issues/15598 **Description** Qubole Hook and Operator do not support `include_header` param for getting results with headers Add Support for `include_header` get_results(... arguments=[True])

[GitHub] [airflow] DerekHeldtWerle commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations

2021-04-29 Thread GitBox
DerekHeldtWerle commented on pull request #15238: URL: https://github.com/apache/airflow/pull/15238#issuecomment-829593227 @FloChehab in our multi-tenant setup, airflow dags run in each teams namespace. With these annotations, we can easily replicate the airflow configmap to each

[GitHub] [airflow] potiuk edited a comment on pull request #15589: [Oracle] Add port to DSN

2021-04-29 Thread GitBox
potiuk edited a comment on pull request #15589: URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066 > So if we want host:port/ to be translated back to host:port/, then it seems conn.schema is the way to go. Hmm. I think this is not how (at least originally) the

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335768#comment-17335768 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish edited a comment on pull request #6850:

[GitHub] [airflow] JavierLopezT edited a comment on issue #15590: Documentation for Configuration JSON when triggering a DAG manually

2021-04-29 Thread GitBox
JavierLopezT edited a comment on issue #15590: URL: https://github.com/apache/airflow/issues/15590#issuecomment-829418518 > #13365 > Is it related? Indeed, thanks. However, it seems that it would render the entire documentation of the dag, isn't it? What I propose is a separate

[airflow] branch master updated: add an option to trigger a dag w/o changing conf (#15591)

2021-04-29 Thread ryanahamilton
This is an automated email from the ASF dual-hosted git repository. ryanahamilton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 943e3ca add an option to trigger a dag

[GitHub] [airflow] github-actions[bot] commented on pull request #15238: adds airflowConfigAnnotations field to allow for the setting of the main configmaps annotations

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #15238: URL: https://github.com/apache/airflow/pull/15238#issuecomment-829494527 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] dstandish edited a comment on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

2021-04-29 Thread GitBox
dstandish edited a comment on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009 @eladkal TLDR it seems like we should be able to remove that interdependency by putting this line behind an `if TYPING` guard:

[jira] [Commented] (AIRFLOW-6296) add mssql odbc hook

2021-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335767#comment-17335767 ] ASF GitHub Bot commented on AIRFLOW-6296: - dstandish edited a comment on pull request #6850:

[GitHub] [airflow] argibbs opened a new issue #15596: Using SLAs causes DagFileProcessorManager timeouts and prevents deleted dags from being recreated

2021-04-29 Thread GitBox
argibbs opened a new issue #15596: URL: https://github.com/apache/airflow/issues/15596 **Apache Airflow version**: 2.0.1 and 2.0.2 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): N/A **Environment**: Celery executors, Redis + Postgres -

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15596: Using SLAs causes DagFileProcessorManager timeouts and prevents deleted dags from being recreated

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on issue #15596: URL: https://github.com/apache/airflow/issues/15596#issuecomment-829569460 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb merged pull request #15444: An initial rework of the "Concepts" documentation

2021-04-29 Thread GitBox
ashb merged pull request #15444: URL: https://github.com/apache/airflow/pull/15444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] DerekHeldtWerle commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
DerekHeldtWerle commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623386662 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15598: Qubole Hook Does Not Support 'include_headers'

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on issue #15598: URL: https://github.com/apache/airflow/issues/15598#issuecomment-829593473 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ryanahamilton merged pull request #15591: Add ability to quickly trigger a DAG

2021-04-29 Thread GitBox
ryanahamilton merged pull request #15591: URL: https://github.com/apache/airflow/pull/15591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] bensonnd commented on issue #15580: KubernetesExecutor not deleting worker pods on completion.

2021-04-29 Thread GitBox
bensonnd commented on issue #15580: URL: https://github.com/apache/airflow/issues/15580#issuecomment-829522449 Commenting to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r62603 ## File path: chart/values.yaml ## @@ -427,6 +453,20 @@ scheduler: affinity: {} tolerations: [] +# Airflow migration and create user job settings

[GitHub] [airflow] trollhe opened a new issue #15607: airflow throws error: airflow.exceptions.SerializedDagNotFound: DAG 'dns-basic-1min' not found in serialized_dag table

2021-04-29 Thread GitBox
trollhe opened a new issue #15607: URL: https://github.com/apache/airflow/issues/15607 hi,team: i deployment airflow 2.0.2 in docker by docker-compose,airflow service start just 1 minute have many dags,bug 1 minute after dag is none,and throws bellow error: already

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15609: Update s3.py

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on pull request #15609: URL: https://github.com/apache/airflow/pull/15609#issuecomment-829761790 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] Isaacwhyuenac opened a new pull request #15609: Update s3.py

2021-04-29 Thread GitBox
Isaacwhyuenac opened a new pull request #15609: URL: https://github.com/apache/airflow/pull/15609 The changes improves the process of finding the S3 files and gives developer the freedom to list what they want. For example, suppose in s3 bucket there are ``` 2021-04-30

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623416129 ## File path: chart/templates/_helpers.yaml ## @@ -364,6 +383,105 @@ server_tls_key_file = /etc/pgbouncer/server.key {{ (printf "%s-airflow-config"

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623416129 ## File path: chart/templates/_helpers.yaml ## @@ -364,6 +383,105 @@ server_tls_key_file = /etc/pgbouncer/server.key {{ (printf "%s-airflow-config"

[GitHub] [airflow] kaxil commented on a change in pull request #14152: Helm RBAC Best Practices

2021-04-29 Thread GitBox
kaxil commented on a change in pull request #14152: URL: https://github.com/apache/airflow/pull/14152#discussion_r623447730 ## File path: chart/templates/statsd/statsd-serviceaccount.yaml ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[airflow] branch master updated: Fix KEDA Autoscaler ``connectionFromEnv`` (#15561)

2021-04-29 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 924af8d Fix KEDA Autoscaler

[GitHub] [airflow] github-actions[bot] commented on pull request #14745: Make sure DAGs with tasks in shutdown state do get scheduled

2021-04-29 Thread GitBox
github-actions[bot] commented on pull request #14745: URL: https://github.com/apache/airflow/pull/14745#issuecomment-829707435 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] closed issue #14931: sqlite3.databaseerror database disk image is malformed in airflow

2021-04-29 Thread GitBox
github-actions[bot] closed issue #14931: URL: https://github.com/apache/airflow/issues/14931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] rpfernandezjr commented on issue #15580: KubernetesExecutor not deleting worker pods on completion.

2021-04-29 Thread GitBox
rpfernandezjr commented on issue #15580: URL: https://github.com/apache/airflow/issues/15580#issuecomment-829699581 Was messing with this today some more. If I set `AIRFLOW__KUBERNETES__POD_TEMPLATE_FILE` and point that to this template file ``` --- apiVersion: v1 kind:

[GitHub] [airflow] fredthomsen opened a new pull request #15605: Update SimpleHttpOperator to take auth type object

2021-04-29 Thread GitBox
fredthomsen opened a new pull request #15605: URL: https://github.com/apache/airflow/pull/15605 A requests.auth.AuthBase object is not passed through from the SimpleHttpOperator to the underlying HttpHook, thus if you want to use the SimpleHttpOperator but have a custom auth_type, you

[GitHub] [airflow] github-actions[bot] commented on issue #14931: sqlite3.databaseerror database disk image is malformed in airflow

2021-04-29 Thread GitBox
github-actions[bot] commented on issue #14931: URL: https://github.com/apache/airflow/issues/14931#issuecomment-829707408 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15605: Update SimpleHttpOperator to take auth type object

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on pull request #15605: URL: https://github.com/apache/airflow/pull/15605#issuecomment-829711871 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15608: airflow dag support multiple versions

2021-04-29 Thread GitBox
boring-cyborg[bot] commented on issue #15608: URL: https://github.com/apache/airflow/issues/15608#issuecomment-829756085 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

  1   2   >