[GitHub] [airflow] Bruschkov commented on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader

2020-01-15 Thread GitBox
Bruschkov commented on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in 
RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-574582795
 
 
   @potiuk 
   
   Everything solved and build passes now.
   
   Best regards


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] Bruschkov commented on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader

2020-01-14 Thread GitBox
Bruschkov commented on issue #7153: [AIRFLOW-5117] Fixed Timestamp bug in 
RefreshKubeConfigLoader
URL: https://github.com/apache/airflow/pull/7153#issuecomment-574201470
 
 
   > I'd still prefer to have a test for that one. This should b e rather easy 
to add such test.
   > 
   > There is already the tests/kubernetes/test_client.py with two tests and 
adding a test there would be just great (we need to improve coverage on 
Kubernetes part and even really small tests like that gradually added help a 
lot)
   > 
   > Would you be so nice to add it please?
   
   Hi, thanks for your quick feedback. Added the test and amended the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services