[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-11-11 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-552699552 @hredestig You can find the PR here - https://github.com/apache/airflow/pull/6552. Please consider helping with your r

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-11-04 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-549632563 @hredestig I wrote a patch for that a few weeks ago but couldn't send it back upstream. Thanks for pointing out. I'

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-08-15 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-521706461 @acordiner That's great. Would you like to list down your thoughts/ideas as a ticket in [JIRA](https://issues.apache

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-08-15 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-521615573 @acordiner thanks. If the feature is supported by the Python Docker client API, it should be pretty straightforward to

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-08-13 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-520856661 @mik-laj Thank you for reviewing the PR in so much detail and approval. As far as I understand, I need another ap

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-07-24 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-514585747 @mik-laj I went ahead and updated the PR to incorporate your suggestions as explained in my last comment. I would ap

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-07-14 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-511273852 @mik-laj I see your point regarding `_execute`. I think `_execute` is actually doing the things a `run_image` metho

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-07-14 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-511273762 I see your point regarding `_execute`. I think `_execute` is actually doing the things a `run_image` method should be d

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-07-09 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-509610888 Just forced push to trigger Travis again - it's green now! Would anyone like to review this now and let me know t

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-07-04 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-508605270 @potiuk Apologies for taking this long (got stuck with something else). I have addressed your above comments. Please ha

[GitHub] [airflow] akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

2019-07-01 Thread GitBox
akki commented on issue #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator) URL: https://github.com/apache/airflow/pull/5489#issuecomment-507500554 @mik-laj Thanks, your examples helped me understand the pylint errors better. I've fixed them now and also moved the op