ashb commented on a change in pull request #6145: [AIRFLOW-5518] Use correct
scheme for Http connection parsed from URI
URL: https://github.com/apache/airflow/pull/6145#discussion_r325775979
##########
File path: tests/models/test_connection.py
##########
@@ -212,31 +212,31 @@ def test_connection_from_uri_with_path(self):
(
"http://:password@host:80/database";,
ConnectionParts(
- conn_type="http", login='', password="password",
host="host", port=80, schema="database"
+ conn_type="http", login='', password="password",
host="host", port=80, schema="http"
Review comment:
I am not a fan of this - it papers over the bug and makes it more confusing
- schema does not mean the same as scheme.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
