[GitHub] [airflow] ashb commented on issue #7421: [AIRFLOW-XXXX] Speed up mypy runs.
ashb commented on issue #7421: [AIRFLOW-] Speed up mypy runs. URL: https://github.com/apache/airflow/pull/7421#issuecomment-586472520 That 8x was from comparing `time pre-commit run mypy -a` (~4.7s) to `mypy airflow docs test` (0.7s) 6.7x difference. This is on linux, and entirely possibly something about my setup (for instance I'm running docker on btrfs because I'm experimenting.) Anyway. Just an observation, I still think dockerizing these checks by default is the right thing to do. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #7421: [AIRFLOW-XXXX] Speed up mypy runs.
ashb commented on issue #7421: [AIRFLOW-] Speed up mypy runs. URL: https://github.com/apache/airflow/pull/7421#issuecomment-586457823 Just for the record: It seems that "dockerising" it adds about an 8x overhead though :( ``` $ time mypy airflow docs/ tests Success: no issues found in 1831 source files mypy airflow docs/ tests 0.61s user 0.06s system 99% cpu 0.668 total ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #7421: [AIRFLOW-XXXX] Speed up mypy runs.
ashb commented on issue #7421: [AIRFLOW-] Speed up mypy runs. URL: https://github.com/apache/airflow/pull/7421#issuecomment-586457351 @potiuk Good idea on require_serial -- that has the same effect for all files, but makes a single file "work" and it is still marginally quicker for a single file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #7421: [AIRFLOW-XXXX] Speed up mypy runs.
ashb commented on issue #7421: [AIRFLOW-] Speed up mypy runs. URL: https://github.com/apache/airflow/pull/7421#issuecomment-586405375 Could be. Would be interesting to see if mypy also chases down "delayed" imports (i.e. ones inside functions) at which point there's only so much we can do. But anyway, mypy time is relatively tiny in comparison to pylint :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #7421: [AIRFLOW-XXXX] Speed up mypy runs.
ashb commented on issue #7421: [AIRFLOW-] Speed up mypy runs. URL: https://github.com/apache/airflow/pull/7421#issuecomment-586350360 Sure, I'll test that out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #7421: [AIRFLOW-XXXX] Speed up mypy runs.
ashb commented on issue #7421: [AIRFLOW-] Speed up mypy runs. URL: https://github.com/apache/airflow/pull/7421#issuecomment-586290473 Seems to give a modest speed up on Travis (25s to 19s) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #7421: [AIRFLOW-XXXX] Speed up mypy runs.
ashb commented on issue #7421: [AIRFLOW-] Speed up mypy runs. URL: https://github.com/apache/airflow/pull/7421#issuecomment-586270461 I'm a little bit surprised by the difference, but it was consistent on my laptop. Would appreciate others testing too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
