[GitHub] [airflow] dimberman commented on a change in pull request #7832: [WIP] Add production image support

2020-03-23 Thread GitBox
dimberman commented on a change in pull request #7832: [WIP] Add production 
image support
URL: https://github.com/apache/airflow/pull/7832#discussion_r396687635
 
 

 ##
 File path: Dockerfile
 ##
 @@ -0,0 +1,325 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# THIS DOCKERFILE IS INTENDED FOR PRODUCTION USE AND DEPLOYMENT.
+# NOTE! IT IS ALFA-QUALITY FOR NOW - WE ARE IN A PROCESS OF TESTING IT
+#
+#
+# This is a multi-segmented image. It actually contains two images:
+#
+# airflow-build-image  - there all airflow dependencies can be installed (and
+#built - for those dependencies that require
+#build essentials). Airflow is installed there with
+#--user switch so that all the dependencies are
+#installed to ${HOME}/.local
+#
+# main - this is the actual production image that is much
+#smaller because it does not contain all the build
+#essentials. Instead the ${HOME}/.local folder
+#is copied from the build-image - this way we have
+#only result of installation and we do not need
+#all the build essentials. This makes the image
+#nuch smaller.
+#
+ARG PYTHON_BASE_IMAGE="python:3.6-slim-buster"
+
+ARG AIRFLOW_VERSION="2.0.0.dev0"
 
 Review comment:
   Is the image going to start at 2.0 or will we backport later?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dimberman commented on a change in pull request #7832: [WIP] Add production image support

2020-03-23 Thread GitBox
dimberman commented on a change in pull request #7832: [WIP] Add production 
image support
URL: https://github.com/apache/airflow/pull/7832#discussion_r396686998
 
 

 ##
 File path: BREEZE.rst
 ##
 @@ -348,18 +349,43 @@ In case of disk space errors on macOS, increase the disk 
space available for Doc
 Building the Images
 ---
 
-You can manually trigger building the local images using the script:
+You can manually trigger building the local CI image using this command:
 
 .. code-block::
 
-  ./breeze build-only
+  ./breeze build-ci-image
 
-The scripts that build the images are optimized to minimize the time needed to 
rebuild the image when
+And production image using this command:
+
+.. code-block::
+
+  ./breeze build-prod-image
 
 Review comment:
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services