[GitHub] [airflow] dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-18 Thread GitBox
dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#issuecomment-532965215 Sounds like you don't like the `private_key` hook init param. I don't care about this I was just adding it to be consistent

[GitHub] [airflow] dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-18 Thread GitBox
dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#issuecomment-532817543 I did provide an example connection string in the documentation file, following the example with existing param `key_file`. I

[GitHub] [airflow] dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-17 Thread GitBox
dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#issuecomment-532440383 @pgagnon the same could be said of password, which some hooks have. The point of this in my view is that ssh is a connection

[GitHub] [airflow] dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-15 Thread GitBox
dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#issuecomment-531580727 @mik-laj thank you -- did not realize there was this doc. I have updated.