[GitHub] [airflow] haoliang7 commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel
haoliang7 commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-534101976 > > Maybe we can use `.airflowignore` for that? @feluelle > > @nuclearpinguin That's exactly what I thought of, too. 👍 > Depending on the services `gcp`,`azure`, etc. we can ship a pre-defined `.airflowignore` file when installing via `initdb` and example_dags enabled. > > > How about moving the whole set of transfer operators/examples into a separate "transfer" sub-package- following AIP-21 principles. We have not agreed at the time of AIP-21 what we are going to do with transfer operators, but this sounds like one possible approach that could solve this problem ? We talked about it with @mik-laj and I think we both think it's a good idea > > That sounds also pretty good. @potiuk I am not sure how do we automatically edit `.airflowignore` file according to the installed dependencies. For example, when GCP dependencies are installed enbale GCP examples otherwise ignore them. Can we just skip the examples that cannot be imported when collecting dags? So that the users would not be confused by the error messages when only devel dependencies are installed. I have put that in my last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] haoliang7 commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel
haoliang7 commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533076731 > I don't think this is right. Because it is not a minimal requirement for all example dags to run. > > If you want to install an integration service like GCP you can install it via pip install -e ".[devel,gcp]" I assume by the purpose of devel that we should be able to initialize the database without an error after install devel dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] haoliang7 commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel
haoliang7 commented on issue #6147: [AIRFLOW-5512] Add gcp dependencies into devel URL: https://github.com/apache/airflow/pull/6147#issuecomment-533071890 > If you want to install an integration service like GCP you can install it via `pip install -e ".[devel,gcp]"` @feluelle LOCAL_VIRTUALENV.rst says run `airflow db init` after `pip install -e ".[devel]"`. But errors occur due to missing gcp dependencies. Should we just ignore the errors? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
