[GitHub] [airflow] j-y-matsubara edited a comment on pull request #9531: Support .airflowignore for plugins

2020-07-01 Thread GitBox 


j-y-matsubara edited a comment on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-651678532


   I think the one failure of tests doesn't seem to have anything to do with 
this PR.
   The same error occurs in other PRs.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] j-y-matsubara edited a comment on pull request #9531: Support .airflowignore for plugins : .pluginingore

2020-06-28 Thread GitBox 


j-y-matsubara edited a comment on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-650781887


   > Could you add some tests? For plugin managers testing, 
tests.test_utils.mock_plugins.mock_plugin_manager may be helpful. A perfect 
test can create the required files in a temporary directory 
(NamedTemporaryFile) and then check if the plugins have been loaded.
   
   Thank you for your advice.
   I added a test.
   And moved method to airflow.utils.file.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org