[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603823189 > > Options: > > > > 1. `connections_path_prefix` > > 2. `connections_prefix` > > 3. `connections_path` > > > > What do others think @potiuk @ashb > > Add a comment here to keep a record on what we discussed on Slack: > > * @kaxil and I agree on using `connections_prefix` because it is more generic than `path` and may apply to different systems better (GCP Secrets Manager does not support `/`, so `airflow/connections` is invalid.) Hey, Let's keep the args as it is. After reading some more docs on **Hashicorp Vault** and talking to Ash, I am going to not change the args for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603557518 > For some context, this is a snapshot of the `parameter store` service. So I feel like better to still have the `ParameterStore` part > >  Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603547473 `SystemManagerParametersBackend` stripping AWS as we don't use GCP or Hashicorp in their respective backends too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545674 `AwsSystemsManagerParameterStoreBackend` wow that name would be huge `AwsSMParameterStoreBackend` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545387 > I think SecretsManager may be something else. Go AWS! 🤦♂ I am confused. WTH! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603544562 > Aws SSM How about `AwdSecretsManager`? (Based on https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603543023 Options: 1. `connections_path_prefix` 2. `connections_prefix` 3. `connections_path` What do others think @potiuk @ashb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603436714 > Nice! Like the name standardization. I am also thinking if we should standardize the `connection_prefix` (used in AWS SSM & GCP Secrets Manager) and `connection_path` ( in Hashicorp Vault) What name would you suggest ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
