[GitHub] [airflow] mik-laj commented on a change in pull request #7864: GCP SparkR operator

[GitBox]

mik-laj commented on a change in pull request #7864: GCP SparkR operator
URL: https://github.com/apache/airflow/pull/7864#discussion_r406233189
 
 

 ##
 File path: airflow/providers/google/cloud/operators/dataproc.py
 ##
 @@ -1359,6 +1359,128 @@ def execute(self, context):
 super().execute(context)
 
 
+class DataprocSubmitSparkRJobOperator(DataprocJobBaseOperator):
 
 Review comment:
   
https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/example_dags/example_dataproc.py#L141-L166


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7864: GCP SparkR operator

[GitBox]

mik-laj commented on a change in pull request #7864: GCP SparkR operator
URL: https://github.com/apache/airflow/pull/7864#discussion_r397782413
 
 

 ##
 File path: airflow/contrib/operators/dataproc_operator.py
 ##
 @@ -157,6 +157,22 @@ def __init__(self, *args, **kwargs):
 super().__init__(*args, **kwargs)
 
 
+class DataProcSparkROperator(DataprocSubmitSparkRJobOperator):
 
 Review comment:
   It is not necessary. This is only needed if this operator was available in 
Airflow 1.10.x


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services