[GitHub] [airflow] mik-laj commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-18 Thread GitBox
mik-laj commented on issue #6104: [AIRFLOW-4574] allow providing private_key in 
SSHHook
URL: https://github.com/apache/airflow/pull/6104#issuecomment-532911018
 
 
   I think that it is very useful to be able to configure connections using 
environment variables. Airflow is launched very often in clusters in an 
automated manner and the ability to easily define a connection is key.  
Incorrect use is possible, but it is very limited and not very obvious. 
   
   I think that in order to dispel any doubts it is worth adding a short 
warning notice when describing the ``private_key`` parameter. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

2019-09-15 Thread GitBox
mik-laj commented on issue #6104: [AIRFLOW-4574] allow providing private_key in 
SSHHook
URL: https://github.com/apache/airflow/pull/6104#issuecomment-531545093
 
 
   Can you also update documentation? 
   https://airflow.readthedocs.io/en/latest/howto/connection/ssh.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services