[GitHub] [airflow] mik-laj commented on pull request #9531: Support .airflowignore for plugins

2020-07-02 Thread GitBox 


mik-laj commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-652901310


   Please ignore it. It is not related. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9531: Support .airflowignore for plugins

2020-07-01 Thread GitBox 


mik-laj commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-652396856


   @turbaszek Can I ask for review?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9531: Support .airflowignore for plugins : .pluginingore

2020-06-27 Thread GitBox 


mik-laj commented on pull request #9531:
URL: https://github.com/apache/airflow/pull/9531#issuecomment-650706759


   Could you add some tests? For plugin managers testing, 
tests.test_utils.mock_plugins.mock_plugin_manager may be helpful. A perfect 
test can create the required files in a temporary directory 
(NamedTemporaryFile) and then check if the plugins have been loaded.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org