[GitHub] [airflow] potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module

2019-12-03 Thread GitBox
potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module URL: https://github.com/apache/airflow/pull/6718#issuecomment-561206336 @ashb @kaxil -> pls take a look. It's changed since the approval a lot. ---

[GitHub] [airflow] potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module

2019-12-03 Thread GitBox
potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module URL: https://github.com/apache/airflow/pull/6718#issuecomment-561206127 And some more pylint complaints (rightfully so) I also moved BaseSerialization in the same "serialization_objects.py". Now this module

[GitHub] [airflow] potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module

2019-12-03 Thread GitBox
potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module URL: https://github.com/apache/airflow/pull/6718#issuecomment-561170532 Rebased now on top of #6596 This is an automated message from the Apa

[GitHub] [airflow] potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module

2019-12-03 Thread GitBox
potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module URL: https://github.com/apache/airflow/pull/6718#issuecomment-561158929 I will rebase it on top of #6596 to see if it works with hose fixes.

[GitHub] [airflow] potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module

2019-12-03 Thread GitBox
potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module URL: https://github.com/apache/airflow/pull/6718#issuecomment-561149105 @kaxil @ashb @mik-laj -> Just pushed fixup which removes the cast and fixes it "properly" I think. I moved subdag to BaseOperator and a

[GitHub] [airflow] potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module

2019-12-03 Thread GitBox
potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module URL: https://github.com/apache/airflow/pull/6718#issuecomment-561145641 In my upcoming fix I also merge serialized_dag and serialized_baseoperator into one module 'serialized_objects' - because there are cyc

[GitHub] [airflow] potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module

2019-12-03 Thread GitBox
potiuk commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module URL: https://github.com/apache/airflow/pull/6718#issuecomment-561145288 @kaxil -> I have a fix in making for that (but the #6596 should be merge first because we have the errors fixed in this PR). -