[GitHub] danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection
danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-456208799 Thanks for the feedback @ashb, @XD-DENG , I think I've addressed all the comments. Please let me know if anything else needs tweaking! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection
danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455384494 Since the query parameter bit is the same as for other Connection types, perhaps it makes more sense for the general case to be documented in the "Creating a Connection with Environment Variables" section to avoid repetition? I'll add the general default `conn_id`, but I'm not sure it's worth including all of the hooks and operators for this, there are quite a lot and it would be tough to ensure this doc section is completely maintained going forward. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection
danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-455352968 @mik-laj Oh cool, I didn't know you could do that! I'm afraid I haven't set up the AWS Connection that way before so I'm not aware of any AWS-specific things you might need to specify when setting it up that way. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection
danabananarama commented on issue #4514: [AIRFLOW-3698] Add documentation for AWS Connection URL: https://github.com/apache/airflow/pull/4514#issuecomment-454989017 I've updated the PR to add a bit in the _Managing Connections_ page in the docs, please let me know if there's a more suitable home for it or if anything needs rewording (: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
