Re: [PR] Add back security api in FAB auth manager [airflow]
HuanjieGuo commented on code in PR #51578: URL: https://github.com/apache/airflow/pull/51578#discussion_r2140909931 ## providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py: ## @@ -525,6 +525,14 @@ def add_view_no_menu(self, baseview, endpoint=None, static_folder=None): log.warning(LOGMSG_WAR_FAB_VIEW_EXISTS, baseview.__class__.__name__) return baseview +def add_api(self, baseview): Review Comment: works. thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add back security api in FAB auth manager [airflow]
vincbeck commented on code in PR #51578: URL: https://github.com/apache/airflow/pull/51578#discussion_r2140518907 ## providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py: ## @@ -525,6 +525,14 @@ def add_view_no_menu(self, baseview, endpoint=None, static_folder=None): log.warning(LOGMSG_WAR_FAB_VIEW_EXISTS, baseview.__class__.__name__) return baseview +def add_api(self, baseview): Review Comment: `airflow/www/extensions/init_appbuilder.py` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add back security api in FAB auth manager [airflow]
vincbeck commented on code in PR #51578: URL: https://github.com/apache/airflow/pull/51578#discussion_r2140517738 ## providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py: ## @@ -525,6 +525,14 @@ def add_view_no_menu(self, baseview, endpoint=None, static_folder=None): log.warning(LOGMSG_WAR_FAB_VIEW_EXISTS, baseview.__class__.__name__) return baseview +def add_api(self, baseview): Review Comment: In Airflow 2, this is not in FAB provider but in core Airflow. The file is there: https://github.com/apache/airflow/blob/v2-10-test/airflow/www/extensions/init_appbuilder.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add back security api in FAB auth manager [airflow]
HuanjieGuo commented on code in PR #51578: URL: https://github.com/apache/airflow/pull/51578#discussion_r2140475827 ## providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py: ## @@ -525,6 +525,14 @@ def add_view_no_menu(self, baseview, endpoint=None, static_folder=None): log.warning(LOGMSG_WAR_FAB_VIEW_EXISTS, baseview.__class__.__name__) return baseview +def add_api(self, baseview): Review Comment: @vincbeck can you pls guild how to patch this in fab-1.5.2 provider? We don't have this folder in 1.5.2. providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add back security api in FAB auth manager [airflow]
vincbeck merged PR #51578: URL: https://github.com/apache/airflow/pull/51578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Add back security api in FAB auth manager [airflow]
vincbeck opened a new pull request, #51578:
URL: https://github.com/apache/airflow/pull/51578
Resolves #51551.
Between 2.8.4 and 2.10.5, the security API has been removed from FAB auth
manager. This API allows users to generate a JWT token using credentials.
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
