Re: [PR] Fix use correct PATCH permission for /users/{username} endpoint [airflow]
vincbeck merged PR #61462: URL: https://github.com/apache/airflow/pull/61462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix use correct PATCH permission for /users/{username} endpoint [airflow]
vincbeck commented on PR #61462:
URL: https://github.com/apache/airflow/pull/61462#issuecomment-3849425836
> > That's expected, in Airflow auth model we use `PUT` to any modification
operation. Which is the case here. I dont see any benefit of using `PATCH`
>
> I noticed that the `/roles/{name}` endpoint uses `PATCH` in the permission
check, so I want to update the `/users/{username} `endpoint to also use `PATCH`
for consistency. wdyt?
>
> or update `/roles/{name}` to use PUT instead?
Good catch, it should be `PUT`, can you please update it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix use correct PATCH permission for /users/{username} endpoint [airflow]
henry3260 commented on PR #61462:
URL: https://github.com/apache/airflow/pull/61462#issuecomment-3849303535
> That's expected, in Airflow auth model we use `PUT` to any modification
operation. Which is the case here. I dont see any benefit of using `PATCH`
I noticed that the `/roles/{name}` endpoint uses `PATCH` in the permission
check, so I want to update the `/users/{username} `endpoint to also use `PATCH`
for consistency. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] Fix use correct PATCH permission for /users/{username} endpoint [airflow]
henry3260 opened a new pull request, #61462:
URL: https://github.com/apache/airflow/pull/61462
---
# Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
