Re: [PR] openlineage: accept whole config when instantiating OpenLineageClient [airflow]
mobuchowski merged PR #43740: URL: https://github.com/apache/airflow/pull/43740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] openlineage: accept whole config when instantiating OpenLineageClient [airflow]
mobuchowski commented on PR #43740: URL: https://github.com/apache/airflow/pull/43740#issuecomment-2459944392 We'll look into it... It's not a normal procedure for us -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] openlineage: accept whole config when instantiating OpenLineageClient. [airflow]
JDarDagran opened a new pull request, #43740:
URL: https://github.com/apache/airflow/pull/43740
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
Before 1.24.0 `OpenLineageClient.from_dict` accepted only transport
configuration. This PR aims to allow passing whole config read from yaml file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] openlineage: accept whole config when instantiating OpenLineageClient [airflow]
JDarDagran commented on PR #43740: URL: https://github.com/apache/airflow/pull/43740#issuecomment-2459832751 To be clear: 1.24.0 introduced backwards-incompatible changes that were fixed in 1.24.2 (`from_dict` in 1.24.0 assumed you can pass dict with full config, not only transport. I don't think it's relevant what was exactly the problem but just saying). Therefore if OL providers attempts to upgrade `openlineage-python` to the latest version they should be fine (@mobuchowski is running canary build [here](https://github.com/apache/airflow/pull/43742) to confirm that). In 1.24.2 we add possibility to pass config as argument (not only transport as it was in case of `from_dict` method that we deprecate in this version). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] openlineage: accept whole config when instantiating OpenLineageClient [airflow]
potiuk commented on PR #43740: URL: https://github.com/apache/airflow/pull/43740#issuecomment-2459843088 > In 1.24.2 we add possibility to pass config as argument (not only transport as it was in case of from_dict method that we deprecate in this version). Understood! perfect then! Should you also yank 1.24.0 and 1.24.1 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] openlineage: accept whole config when instantiating OpenLineageClient [airflow]
potiuk commented on PR #43740: URL: https://github.com/apache/airflow/pull/43740#issuecomment-2459819218 Does it mean that previous versions of openlineage provider will fail with 1.24? Is there any mechanism that the users of past openlineage provider will be warned or guided to upgrade to the new provider when their provider will start to fail after upgrading to 1.24.2 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
