[jira] [Commented] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

2019-07-13 Thread Ash Berlin-Taylor (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884488#comment-16884488
 ] 

Ash Berlin-Taylor commented on AIRFLOW-4921:


Output I get on the RC:

{noformat}
 2019-07-13 22:19:40.689158
 2019-07-13 22:19:40.761653
 2019-07-13 22:19:40.782002
 2019-07-13 22:19:40.795771
 2019-07-13 22:19:40.812790
 2019-07-13 22:19:40.829807
 2019-07-13 22:19:40.850117
 2019-07-13 22:19:40.983008
 2019-07-13 22:19:41.040358
 2019-07-13 22:19:41.138533
 2019-07-13 22:19:41.225288
 2019-07-13 22:19:41.254749
 2019-07-13 22:19:41.301274
 2019-07-13 22:19:41.331035
 2019-07-13 22:19:41.356568
 2019-07-13 22:19:41.381656
{noformat}

> scheduler stuck with schedule is 2.30am and timezone is daylight saving time
> 
>
> Key: AIRFLOW-4921
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4921
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: scheduler
>Affects Versions: 1.10.3
>Reporter: dungnguyen
>Priority: Major
>
> Pls correct me if I'm wrong, but I'm still able to reproduce the issue using 
> below code
>  
> {code:java}
> import pendulum
> from airflow import DAG
> from airflow.jobs import SchedulerJob
> from datetime import timedelta, datetime
> tz = pendulum.timezone('America/New_York')
> # Set-up DAG
> test_dag = DAG(
>   dag_id='foo',
>   start_date=datetime(2017, 3, 6, tzinfo=tz),
>   schedule_interval='30 02 * * *',
>   catchup=True
> )
> # manually trigger create_dag_run
> s = SchedulerJob()
> for _ in range(465):
>   dag_run = s.create_dag_run(test_dag)
>   print(dag_run, datetime.now())
> {code}
>  
> The output will be stuck on the date of daylight saving change
>  
> {code:java}
> [2019-07-09 14:46:38,014] {__init__.py:51} INFO - Using executor 
> SequentialExecutor
>  scheduled__2017-03-06T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.268086
>  scheduled__2017-03-07T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.460748
>  scheduled__2017-03-08T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.649766
>  scheduled__2017-03-09T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.838063
>  scheduled__2017-03-10T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.030536
>  scheduled__2017-03-11T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.219713
>  scheduled__2017-03-12T06:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.408905
> {code}
>  
> The suspect I think is a loop in airflow/jobs/scheduler_job.py. This code is 
> stuck when dag.following_schedule(next_run_date) return value with no change
>  
> {code:java}
> # make sure backfills are also considered
> last_run = dag.get_last_dagrun(session=session)
> if last_run and next_run_date:
>   while next_run_date <= last_run.execution_date:
> next_run_date = dag.following_schedule(next_run_date)
> {code}
>  
> Pls let me know if I need to provide more information.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

2019-07-13 Thread Ash Berlin-Taylor (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884484#comment-16884484
 ] 

Ash Berlin-Taylor commented on AIRFLOW-4921:


Likely already fixed in 1.10.4RC2 by AIRFLOW-4308

> scheduler stuck with schedule is 2.30am and timezone is daylight saving time
> 
>
> Key: AIRFLOW-4921
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4921
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: scheduler
>Affects Versions: 1.10.3
>Reporter: dungnguyen
>Priority: Major
>
> Pls correct me if I'm wrong, but I'm still able to reproduce the issue using 
> below code
>  
> {code:java}
> import pendulum
> from airflow import DAG
> from airflow.jobs import SchedulerJob
> from datetime import timedelta, datetime
> tz = pendulum.timezone('America/New_York')
> # Set-up DAG
> test_dag = DAG(
>   dag_id='foo',
>   start_date=datetime(2017, 3, 6, tzinfo=tz),
>   schedule_interval='30 02 * * *',
>   catchup=True
> )
> # manually trigger create_dag_run
> s = SchedulerJob()
> for _ in range(465):
>   dag_run = s.create_dag_run(test_dag)
>   print(dag_run, datetime.now())
> {code}
>  
> The output will be stuck on the date of daylight saving change
>  
> {code:java}
> [2019-07-09 14:46:38,014] {__init__.py:51} INFO - Using executor 
> SequentialExecutor
>  scheduled__2017-03-06T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.268086
>  scheduled__2017-03-07T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.460748
>  scheduled__2017-03-08T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.649766
>  scheduled__2017-03-09T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.838063
>  scheduled__2017-03-10T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.030536
>  scheduled__2017-03-11T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.219713
>  scheduled__2017-03-12T06:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.408905
> {code}
>  
> The suspect I think is a loop in airflow/jobs/scheduler_job.py. This code is 
> stuck when dag.following_schedule(next_run_date) return value with no change
>  
> {code:java}
> # make sure backfills are also considered
> last_run = dag.get_last_dagrun(session=session)
> if last_run and next_run_date:
>   while next_run_date <= last_run.execution_date:
> next_run_date = dag.following_schedule(next_run_date)
> {code}
>  
> Pls let me know if I need to provide more information.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)