[jira] [Commented] (AIRFLOW-5584) Initialise hook in execute not in ctor in Cloud SQL operators

2019-10-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949302#comment-16949302
 ] 

ASF GitHub Bot commented on AIRFLOW-5584:
-

potiuk commented on pull request #6236: [AIRFLOW-5584] Initialise hook in 
execute in Cloud SQL operators
URL: https://github.com/apache/airflow/pull/6236
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Initialise hook in execute not in ctor in Cloud SQL operators
> -
>
> Key: AIRFLOW-5584
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5584
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5584) Initialise hook in execute not in ctor in Cloud SQL operators

2019-10-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949304#comment-16949304
 ] 

ASF subversion and git services commented on AIRFLOW-5584:
--

Commit c7a5f1fc912c8d2a6b143e2356d14107c8c2c4bf in airflow's branch 
refs/heads/master from Tomek
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=c7a5f1f ]

[AIRFLOW-5584] Initialise hook in execute in Cloud SQL operators (#6236)

* [AIRFLOW-5584] Initialise hook in execute in Cloud SQL operators


> Initialise hook in execute not in ctor in Cloud SQL operators
> -
>
> Key: AIRFLOW-5584
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5584
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5584) Initialise hook in execute not in ctor in Cloud SQL operators

2019-10-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949303#comment-16949303
 ] 

ASF subversion and git services commented on AIRFLOW-5584:
--

Commit c7a5f1fc912c8d2a6b143e2356d14107c8c2c4bf in airflow's branch 
refs/heads/master from Tomek
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=c7a5f1f ]

[AIRFLOW-5584] Initialise hook in execute in Cloud SQL operators (#6236)

* [AIRFLOW-5584] Initialise hook in execute in Cloud SQL operators


> Initialise hook in execute not in ctor in Cloud SQL operators
> -
>
> Key: AIRFLOW-5584
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5584
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5584) Initialise hook in execute not in ctor in Cloud SQL operators

2019-10-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942744#comment-16942744
 ] 

ASF GitHub Bot commented on AIRFLOW-5584:
-

nuclearpinguin commented on pull request #6236: [AIRFLOW-5584] Initialise hook 
in execute in Cloud SQL operators
URL: https://github.com/apache/airflow/pull/6236
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-5584
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Initialise hook in execute not in ctor in Cloud SQL operators
> -
>
> Key: AIRFLOW-5584
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5584
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)