[jira] [Commented] (AIRFLOW-5694) Check for blinker when detecting Sentry packages

2019-10-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960040#comment-16960040
 ] 

ASF subversion and git services commented on AIRFLOW-5694:
--

Commit 6e3abbb3a217f73356eb2b762a00c264bdec736b in airflow's branch 
refs/heads/v1-10-test from Marcus Levine
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=6e3abbb ]

[AIRFLOW-5694] Check for blinker in Sentry setup (#6365)


(cherry picked from commit c72c42730236fee1526fcc03dca7f88e1778ee94)


> Check for blinker when detecting Sentry packages
> 
>
> Key: AIRFLOW-5694
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5694
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 1.10.6
>Reporter: Marcus Levine
>Assignee: Marcus Levine
>Priority: Minor
> Fix For: 1.10.7
>
>
> After upgrading to 1.10.6rc1 with `sentry-sdk` installed but not specifying 
> the `[sentry]` extra, the dependency `blinker` will cause failures of the 
> following form:
> {code:python}
> ../lib/python3.7/site-packages/airflow/__init__.py:40: in 
>     from airflow.models import DAG
> ../lib/python3.7/site-packages/airflow/models/__init__.py:21: in 
>     from airflow.models.baseoperator import BaseOperator  # noqa: F401
> ../lib/python3.7/site-packages/airflow/models/baseoperator.py:42: in 
>     from airflow.models.dag import DAG
> ../lib/python3.7/site-packages/airflow/models/dag.py:51: in 
>     from airflow.models.taskinstance import TaskInstance, clear_task_instances
> ../lib/python3.7/site-packages/airflow/models/taskinstance.py:53: in 
>     from airflow.sentry import Sentry
> ../lib/python3.7/site-packages/airflow/sentry.py:167: in 
>     Sentry = ConfiguredSentry()
> ../lib/python3.7/site-packages/airflow/sentry.py:94: in __init__
>     init(integrations=integrations)
> ../lib/python3.7/site-packages/sentry_sdk/hub.py:81: in _init
>     client = Client(*args, **kwargs)  # type: ignore
> ../lib/python3.7/site-packages/sentry_sdk/client.py:80: in __init__
>     self._init_impl()
> ../lib/python3.7/site-packages/sentry_sdk/client.py:108: in _init_impl
>     with_defaults=self.options["default_integrations"],
> ../lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py:82: in 
> setup_integrations
>     type(integration).setup_once()
> ../lib/python3.7/site-packages/sentry_sdk/integrations/flask.py:57: in 
> setup_once
>     appcontext_pushed.connect(_push_appctx)
> ../lib/python3.7/site-packages/flask/signals.py:39: in _fail
>     "Signalling support is unavailable because the blinker"
> E   RuntimeError: Signalling support is unavailable because the blinker 
> library is not installed.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5694) Check for blinker when detecting Sentry packages

2019-10-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957024#comment-16957024
 ] 

ASF subversion and git services commented on AIRFLOW-5694:
--

Commit 770927ae8d12135adac7430a9ab6b39a6f4a1e68 in airflow's branch 
refs/heads/v1-10-test from Marcus Levine
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=770927a ]

[AIRFLOW-5694] Check for blinker in Sentry setup (#6365)


(cherry picked from commit c72c42730236fee1526fcc03dca7f88e1778ee94)


> Check for blinker when detecting Sentry packages
> 
>
> Key: AIRFLOW-5694
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5694
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 1.10.6
>Reporter: Marcus Levine
>Assignee: Marcus Levine
>Priority: Minor
> Fix For: 1.10.7
>
>
> After upgrading to 1.10.6rc1 with `sentry-sdk` installed but not specifying 
> the `[sentry]` extra, the dependency `blinker` will cause failures of the 
> following form:
> {code:python}
> ../lib/python3.7/site-packages/airflow/__init__.py:40: in 
>     from airflow.models import DAG
> ../lib/python3.7/site-packages/airflow/models/__init__.py:21: in 
>     from airflow.models.baseoperator import BaseOperator  # noqa: F401
> ../lib/python3.7/site-packages/airflow/models/baseoperator.py:42: in 
>     from airflow.models.dag import DAG
> ../lib/python3.7/site-packages/airflow/models/dag.py:51: in 
>     from airflow.models.taskinstance import TaskInstance, clear_task_instances
> ../lib/python3.7/site-packages/airflow/models/taskinstance.py:53: in 
>     from airflow.sentry import Sentry
> ../lib/python3.7/site-packages/airflow/sentry.py:167: in 
>     Sentry = ConfiguredSentry()
> ../lib/python3.7/site-packages/airflow/sentry.py:94: in __init__
>     init(integrations=integrations)
> ../lib/python3.7/site-packages/sentry_sdk/hub.py:81: in _init
>     client = Client(*args, **kwargs)  # type: ignore
> ../lib/python3.7/site-packages/sentry_sdk/client.py:80: in __init__
>     self._init_impl()
> ../lib/python3.7/site-packages/sentry_sdk/client.py:108: in _init_impl
>     with_defaults=self.options["default_integrations"],
> ../lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py:82: in 
> setup_integrations
>     type(integration).setup_once()
> ../lib/python3.7/site-packages/sentry_sdk/integrations/flask.py:57: in 
> setup_once
>     appcontext_pushed.connect(_push_appctx)
> ../lib/python3.7/site-packages/flask/signals.py:39: in _fail
>     "Signalling support is unavailable because the blinker"
> E   RuntimeError: Signalling support is unavailable because the blinker 
> library is not installed.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5694) Check for blinker when detecting Sentry packages

2019-10-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956875#comment-16956875
 ] 

ASF subversion and git services commented on AIRFLOW-5694:
--

Commit 80a48d407d53e4faffa5e4077426f1724e1d5757 in airflow's branch 
refs/heads/v1-10-test from Marcus Levine
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=80a48d4 ]

[AIRFLOW-5694] Check for blinker in Sentry setup (#6365)


(cherry picked from commit c72c42730236fee1526fcc03dca7f88e1778ee94)


> Check for blinker when detecting Sentry packages
> 
>
> Key: AIRFLOW-5694
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5694
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 1.10.6
>Reporter: Marcus Levine
>Assignee: Marcus Levine
>Priority: Minor
> Fix For: 1.10.7
>
>
> After upgrading to 1.10.6rc1 with `sentry-sdk` installed but not specifying 
> the `[sentry]` extra, the dependency `blinker` will cause failures of the 
> following form:
> {code:python}
> ../lib/python3.7/site-packages/airflow/__init__.py:40: in 
>     from airflow.models import DAG
> ../lib/python3.7/site-packages/airflow/models/__init__.py:21: in 
>     from airflow.models.baseoperator import BaseOperator  # noqa: F401
> ../lib/python3.7/site-packages/airflow/models/baseoperator.py:42: in 
>     from airflow.models.dag import DAG
> ../lib/python3.7/site-packages/airflow/models/dag.py:51: in 
>     from airflow.models.taskinstance import TaskInstance, clear_task_instances
> ../lib/python3.7/site-packages/airflow/models/taskinstance.py:53: in 
>     from airflow.sentry import Sentry
> ../lib/python3.7/site-packages/airflow/sentry.py:167: in 
>     Sentry = ConfiguredSentry()
> ../lib/python3.7/site-packages/airflow/sentry.py:94: in __init__
>     init(integrations=integrations)
> ../lib/python3.7/site-packages/sentry_sdk/hub.py:81: in _init
>     client = Client(*args, **kwargs)  # type: ignore
> ../lib/python3.7/site-packages/sentry_sdk/client.py:80: in __init__
>     self._init_impl()
> ../lib/python3.7/site-packages/sentry_sdk/client.py:108: in _init_impl
>     with_defaults=self.options["default_integrations"],
> ../lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py:82: in 
> setup_integrations
>     type(integration).setup_once()
> ../lib/python3.7/site-packages/sentry_sdk/integrations/flask.py:57: in 
> setup_once
>     appcontext_pushed.connect(_push_appctx)
> ../lib/python3.7/site-packages/flask/signals.py:39: in _fail
>     "Signalling support is unavailable because the blinker"
> E   RuntimeError: Signalling support is unavailable because the blinker 
> library is not installed.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5694) Check for blinker when detecting Sentry packages

2019-10-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955387#comment-16955387
 ] 

ASF subversion and git services commented on AIRFLOW-5694:
--

Commit 288afb5820436a8770ef73bc133dbd617cbfb94c in airflow's branch 
refs/heads/v1-10-test from Marcus Levine
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=288afb5 ]

[AIRFLOW-5694] Check for blinker in Sentry setup (#6365)


(cherry picked from commit c72c42730236fee1526fcc03dca7f88e1778ee94)


> Check for blinker when detecting Sentry packages
> 
>
> Key: AIRFLOW-5694
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5694
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 1.10.6
>Reporter: Marcus Levine
>Assignee: Marcus Levine
>Priority: Minor
> Fix For: 1.10.6
>
>
> After upgrading to 1.10.6rc1 with `sentry-sdk` installed but not specifying 
> the `[sentry]` extra, the dependency `blinker` will cause failures of the 
> following form:
> {code:python}
> ../lib/python3.7/site-packages/airflow/__init__.py:40: in 
>     from airflow.models import DAG
> ../lib/python3.7/site-packages/airflow/models/__init__.py:21: in 
>     from airflow.models.baseoperator import BaseOperator  # noqa: F401
> ../lib/python3.7/site-packages/airflow/models/baseoperator.py:42: in 
>     from airflow.models.dag import DAG
> ../lib/python3.7/site-packages/airflow/models/dag.py:51: in 
>     from airflow.models.taskinstance import TaskInstance, clear_task_instances
> ../lib/python3.7/site-packages/airflow/models/taskinstance.py:53: in 
>     from airflow.sentry import Sentry
> ../lib/python3.7/site-packages/airflow/sentry.py:167: in 
>     Sentry = ConfiguredSentry()
> ../lib/python3.7/site-packages/airflow/sentry.py:94: in __init__
>     init(integrations=integrations)
> ../lib/python3.7/site-packages/sentry_sdk/hub.py:81: in _init
>     client = Client(*args, **kwargs)  # type: ignore
> ../lib/python3.7/site-packages/sentry_sdk/client.py:80: in __init__
>     self._init_impl()
> ../lib/python3.7/site-packages/sentry_sdk/client.py:108: in _init_impl
>     with_defaults=self.options["default_integrations"],
> ../lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py:82: in 
> setup_integrations
>     type(integration).setup_once()
> ../lib/python3.7/site-packages/sentry_sdk/integrations/flask.py:57: in 
> setup_once
>     appcontext_pushed.connect(_push_appctx)
> ../lib/python3.7/site-packages/flask/signals.py:39: in _fail
>     "Signalling support is unavailable because the blinker"
> E   RuntimeError: Signalling support is unavailable because the blinker 
> library is not installed.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5694) Check for blinker when detecting Sentry packages

2019-10-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955385#comment-16955385
 ] 

ASF subversion and git services commented on AIRFLOW-5694:
--

Commit 708d16ecd1c82c5f26a47712f239d1077eb9fc35 in airflow's branch 
refs/heads/v1-10-test from Marcus Levine
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=708d16e ]

[AIRFLOW-5694] Check for blinker in Sentry setup (#6365)


(cherry picked from commit c72c42730236fee1526fcc03dca7f88e1778ee94)


> Check for blinker when detecting Sentry packages
> 
>
> Key: AIRFLOW-5694
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5694
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 1.10.6
>Reporter: Marcus Levine
>Assignee: Marcus Levine
>Priority: Minor
> Fix For: 1.10.6
>
>
> After upgrading to 1.10.6rc1 with `sentry-sdk` installed but not specifying 
> the `[sentry]` extra, the dependency `blinker` will cause failures of the 
> following form:
> {code:python}
> ../lib/python3.7/site-packages/airflow/__init__.py:40: in 
>     from airflow.models import DAG
> ../lib/python3.7/site-packages/airflow/models/__init__.py:21: in 
>     from airflow.models.baseoperator import BaseOperator  # noqa: F401
> ../lib/python3.7/site-packages/airflow/models/baseoperator.py:42: in 
>     from airflow.models.dag import DAG
> ../lib/python3.7/site-packages/airflow/models/dag.py:51: in 
>     from airflow.models.taskinstance import TaskInstance, clear_task_instances
> ../lib/python3.7/site-packages/airflow/models/taskinstance.py:53: in 
>     from airflow.sentry import Sentry
> ../lib/python3.7/site-packages/airflow/sentry.py:167: in 
>     Sentry = ConfiguredSentry()
> ../lib/python3.7/site-packages/airflow/sentry.py:94: in __init__
>     init(integrations=integrations)
> ../lib/python3.7/site-packages/sentry_sdk/hub.py:81: in _init
>     client = Client(*args, **kwargs)  # type: ignore
> ../lib/python3.7/site-packages/sentry_sdk/client.py:80: in __init__
>     self._init_impl()
> ../lib/python3.7/site-packages/sentry_sdk/client.py:108: in _init_impl
>     with_defaults=self.options["default_integrations"],
> ../lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py:82: in 
> setup_integrations
>     type(integration).setup_once()
> ../lib/python3.7/site-packages/sentry_sdk/integrations/flask.py:57: in 
> setup_once
>     appcontext_pushed.connect(_push_appctx)
> ../lib/python3.7/site-packages/flask/signals.py:39: in _fail
>     "Signalling support is unavailable because the blinker"
> E   RuntimeError: Signalling support is unavailable because the blinker 
> library is not installed.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5694) Check for blinker when detecting Sentry packages

2019-10-19 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955355#comment-16955355
 ] 

ASF GitHub Bot commented on AIRFLOW-5694:
-

potiuk commented on pull request #6365: [AIRFLOW-5694] Check for blinker in 
Sentry setup
URL: https://github.com/apache/airflow/pull/6365
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check for blinker when detecting Sentry packages
> 
>
> Key: AIRFLOW-5694
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5694
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 1.10.6
>Reporter: Marcus Levine
>Assignee: Marcus Levine
>Priority: Minor
> Fix For: 1.10.6
>
>
> After upgrading to 1.10.6rc1 with `sentry-sdk` installed but not specifying 
> the `[sentry]` extra, the dependency `blinker` will cause failures of the 
> following form:
> {code:python}
> ../lib/python3.7/site-packages/airflow/__init__.py:40: in 
>     from airflow.models import DAG
> ../lib/python3.7/site-packages/airflow/models/__init__.py:21: in 
>     from airflow.models.baseoperator import BaseOperator  # noqa: F401
> ../lib/python3.7/site-packages/airflow/models/baseoperator.py:42: in 
>     from airflow.models.dag import DAG
> ../lib/python3.7/site-packages/airflow/models/dag.py:51: in 
>     from airflow.models.taskinstance import TaskInstance, clear_task_instances
> ../lib/python3.7/site-packages/airflow/models/taskinstance.py:53: in 
>     from airflow.sentry import Sentry
> ../lib/python3.7/site-packages/airflow/sentry.py:167: in 
>     Sentry = ConfiguredSentry()
> ../lib/python3.7/site-packages/airflow/sentry.py:94: in __init__
>     init(integrations=integrations)
> ../lib/python3.7/site-packages/sentry_sdk/hub.py:81: in _init
>     client = Client(*args, **kwargs)  # type: ignore
> ../lib/python3.7/site-packages/sentry_sdk/client.py:80: in __init__
>     self._init_impl()
> ../lib/python3.7/site-packages/sentry_sdk/client.py:108: in _init_impl
>     with_defaults=self.options["default_integrations"],
> ../lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py:82: in 
> setup_integrations
>     type(integration).setup_once()
> ../lib/python3.7/site-packages/sentry_sdk/integrations/flask.py:57: in 
> setup_once
>     appcontext_pushed.connect(_push_appctx)
> ../lib/python3.7/site-packages/flask/signals.py:39: in _fail
>     "Signalling support is unavailable because the blinker"
> E   RuntimeError: Signalling support is unavailable because the blinker 
> library is not installed.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5694) Check for blinker when detecting Sentry packages

2019-10-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955356#comment-16955356
 ] 

ASF subversion and git services commented on AIRFLOW-5694:
--

Commit c72c42730236fee1526fcc03dca7f88e1778ee94 in airflow's branch 
refs/heads/master from Marcus Levine
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=c72c427 ]

[AIRFLOW-5694] Check for blinker in Sentry setup (#6365)



> Check for blinker when detecting Sentry packages
> 
>
> Key: AIRFLOW-5694
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5694
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 1.10.6
>Reporter: Marcus Levine
>Assignee: Marcus Levine
>Priority: Minor
> Fix For: 1.10.6
>
>
> After upgrading to 1.10.6rc1 with `sentry-sdk` installed but not specifying 
> the `[sentry]` extra, the dependency `blinker` will cause failures of the 
> following form:
> {code:python}
> ../lib/python3.7/site-packages/airflow/__init__.py:40: in 
>     from airflow.models import DAG
> ../lib/python3.7/site-packages/airflow/models/__init__.py:21: in 
>     from airflow.models.baseoperator import BaseOperator  # noqa: F401
> ../lib/python3.7/site-packages/airflow/models/baseoperator.py:42: in 
>     from airflow.models.dag import DAG
> ../lib/python3.7/site-packages/airflow/models/dag.py:51: in 
>     from airflow.models.taskinstance import TaskInstance, clear_task_instances
> ../lib/python3.7/site-packages/airflow/models/taskinstance.py:53: in 
>     from airflow.sentry import Sentry
> ../lib/python3.7/site-packages/airflow/sentry.py:167: in 
>     Sentry = ConfiguredSentry()
> ../lib/python3.7/site-packages/airflow/sentry.py:94: in __init__
>     init(integrations=integrations)
> ../lib/python3.7/site-packages/sentry_sdk/hub.py:81: in _init
>     client = Client(*args, **kwargs)  # type: ignore
> ../lib/python3.7/site-packages/sentry_sdk/client.py:80: in __init__
>     self._init_impl()
> ../lib/python3.7/site-packages/sentry_sdk/client.py:108: in _init_impl
>     with_defaults=self.options["default_integrations"],
> ../lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py:82: in 
> setup_integrations
>     type(integration).setup_once()
> ../lib/python3.7/site-packages/sentry_sdk/integrations/flask.py:57: in 
> setup_once
>     appcontext_pushed.connect(_push_appctx)
> ../lib/python3.7/site-packages/flask/signals.py:39: in _fail
>     "Signalling support is unavailable because the blinker"
> E   RuntimeError: Signalling support is unavailable because the blinker 
> library is not installed.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5694) Check for blinker when detecting Sentry packages

2019-10-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954855#comment-16954855
 ] 

ASF GitHub Bot commented on AIRFLOW-5694:
-

marcusianlevine commented on pull request #6365: [AIRFLOW-5694] Check for 
blinker in Sentry setup
URL: https://github.com/apache/airflow/pull/6365
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-5694#
 - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
 - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
 - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   In order to avoid setting up Sentry when `sentry-sdk` is installed but not 
`blinker`, we import an unused module from `blinker` so that the `ImportError` 
catch will trigger and use the `DummySentry` instead
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Prevents a known edge case
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Check for blinker when detecting Sentry packages
> 
>
> Key: AIRFLOW-5694
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5694
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 1.10.6
>Reporter: Marcus Levine
>Assignee: Marcus Levine
>Priority: Minor
> Fix For: 1.10.6
>
>
> After upgrading to 1.10.6rc1 with `sentry-sdk` installed but not specifying 
> the `[sentry]` extra, the dependency `blinker` will cause failures of the 
> following form:
> {code:python}
> ../lib/python3.7/site-packages/airflow/__init__.py:40: in 
>     from airflow.models import DAG
> ../lib/python3.7/site-packages/airflow/models/__init__.py:21: in 
>     from airflow.models.baseoperator import BaseOperator  # noqa: F401
> ../lib/python3.7/site-packages/airflow/models/baseoperator.py:42: in 
>     from airflow.models.dag import DAG
> ../lib/python3.7/site-packages/airflow/models/dag.py:51: in 
>     from airflow.models.taskinstance import TaskInstance, clear_task_instances
> ../lib/python3.7/site-packages/airflow/models/taskinstance.py:53: in 
>     from airflow.sentry import Sentry
> ../lib/python3.7/site-packages/airflow/sentry.py:167: in 
>     Sentry = ConfiguredSentry()
> ../lib/python3.7/site-packages/airflow/sentry.py:94: in __init__
>     init(integrations=integrations)
> ../lib/python3.7/site-packages/sentry_sdk/hub.py:81: in _init
>     client = Client(*args, **kwargs)  # type: ignore
> ../lib/python3.7/site-packages/sentry_sdk/client.py:80: in __init__
>     self._init_impl()
> ../lib/python3.7/site-packages/sentry_sdk/client.py:108: in _init_impl
>     with_defaults=self.options["default_integrations"],
> ../lib/python3.7/site-packages/sentry_sdk/integrations/__init__.py:82: in 
> setup_integrations
>