[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113943#comment-17113943 ] ASF GitHub Bot commented on AIRFLOW-6711: - ashb commented on pull request #7335: URL: https://github.com/apache/airflow/pull/7335#issuecomment-632631751 Ohhh, yeah, you may be right. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop plugin support for stat_name_handler > - > > Key: AIRFLOW-6711 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6711 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.7 >Reporter: Kamil Bregula >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113938#comment-17113938 ] ASF GitHub Bot commented on AIRFLOW-6711: - kaxil commented on pull request #7335: URL: https://github.com/apache/airflow/pull/7335#issuecomment-632628871 > I've put this in for 1.10.12, but we should do that in a backwards compatible way (i.e. use the plugin method, but warn) I think the stat_name_handler thing never made it to any of the previous releases :) so should be good to go This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop plugin support for stat_name_handler > - > > Key: AIRFLOW-6711 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6711 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.7 >Reporter: Kamil Bregula >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113935#comment-17113935 ] ASF GitHub Bot commented on AIRFLOW-6711: - ashb commented on pull request #7335: URL: https://github.com/apache/airflow/pull/7335#issuecomment-632627339 I've put this in for 1.10.12, but we should do that in a backwards compatible way (i.e. use the plugin method, but warn) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop plugin support for stat_name_handler > - > > Key: AIRFLOW-6711 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6711 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.7 >Reporter: Kamil Bregula >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067196#comment-17067196 ] ASF subversion and git services commented on AIRFLOW-6711: -- Commit 7a7128fcc41411ea2907e9976087b55c4edd44c6 in airflow's branch refs/heads/v1-10-test from Kamil Breguła [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=7a7128f ] [AIRFLOW-6711] Drop plugin support for stat_name_handler (#7335) (cherry picked from commit 486054bc48568775983e8bcf5914f10512a860ee) > Drop plugin support for stat_name_handler > - > > Key: AIRFLOW-6711 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6711 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.7 >Reporter: Kamil Bregula >Priority: Major > Fix For: 1.10.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067112#comment-17067112 ] ASF subversion and git services commented on AIRFLOW-6711: -- Commit 1e447c533e603973a18fac9ae7f26361f0d3c55a in airflow's branch refs/heads/v1-10-test from Kamil Breguła [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=1e447c5 ] [AIRFLOW-6711] Drop plugin support for stat_name_handler (#7335) (cherry picked from commit 486054bc48568775983e8bcf5914f10512a860ee) > Drop plugin support for stat_name_handler > - > > Key: AIRFLOW-6711 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6711 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.7 >Reporter: Kamil Bregula >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028765#comment-17028765 ] ASF GitHub Bot commented on AIRFLOW-6711: - mik-laj commented on pull request #7335: [AIRFLOW-6711] Drop plugin support for stat_name_handler URL: https://github.com/apache/airflow/pull/7335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop plugin support for stat_name_handler > - > > Key: AIRFLOW-6711 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6711 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.7 >Reporter: Kamil Bregula >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028766#comment-17028766 ] ASF subversion and git services commented on AIRFLOW-6711: -- Commit 486054bc48568775983e8bcf5914f10512a860ee in airflow's branch refs/heads/master from Kamil Breguła [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=486054b ] [AIRFLOW-6711] Drop plugin support for stat_name_handler (#7335) > Drop plugin support for stat_name_handler > - > > Key: AIRFLOW-6711 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6711 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.7 >Reporter: Kamil Bregula >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028430#comment-17028430 ] ASF GitHub Bot commented on AIRFLOW-6711: - mik-laj commented on pull request #7335: [AIRFLOW-6711] Drop plugin support for stat_name_handler URL: https://github.com/apache/airflow/pull/7335 This change is intended to simplify the statsd configuration and unify the configuration. Other components use import path to configure aplication e.g.. `pod_mutation_hook` or `auth_backend`. Configuration through plugins is very strange and may not be readable enough. The configuration file for the configuration is a proven, stable and widely used solution. Plugins are an interesting idea, but they are not common. --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = JIRA ID* - [ ] Unit tests coverage for changes (not needed for documentation changes) - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)" - [ ] Relevant documentation is updated including usage instructions. - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example). * For document-only changes commit message can start with `[AIRFLOW-]`. --- In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop plugin support for stat_name_handler > - > > Key: AIRFLOW-6711 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6711 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.7 >Reporter: Kamil Bregula >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
