Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
suii2210 commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3690419245 hello @henry3260 I reviewed your PR and this looks good to me. `test_init_allow_no_default_param` clearly captures the reported regression and ensures` HITLOperator` can be initialized with params lacking defaults, which matches expected HITL behavior. The test scope is appropriate (init-time only), and removing the previous `ParamValidationError` case here makes sense since validation is intentionally deferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
henry3260 commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3686114647 > > > Hi [@potiuk](https://github.com/potiuk) 👋 Since a fix has already been proposed in [#59653](https://github.com/apache/airflow/pull/59653), could you please confirm whether you’d like me to continue working on this issue (e.g. alternative approach / tests / follow-up), or should I hold off for now? > > > Just want to align and avoid duplicating work. Thanks! > > > > [@suii2210](https://github.com/suii2210), we should align our approaches. Could you please take a look at my PR and let me know if you have any suggestions or parts of your code you'd like to include? I'm happy to apply your changes here. We can then use the Co-authored-by tag to ensure we both get credit. WDYT? > > sure I'll review your PR. Let's fix this together! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
suii2210 commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3686108234 > > Hi [@potiuk](https://github.com/potiuk) 👋 Since a fix has already been proposed in [#59653](https://github.com/apache/airflow/pull/59653), could you please confirm whether you’d like me to continue working on this issue (e.g. alternative approach / tests / follow-up), or should I hold off for now? > > Just want to align and avoid duplicating work. Thanks! > > [@suii2210](https://github.com/suii2210), we should align our approaches. Could you please take a look at my PR and let me know if you have any suggestions or parts of your code you'd like to include? I'm happy to apply your changes here. We can then use the Co-authored-by tag to ensure we both get credit. WDYT? sure I'll review your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
henry3260 commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3684756366 > Hi [@potiuk](https://github.com/potiuk) 👋 Since a fix has already been proposed in [#59653](https://github.com/apache/airflow/pull/59653), could you please confirm whether you’d like me to continue working on this issue (e.g. alternative approach / tests / follow-up), or should I hold off for now? > > Just want to align and avoid duplicating work. Thanks! @suii2210, we should align our approaches. Could you please take a look at my PR and let me know if you have any suggestions or parts of your code you'd like to include? I'm happy to apply your changes here. We can then use the Co-authored-by tag to ensure we both get credit. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
potiuk commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3684208508 Well. You have to agree between yourselves, ideally one of you should review the work of the other and agree which approach is better and makae some suggestion maybe - this will then be merged with co-authorship - but it's between the two of you to agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
suii2210 commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3680728926 Hi @potiuk 👋 Since a fix has already been proposed in #59653, could you please confirm whether you’d like me to continue working on this issue (e.g. alternative approach / tests / follow-up), or should I hold off for now? Just want to align and avoid duplicating work. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
henry3260 commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3676275793 > Hi, I’d like to work on this issue if it’s still available. I’ll investigate the regression between earlier versions and 3.1.x and propose a fix along with tests covering both DAG parse-time and HITL runtime validation. > > Please let me know if this approach sounds good. Hi, sorry about that! I happened to be working on this and just pushed the fix. The PR is here: #59653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
potiuk commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3676140790 feel free -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
suii2210 commented on issue #59551: URL: https://github.com/apache/airflow/issues/59551#issuecomment-3674703735 Hi, I’d like to work on this issue if it’s still available. I’ll investigate the regression between earlier versions and 3.1.x and propose a fix along with tests covering both DAG parse-time and HITL runtime validation. Please let me know if this approach sounds good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Regression: DAG import fails with HITLOperator when params have no explicit default (ParamValidationError) [airflow]
jgoedeke commented on issue #59551:
URL: https://github.com/apache/airflow/issues/59551#issuecomment-3665357640
To make the DAG parse we set `default=None` in the Param:
'start_time': Param(
default=None,
title='Start time of the test',
type=['string', 'null'],
format='date-time',
),
But then when using the HITL action the following error occurs:
[2025-12-17 13:10:55] ERROR - Task failed with exception
HITLTriggerEventError: {'error': "Invalid input for param start_time:
{'value': None, 'schema': {'title': 'Start time of the test', 'type':
['string', 'null'], 'format': 'date-time'}} is not of type 'string',
'null'\n\nFailed validating 'type' in schema:\n{'title': 'Start time of the
test',\n 'type': ['string', 'null'],\n 'format': 'date-time'}\n\nOn
instance:\n{'value': None,\n 'schema': {'title': 'Start time of the
test',\n'type': ['string', 'null'],\n'format':
'date-time'}}", 'error_type': 'validation'}
File
"/home/airflow/.local/lib/python3.11/site-packages/airflow/sdk/execution_time/task_runner.py",
line 934 in run
File
"/home/airflow/.local/lib/python3.11/site-packages/airflow/sdk/execution_time/task_runner.py",
line 1325 in _execute_task
File
"/home/airflow/.local/lib/python3.11/site-packages/airflow/sdk/bases/operator.py",
line 1633 in resume_execution
File
"/home/airflow/.local/lib/python3.11/site-packages/airflow/providers/standard/operators/hitl.py",
line 184 in execute_complete
File
"/home/airflow/.local/lib/python3.11/site-packages/airflow/providers/standard/operators/hitl.py",
line 201 in process_trigger_event_error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
