Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-17 Thread via GitHub


potiuk commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2888358024

   I think that UI only shows first 100 contributors - nothing we can do about 
it - but you can refer to your PR 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-17 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2888305934

   Hi @potiuk ,
   
   I hope you're doing well. I recently contributed to the Apache Airflow 
repository by updating the README and adding an installing.MD file with setup 
instructions for macOS/Linux]. The PR has been merged successfully — thank you 
again for the opportunity!
   
   I noticed, however, that my name hasn’t appeared in the Contributors section 
of the repository. I just wanted to check if there’s anything I might have 
missed — such as an issue with commit attribution or any additional step I need 
to take from my side.
   
   Appreciate your time and support!
   
   Best regards,
   Praneeth
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-16 Thread via GitHub


potiuk commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2887714483

   Thanks for the heart-warming words :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-11 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2870021649

   Hi @potiuk, just checking in to see if you had a chance to review this PR. 
I’ve made the requested changes and moved the macOS-specific installation 
instructions to a dedicated INSTALLING.md, while keeping the README clean and 
intact.
   Please let me know if there’s anything else I should improve. Thanks again 
for your time!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-07 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2858189238

   I have reverted the action of merging the entire installation steps into a 
single file. Instead, I have created a separate file, INSTALLING.md, 
specifically for the macOS setup instructions and linked it in the README.md.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-07 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2858125101

   Thank you for the clarification. To ensure I proceed correctly, could you 
please guide me on what exactly I should do in this case? I’d like to include 
Mac installation steps for contributors on GitHub, but I understand they 
shouldn’t be in the generated PYPI_README.md. Should I keep them only in a 
separate INSTALLING.md and avoid linking to it in the main README.md, or is 
there a preferred approach you’d suggest?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-07 Thread via GitHub


potiuk commented on code in PR #50179:
URL: https://github.com/apache/airflow/pull/50179#discussion_r207737


##
README.md:
##
@@ -139,54 +139,10 @@ Documentation for dependent projects like provider 
distributions, Docker image,
 
 
 
-## Installing from PyPI
 
-We publish Apache Airflow as `apache-airflow` package in PyPI. Installing it 
however might be sometimes tricky
-because Airflow is a bit of both a library and application. Libraries usually 
keep their dependencies open, and
-applications usually pin them, but we should do neither and both 
simultaneously. We decided to keep
-our dependencies as open as possible (in `pyproject.toml`) so users can 
install different versions of libraries
-if needed. This means that `pip install apache-airflow` will not work from 
time to time or will
-produce unusable Airflow installation.
+## Installation Guide

Review Comment:
   i  also think there is one more thing needed here. As you can see (see the 
comments above) part of the  README  is copied over to `generated/PYPI 
_README.md` - which is then used to generate Python packages. This is done by a 
pre-commit (you will see it failing in static checks). And the problem is - if 
we change it to link here, that generated PYPI readme is not going to have 
INSTALLING.md to link to - so the README generated in `generated` should have 
no links whatsoever  other than `https://` links maybe directly to some 
external docs.
   
   But really what happens here, is that this whole "installation" section is 
not needed at all in `PyPI` readme, because the basic installation is described 
at the top with `pip install` command and there is also link to docuemntation 
as part of PyPI links. So I think the pre-commit should be updated to not copy 
the whole installation chapter to the `PYPI_README.md`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2852807858

   I'm new to the contributions section. Could you please guide me on the next 
steps after this current status?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2851204194

   No, everything is well placed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2851109211

   Thanks a lot for the review and approval! I'm happy to wait and hear from 
any other committers or PMC members if they’d like to take a look as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


potiuk commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2850970429

   Nice. I think that looks really good now :). 
   
   Since this is the main README - anyone else from the committers/PMC members 
would like to review it ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2850578783

   I've updated the README.md to include a concise installation section
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-285055

I've moved the detailed installation instructions to a new INSTALLING.md 
file as suggested, and updated the README.md to include a link to it. This 
keeps the main README concise while still providing easy access to setup 
details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


potiuk commented on code in PR #50179:
URL: https://github.com/apache/airflow/pull/50179#discussion_r2073193911


##
INSTALLING.md:
##
@@ -0,0 +1,78 @@
+> ⚠️ Avoid using either system-installed Python or Python from Homebrew, as 
these versions are often labeled `--externally-managed` resulting in restricted 
dependency installation.

Review Comment:
   I think also previous chapter from README can be moved here. It should not 
be Apple-Silicon only document



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


potiuk commented on code in PR #50179:
URL: https://github.com/apache/airflow/pull/50179#discussion_r2073172177


##
README.md:
##
@@ -188,6 +188,87 @@ pip install 'apache-airflow[postgres,google]==3.0.0' \
 For information on installing provider distributions, check
 
[providers](http://airflow.apache.org/docs/apache-airflow-providers/index.html).
 
+## Setting up Apache Airflow on Apple Silicon (Mac M1/M2/M3/M4)

Review Comment:
   Hmm. Actually when looking at the whole, rendered README  I think that 
should be a separate doc with link from README.md. 
   
   Our README.md is **precious** and it should be **short** -> we already had a 
very, very long README in the past and shortened it and I think it's a good 
idea to make it **shorter** rather than **longer**. I think togetjher- this and 
previous chapter are long enough to be extracted to a separate `INSTALLING.md` 
and linking to that INSTALLING.md from README



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


potiuk commented on code in PR #50179:
URL: https://github.com/apache/airflow/pull/50179#discussion_r2073172177


##
README.md:
##
@@ -188,6 +188,87 @@ pip install 'apache-airflow[postgres,google]==3.0.0' \
 For information on installing provider distributions, check
 
[providers](http://airflow.apache.org/docs/apache-airflow-providers/index.html).
 
+## Setting up Apache Airflow on Apple Silicon (Mac M1/M2/M3/M4)

Review Comment:
   Hmm. Actually when looking at the whole, rendered README  I think that 
should be a separate doc with link from README.md. 
   
   Our README.md is **precious** and it should be **short** -> we already had a 
very, very long README and I think it's a good idea to make it **shorter** 
rather than **longer**. I think togetjher- this and previous chapter are long 
enough to be extracted to a separate `INSTALLING.md` and linking to that 
INSTALLING.md from README



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2850410960

   Refined and cleaned up the setup guide. Verified the steps locally on Mac M2 
— everything works as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


praneeth552 commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2850272000

   ok already working on it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


potiuk commented on PR #50179:
URL: https://github.com/apache/airflow/pull/50179#issuecomment-2850259783

   It needs a bit of cleanup now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


praneeth552 commented on code in PR #50179:
URL: https://github.com/apache/airflow/pull/50179#discussion_r2073017697


##
README.md:
##
@@ -188,6 +188,75 @@ pip install 'apache-airflow[postgres,google]==3.0.0' \
 For information on installing provider distributions, check
 
[providers](http://airflow.apache.org/docs/apache-airflow-providers/index.html).
 
+## Setting up Apache Airflow on Apple Silicon (Mac M1/M2/M3/M4)
+
+> ⚠️ Avoid using either system-installed Python or Python from Homebrew, as 
these versions are often labeled `--externally-managed` resulting in restricted 
dependency installation.
+
+### ✅ Recommended Setup (using pyenv):
+
+1. **Install pyenv**:
+
+```bash
+brew install pyenv
+```
+
+2. **Install Python**:
+
+```bash
+pyenv install 3.11.9
+pyenv global 3.11.9
+```
+
+3. **Check Python version**:
+
+```bash
+python --version
+```
+
+4. **Create and Activate a Virtual Environment**: Since Apache Airflow 
requires multiple dependencies, it's a good practice to isolate these 
dependencies in a virtual environment.
+
+- Create a virtual environment:
+
+```bash
+python -m venv airflow_venv
+```
+
+- Activate the virtual environment:
+
+```bash
+source airflow_venv/bin/activate
+```
+
+5. **Install Apache Airflow**: Apache Airflow is available on PyPI. To install 
it, you can use the following command in your terminal:
+
+```bash
+pip install apache-airflow

Review Comment:
   Ok thank you, surely i will update the changes specified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


potiuk commented on code in PR #50179:
URL: https://github.com/apache/airflow/pull/50179#discussion_r2073011754


##
README.md:
##
@@ -188,6 +188,75 @@ pip install 'apache-airflow[postgres,google]==3.0.0' \
 For information on installing provider distributions, check
 
[providers](http://airflow.apache.org/docs/apache-airflow-providers/index.html).
 
+## Setting up Apache Airflow on Apple Silicon (Mac M1/M2/M3/M4)
+
+> ⚠️ Avoid using either system-installed Python or Python from Homebrew, as 
these versions are often labeled `--externally-managed` resulting in restricted 
dependency installation.
+
+### ✅ Recommended Setup (using pyenv):
+
+1. **Install pyenv**:
+
+```bash
+brew install pyenv
+```
+
+2. **Install Python**:
+
+```bash
+pyenv install 3.11.9
+pyenv global 3.11.9
+```
+
+3. **Check Python version**:
+
+```bash
+python --version
+```
+
+4. **Create and Activate a Virtual Environment**: Since Apache Airflow 
requires multiple dependencies, it's a good practice to isolate these 
dependencies in a virtual environment.
+
+- Create a virtual environment:
+
+```bash
+python -m venv airflow_venv
+```
+
+- Activate the virtual environment:
+
+```bash
+source airflow_venv/bin/activate
+```
+
+5. **Install Apache Airflow**: Apache Airflow is available on PyPI. To install 
it, you can use the following command in your terminal:
+
+```bash
+pip install apache-airflow

Review Comment:
   ```suggestion
   pip install apache-airflow==3.0.0 --constraint 
"https://raw.githubusercontent.com/apache/airflow/constraints-3.0.0/constraints-3.11.txt";
   
   Note that installing with constraints - at least initially - is recommended 
for reproducible installation. It might sometimes happen that 3rd-party 
distributions are relased and their latest versions break airflow. Using 
constraints makes the installation reproducible with versions of dependencies 
that were "frozen" at the time of releasing airflow. Note you have to specify 
both - airflow version and Python version you are using.
   
   You can also specify additional extras - when you want to install airflow 
with addtional providers:
   
   ```bash
   pip install apache-airflow[amazon,google]==3.0.0 --constraint 
"https://raw.githubusercontent.com/apache/airflow/constraints-3.0.0/constraints-3.11.txt";
   ```
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


potiuk commented on code in PR #50179:
URL: https://github.com/apache/airflow/pull/50179#discussion_r2073011754


##
README.md:
##
@@ -188,6 +188,75 @@ pip install 'apache-airflow[postgres,google]==3.0.0' \
 For information on installing provider distributions, check
 
[providers](http://airflow.apache.org/docs/apache-airflow-providers/index.html).
 
+## Setting up Apache Airflow on Apple Silicon (Mac M1/M2/M3/M4)
+
+> ⚠️ Avoid using either system-installed Python or Python from Homebrew, as 
these versions are often labeled `--externally-managed` resulting in restricted 
dependency installation.
+
+### ✅ Recommended Setup (using pyenv):
+
+1. **Install pyenv**:
+
+```bash
+brew install pyenv
+```
+
+2. **Install Python**:
+
+```bash
+pyenv install 3.11.9
+pyenv global 3.11.9
+```
+
+3. **Check Python version**:
+
+```bash
+python --version
+```
+
+4. **Create and Activate a Virtual Environment**: Since Apache Airflow 
requires multiple dependencies, it's a good practice to isolate these 
dependencies in a virtual environment.
+
+- Create a virtual environment:
+
+```bash
+python -m venv airflow_venv
+```
+
+- Activate the virtual environment:
+
+```bash
+source airflow_venv/bin/activate
+```
+
+5. **Install Apache Airflow**: Apache Airflow is available on PyPI. To install 
it, you can use the following command in your terminal:
+
+```bash
+pip install apache-airflow

Review Comment:
   ```suggestion
   pip install apache-airflow==3.0.0 --constraint 
"https://raw.githubusercontent.com/apache/airflow/constraints-3.0.0/constraints-3.11.txt";
   ```
   
   Note that installing with constraints - at least initially - is recommended 
for reproducible installation. It might sometimes happen that 3rd-party 
distributions are relased and their latest versions break airflow. Using 
constraints makes the installation reproducible with versions of dependencies 
that were "frozen" at the time of releasing airflow. Note you have to specify 
both - airflow version and Python version you are using.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add Apache Airflow setup instructions for Apple Silicon [airflow]

2025-05-05 Thread via GitHub


potiuk commented on code in PR #50179:
URL: https://github.com/apache/airflow/pull/50179#discussion_r2073008639


##
README.md:
##
@@ -188,6 +188,75 @@ pip install 'apache-airflow[postgres,google]==3.0.0' \
 For information on installing provider distributions, check
 
[providers](http://airflow.apache.org/docs/apache-airflow-providers/index.html).
 
+## Setting up Apache Airflow on Apple Silicon (Mac M1/M2/M3/M4)
+
+> ⚠️ Avoid using either system-installed Python or Python from Homebrew, as 
these versions are often labeled `--externally-managed` resulting in restricted 
dependency installation.
+
+### ✅ Recommended Setup (using pyenv):

Review Comment:
   ```suggestion
   You can use other ways to install Python and airflow. Airflow development 
setup requires ``uv`` and if you want to setup environment for development, 
`uv` is the only supported local development environment setup, because we are 
using `uv workspace` extensively. See [local virtualenv setup in contributing 
docs](https://github.com/apache/airflow/blob/main/contributing-docs/07_local_virtualenv.rst)
 for details.
   
   If you are just installing airflow to run it locally, You can use other ways 
to setup your Python and virtualenv: `uv` is one of the options (refer to `uv` 
documentation, but you can also use more traditional tools - for example 
`pyenv`. Note that it is recommmended to install airflow with constraints - at 
least initially - because this way you can reproducibly install airflow. See 
[Installation from 
PyPI[(https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html)
 for more details.
   
   Herr 
   
   ### ✅ Setup using pyenv:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]