Re: [PR] Add Sail provider for Spark Connect compatible engine [airflow]
potiuk commented on PR #61752: URL: https://github.com/apache/airflow/pull/61752#issuecomment-4179218316 This draft pull request has had no activity from the author for over 3 weeks. **@davidlghellin**, you are welcome to reopen this PR when you are ready to continue working on it. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Sail provider for Spark Connect compatible engine [airflow]
potiuk closed pull request #61752: Add Sail provider for Spark Connect compatible engine URL: https://github.com/apache/airflow/pull/61752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Sail provider for Spark Connect compatible engine [airflow]
davidlghellin commented on PR #61752: URL: https://github.com/apache/airflow/pull/61752#issuecomment-4036771240 > @davidlghellin This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). Sorry about that — I thought the PR was already in draft. I'll rebase against main and work through the CI failures when I get a chance. Thanks for the detailed feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Sail provider for Spark Connect compatible engine [airflow]
potiuk commented on PR #61752: URL: https://github.com/apache/airflow/pull/61752#issuecomment-4035046310 @davidlghellin This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Pre-commit / static checks**: Failing: CI image checks / Static checks. Run `prek run --from-ref main` locally to find and fix issues. See [Pre-commit / static checks docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst). - :x: **Provider tests**: Failing: provider distributions tests / Providers wheel tests, provider distributions tests / Providers sdist tests. Run provider tests with `breeze run pytest -xvs`. See [Provider tests docs](https://github.com/apache/airflow/blob/main/contributing-docs/12_provider_distributions.rst). - :x: **Other failing CI checks**: Failing: Airflow CTL tests / airflow-ctl:P3.10 tests, Additional CI image checks / Check that image builds quickly, Generate constraints / Generate constraints for 3.10 on linux/amd64, Generate constraints / Generate constraints for 3.11 on linux/amd64, Generate constraints / Generate constraints for 3.12 on linux/amd64 (+3 more). Run `prek run --from-ref main` locally to reproduce. See [static checks docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst). > **Note:** Your branch is **479 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results. **What to do next:** - The comment informs you what you need to do. - Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed. - Maintainers will then proceed with a normal review. Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Sail provider for Spark Connect compatible engine [airflow]
potiuk commented on PR #61752: URL: https://github.com/apache/airflow/pull/61752#issuecomment-3993631916 You need to follow the process described in https://github.com/apache/airflow/blob/main/PROVIDERS.rst#provider-governance-framework in order to add new provider Read it and follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Sail provider for Spark Connect compatible engine [airflow]
boring-cyborg[bot] commented on PR #61752: URL: https://github.com/apache/airflow/pull/61752#issuecomment-3880991100 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
