Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
github-actions[bot] commented on PR #62797: URL: https://github.com/apache/airflow/pull/62797#issuecomment-4084226328 ### Backport failed to create: v3-1-test. View the failure log Run details Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x) the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches. In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel. Status Branch Result ❌ v3-1-test https://github.com/apache/airflow/commit/7c648ab63a45acbbe64bdb8d5ff69c79617eb636";> You can attempt to backport this manually by running: ```bash cherry_picker 7c648ab v3-1-test ``` This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
pierrejeambrun merged PR #62797: URL: https://github.com/apache/airflow/pull/62797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
pierrejeambrun commented on code in PR #62797:
URL: https://github.com/apache/airflow/pull/62797#discussion_r2954993180
##
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##
@@ -201,6 +213,30 @@ export const PanelButtons = ({
setTriggeringUserFilter(trimmedValue === "" ? undefined : trimmedValue);
};
+ const runAfterRange: DateRangeValue = {
+endDate: runAfterLte,
+startDate: runAfterGte,
+ };
+
+ const handleRunAfterRangeChange = (next: DateRangeValue) => {
+setRunAfterGte(next.startDate);
+setRunAfterLte(next.endDate);
+ };
Review Comment:
Looking better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
Prajwal7842 commented on code in PR #62797:
URL: https://github.com/apache/airflow/pull/62797#discussion_r2936491586
##
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##
@@ -201,6 +213,30 @@ export const PanelButtons = ({
setTriggeringUserFilter(trimmedValue === "" ? undefined : trimmedValue);
};
+ const runAfterRange: DateRangeValue = {
+endDate: runAfterLte,
+startDate: runAfterGte,
+ };
+
+ const handleRunAfterRangeChange = (next: DateRangeValue) => {
+setRunAfterGte(next.startDate);
+setRunAfterLte(next.endDate);
+ };
Review Comment:
Hey @pierrejeambrun thanks for the review. Can you tell me a little bit more
on the expected behavior. I tried playing around with the filter. When I clear
the filter dates selected, it refreshes it to the latest runs.
Can you share some test case I can follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
Prajwal7842 commented on PR #62797: URL: https://github.com/apache/airflow/pull/62797#issuecomment-4062626803 > Thanks. > > here is a Display problem on the dropdown when vertical space of the screen is limited. > > https://private-user-images.githubusercontent.com/14861206/563090094-c9ad4e72-f4e0-4bfc-8971-87c30be00058.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzM1NjYyOTksIm5iZiI6MTc3MzU2NTk5OSwicGF0aCI6Ii8xNDg2MTIwNi81NjMwOTAwOTQtYzlhZDRlNzItZjRlMC00YmZjLTg5NzEtODdjMzBiZTAwMDU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAzMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMzE1VDA5MTMxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTExNjI3YjMwNjgyZTI3OTE0OWU2ODIwNGVhZDUwZTZlMDg2ZjMwODJmMWFjYjNhZmQ3MGNjZGIxNzAyY2IwOWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Z_7WRRVHjsyeVSpT_3lqPh82-sfRYn2VZdiJnUlNugQ";> Thanks for catching the display issue related to vertical limit. I have added a limit of 70%, making the filter scrollable now. PTAL. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
pierrejeambrun commented on code in PR #62797:
URL: https://github.com/apache/airflow/pull/62797#discussion_r2931903407
##
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##
@@ -201,6 +213,30 @@ export const PanelButtons = ({
setTriggeringUserFilter(trimmedValue === "" ? undefined : trimmedValue);
};
+ const runAfterRange: DateRangeValue = {
+endDate: runAfterLte,
+startDate: runAfterGte,
+ };
+
+ const handleRunAfterRangeChange = (next: DateRangeValue) => {
+setRunAfterGte(next.startDate);
+setRunAfterLte(next.endDate);
+ };
Review Comment:
When we click on the 'cross' to clear the filter values, the grid isn't
updated. This doens't trigger a re-render but should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
bbovenzi commented on code in PR #62797:
URL: https://github.com/apache/airflow/pull/62797#discussion_r2905932588
##
airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json:
##
@@ -122,6 +122,7 @@
"graphDirection": {
"label": "Graph Direction"
},
+"runAfterRange": "Run After Range",
Review Comment:
I think we can just reuse "Run After" and avoid adding an extra translation
key. Runs and Task Instances filters work fine already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
Prajwal7842 commented on code in PR #62797: URL: https://github.com/apache/airflow/pull/62797#discussion_r2901693315 ## airflow-core/src/airflow/ui/src/components/SingleDatePicker.tsx: ## @@ -0,0 +1,170 @@ +/*! Review Comment: Thanks for the review. I have updated the PR as per comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
bbovenzi commented on code in PR #62797: URL: https://github.com/apache/airflow/pull/62797#discussion_r2897186689 ## airflow-core/src/airflow/ui/src/components/SingleDatePicker.tsx: ## @@ -0,0 +1,170 @@ +/*! Review Comment: +1 then we can get rid of the "Run After (before)" confusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
pierrejeambrun commented on code in PR #62797: URL: https://github.com/apache/airflow/pull/62797#discussion_r2896451474 ## airflow-core/src/airflow/ui/src/components/SingleDatePicker.tsx: ## @@ -0,0 +1,170 @@ +/*! Review Comment: Probably re-use the `DateRangeFilter` component. So we can filter from 'start' and 'end' on 'run_after'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add filter with run_after field in dags/:dagid/runs page [airflow]
Prajwal7842 commented on PR #62797: URL: https://github.com/apache/airflow/pull/62797#issuecomment-3992247747 Looking to verify whether the solution works or not. For eg: 1. Having filter on "Run After" field works or not. 2. Text used is sufficient to help users understand the meaning of this filter or not. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
