Re: [PR] Fix _get_count in sensor_helper.py [airflow]
github-actions[bot] commented on PR #40795: URL: https://github.com/apache/airflow/pull/40795#issuecomment-2585490759 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix _get_count in sensor_helper.py [airflow]
eladkal commented on PR #40795: URL: https://github.com/apache/airflow/pull/40795#issuecomment-2500320495 Since @nathadfield confirmed it's a bug fix, I am happy to merge once you add a unit test to cover this change. This is needed to making sure we won't have future regression -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix _get_count in sensor_helper.py [airflow]
fuatcakici commented on PR #40795: URL: https://github.com/apache/airflow/pull/40795#issuecomment-2500240250 @eladkal Rebased once again and all the tests succeeded 🙂 There are of course many changes happening in real time so it is virtually impossible for the branch to stay constantly up-to-date -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix _get_count in sensor_helper.py [airflow]
eladkal commented on PR #40795: URL: https://github.com/apache/airflow/pull/40795#issuecomment-2499923248 @fuatcakici can you rebase and resolve conflicts? Also we need unit test to avoid regression -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix _get_count in sensor_helper.py [airflow]
github-actions[bot] commented on PR #40795: URL: https://github.com/apache/airflow/pull/40795#issuecomment-2499294909 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
