Re: [PR] Fix docs publishing for task-sdk [airflow]
potiuk merged PR #51656: URL: https://github.com/apache/airflow/pull/51656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix docs publishing for task-sdk [airflow]
ashb commented on code in PR #51656:
URL: https://github.com/apache/airflow/pull/51656#discussion_r2142969839
##
dev/breeze/src/airflow_breeze/utils/docs_publisher.py:
##
@@ -66,6 +66,8 @@ def _current_version(self):
if self.package_name.startswith("apache-airflow-providers-"):
provider =
get_provider_distributions_metadata().get(get_short_package_name(self.package_name))
return provider["versions"][0]
+if self.package_name == "task-sdk":
Review Comment:
Cool, and yeah, agreed, shorter is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix docs publishing for task-sdk [airflow]
potiuk commented on code in PR #51656:
URL: https://github.com/apache/airflow/pull/51656#discussion_r2142899079
##
dev/breeze/src/airflow_breeze/utils/docs_publisher.py:
##
@@ -66,6 +66,8 @@ def _current_version(self):
if self.package_name.startswith("apache-airflow-providers-"):
provider =
get_provider_distributions_metadata().get(get_short_package_name(self.package_name))
return provider["versions"][0]
+if self.package_name == "task-sdk":
Review Comment:
Not too related. Those are not distribution names, they are names of
"documentation packages" - which are different than distributions - they also
include "docker-stack" , "helm-chart", "apache-airflow-providers" and
"apache-airflow" - and essentially they are the prefixes in our documentation
pages:
* https://airflow.apache.org/docs/apache-airflow/stable/index.html (this is
for apache-airflow-core distribution)
* https://airflow.apache.org/docs/apache-airflow-providers/index.html
* https://airflow.apache.org/docs/docker-stack/index.html
* https://airflow.apache.org/docs/helm-chart/stable/index.html
So they do not **have to**" be distribution names and I'd say shorter in
this case is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix docs publishing for task-sdk [airflow]
potiuk commented on code in PR #51656:
URL: https://github.com/apache/airflow/pull/51656#discussion_r2142899079
##
dev/breeze/src/airflow_breeze/utils/docs_publisher.py:
##
@@ -66,6 +66,8 @@ def _current_version(self):
if self.package_name.startswith("apache-airflow-providers-"):
provider =
get_provider_distributions_metadata().get(get_short_package_name(self.package_name))
return provider["versions"][0]
+if self.package_name == "task-sdk":
Review Comment:
Not too related. Those are not distribution names, they are names of
"documentation packages" - which are different than distributions - they also
include "docker-stack" , "helm-chart", "apache-airflow-providers" and
"apache-airflow" - and essentially they are the prefixes in our documentation
pages:
* https://airflow.apache.org/docs/apache-airflow/stable/index.html
* https://airflow.apache.org/docs/apache-airflow-providers/index.html
* https://airflow.apache.org/docs/docker-stack/index.html
* https://airflow.apache.org/docs/helm-chart/stable/index.html
So they do not **have to**" be distribution names and I'd say shorter in
this case is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix docs publishing for task-sdk [airflow]
potiuk commented on code in PR #51656:
URL: https://github.com/apache/airflow/pull/51656#discussion_r2142899079
##
dev/breeze/src/airflow_breeze/utils/docs_publisher.py:
##
@@ -66,6 +66,8 @@ def _current_version(self):
if self.package_name.startswith("apache-airflow-providers-"):
provider =
get_provider_distributions_metadata().get(get_short_package_name(self.package_name))
return provider["versions"][0]
+if self.package_name == "task-sdk":
Review Comment:
Not too related. Those are not distribution names, they are names of
"documentation packages" - which are different than distributions - they also
include "docker-stack" , "helm-chart", "apache-airflow-providers" and
"apache-airflow" - and essentially they are the prefixes in our documentation
pages:
* https://airflow.apache.org/docs/apache-airflow/stable/index.html
* https://airflow.apache.org/docs/apache-airflow-providers/index.html
* https://airflow.apache.org/docs/docker-stack/index.html
* https://airflow.apache.org/docs/helm-chart/stable/index.html
So they do not **have to" be distribution names and I'd say shorter in this
case is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix docs publishing for task-sdk [airflow]
ashb commented on code in PR #51656:
URL: https://github.com/apache/airflow/pull/51656#discussion_r2142876889
##
dev/breeze/src/airflow_breeze/utils/docs_publisher.py:
##
@@ -66,6 +66,8 @@ def _current_version(self):
if self.package_name.startswith("apache-airflow-providers-"):
provider =
get_provider_distributions_metadata().get(get_short_package_name(self.package_name))
return provider["versions"][0]
+if self.package_name == "task-sdk":
Review Comment:
Should this be "apache-airflow-task-sdk"? Don't think it really matters mind
you, but that is what the dist is called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
