Re: [PR] Pool API improve slots validation [airflow]
pierrejeambrun commented on PR #61071: URL: https://github.com/apache/airflow/pull/61071#issuecomment-3996927497 @jhohrath1 There was a follow up PR there https://github.com/apache/airflow/pull/61140/changes, this was just a transitional state. 0 and -1 are both allowed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pool API improve slots validation [airflow]
jhohrath1 commented on PR #61071: URL: https://github.com/apache/airflow/pull/61071#issuecomment-3993026659 In our airflow maintenance procedures, we have been setting pools to 0 in order to stop tasks being scheduled so we can perform maintenance without losing task runs. This breaks that, is there a better practice to performing maintenance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pool API improve slots validation [airflow]
github-actions[bot] commented on PR #61071: URL: https://github.com/apache/airflow/pull/61071#issuecomment-3804614641 ### Backport successfully created: v3-1-test Status Branch Result ✅ v3-1-test https://github.com/apache/airflow/pull/61114";>https://img.shields.io/badge/PR-61114-blue"; alt="PR Link"> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pool API improve slots validation [airflow]
pierrejeambrun commented on PR #61071: URL: https://github.com/apache/airflow/pull/61071#issuecomment-3804623726 Issue here https://github.com/apache/airflow/issues/61115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pool API improve slots validation [airflow]
pierrejeambrun merged PR #61071: URL: https://github.com/apache/airflow/pull/61071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pool API improve slots validation [airflow]
pierrejeambrun commented on PR #61071: URL: https://github.com/apache/airflow/pull/61071#issuecomment-3804608213 Ok, after more thoughts, lets merge this for now, which is better than no validation at all. Currently -1 is not possible to use via the API, because it will be returned as `infinity` to the server which will 500. (and the front does not currently handle infinity as available pool slots). I'll create a separate issue for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pool API improve slots validation [airflow]
pierrejeambrun commented on PR #61071: URL: https://github.com/apache/airflow/pull/61071#issuecomment-3800385938 Arf, yes there is that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
