Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
potiuk merged PR #59995: URL: https://github.com/apache/airflow/pull/59995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
sunank200 commented on code in PR #59995: URL: https://github.com/apache/airflow/pull/59995#discussion_r2659161904 ## providers/odbc/pyproject.toml: ## @@ -64,11 +64,19 @@ dependencies = [ "pyodbc>=5.2.0; python_version >= '3.13'", ] +# The optional dependencies should be modified in place in the generated file +# Any change in the dependencies is preserved when the file is regenerated +[project.optional-dependencies] +"common.compat" = [ +"apache-airflow-providers-common-compat" Review Comment: Changed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
sunank200 commented on PR #59995: URL: https://github.com/apache/airflow/pull/59995#issuecomment-3707371769 > One small thing left here ? Added the change now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
potiuk commented on PR #59995: URL: https://github.com/apache/airflow/pull/59995#issuecomment-3707317439 One small thing left here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
potiuk commented on code in PR #59995: URL: https://github.com/apache/airflow/pull/59995#discussion_r2655970080 ## providers/odbc/pyproject.toml: ## @@ -64,11 +64,19 @@ dependencies = [ "pyodbc>=5.2.0; python_version >= '3.13'", ] +# The optional dependencies should be modified in place in the generated file +# Any change in the dependencies is preserved when the file is regenerated +[project.optional-dependencies] +"common.compat" = [ +"apache-airflow-providers-common-compat" Review Comment: We should move it to regular dependencies and add `>=1.10.1" # use next version` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
potiuk commented on code in PR #59995: URL: https://github.com/apache/airflow/pull/59995#discussion_r2655970080 ## providers/odbc/pyproject.toml: ## @@ -64,11 +64,19 @@ dependencies = [ "pyodbc>=5.2.0; python_version >= '3.13'", ] +# The optional dependencies should be modified in place in the generated file +# Any change in the dependencies is preserved when the file is regenerated +[project.optional-dependencies] +"common.compat" = [ +"apache-airflow-providers-common-compat" Review Comment: We should move it to regular dependencies and add `>=1.10.0 # use next version` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
potiuk commented on code in PR #59995: URL: https://github.com/apache/airflow/pull/59995#discussion_r2655970080 ## providers/odbc/pyproject.toml: ## @@ -64,11 +64,19 @@ dependencies = [ "pyodbc>=5.2.0; python_version >= '3.13'", ] +# The optional dependencies should be modified in place in the generated file +# Any change in the dependencies is preserved when the file is regenerated +[project.optional-dependencies] +"common.compat" = [ +"apache-airflow-providers-common-compat" Review Comment: We should move it to regular dependencies and add `>=1.11.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
potiuk commented on code in PR #59995: URL: https://github.com/apache/airflow/pull/59995#discussion_r2655969274 ## providers/odbc/pyproject.toml: ## @@ -64,11 +64,19 @@ dependencies = [ "pyodbc>=5.2.0; python_version >= '3.13'", ] +# The optional dependencies should be modified in place in the generated file +# Any change in the dependencies is preserved when the file is regenerated +[project.optional-dependencies] +"common.compat" = [ +"apache-airflow-providers-common-compat" +] + [dependency-groups] dev = [ "apache-airflow", "apache-airflow-task-sdk", "apache-airflow-devel-common", +"apache-airflow-providers-common-compat", Review Comment: ```suggestion "apache-airflow-providers-common-compat", # use next version ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Source odbc provider to use airflow.sdk.configuration.conf [airflow]
potiuk commented on code in PR #59995: URL: https://github.com/apache/airflow/pull/59995#discussion_r2655969274 ## providers/odbc/pyproject.toml: ## @@ -64,11 +64,19 @@ dependencies = [ "pyodbc>=5.2.0; python_version >= '3.13'", ] +# The optional dependencies should be modified in place in the generated file +# Any change in the dependencies is preserved when the file is regenerated +[project.optional-dependencies] +"common.compat" = [ +"apache-airflow-providers-common-compat" +] + [dependency-groups] dev = [ "apache-airflow", "apache-airflow-task-sdk", "apache-airflow-devel-common", +"apache-airflow-providers-common-compat", Review Comment: ```suggestion "apache-airflow-providers-common-compat", # use next version ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
