Re: [PR] UI: Add custom RouterLink component [airflow]
choo121600 commented on PR #66945: URL: https://github.com/apache/airflow/pull/66945#issuecomment-4466071440 Automatic backporting failed due to conflicts in 4 files, including DeadlineRow.tsx. Since this is a refactor (not a bug fix), I’m removing the backport label for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
github-actions[bot] commented on PR #66945: URL: https://github.com/apache/airflow/pull/66945#issuecomment-4466044923 ### Backport failed to create: v3-2-test. View the failure log Run details Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x) the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches. In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel. Status Branch Result ❌ v3-2-test https://github.com/apache/airflow/commit/42a85ee1ac90818566c9487cff20337dbc8cab7b";> You can attempt to backport this manually by running: ```bash cherry_picker 42a85ee v3-2-test ``` This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
github-actions[bot] commented on PR #66945: URL: https://github.com/apache/airflow/pull/66945#issuecomment-4466043804 Hi maintainer, this PR was merged without a milestone set. We've automatically set the milestone to **[Airflow 3.2.3](https://github.com/apache/airflow/milestone/140)** based on: backport label targeting v3-2-test If this milestone is not correct, please update it to the appropriate milestone. > This comment was generated by [Milestone Tag Assistant](https://github.com/apache/airflow/blob/main/.github/workflows/milestone-tag-assistant.yml). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
choo121600 merged PR #66945: URL: https://github.com/apache/airflow/pull/66945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
choo121600 commented on PR #66945: URL: https://github.com/apache/airflow/pull/66945#issuecomment-4465744059 Looks like the CI failure is unrelated to this PR. I'll rerun it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
bbovenzi commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3243160366
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -83,20 +83,18 @@ export const DagCard = ({ dag }: Props) => {
{latestRun ? (
-
-
-
-{isStatePending(latestRun.state) && !dag.is_paused &&
Boolean(refetchInterval) ? (
-
-) : undefined}
-
-
+
Review Comment:
Just rename this one back to `Link`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
bbovenzi commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3250413670
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
-
+
{dag.dag_display_name}
-
+
Review Comment:
Sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
choo121600 commented on PR #66945: URL: https://github.com/apache/airflow/pull/66945#issuecomment-4460969831 @parkhojeong — Your unresolved review thread(s) from @bbovenzi appear to have been addressed (post-review commits and/or in-thread replies on every thread, with the latest commit pushed after the most recent thread). I've added the `ready for maintainer review` label so the PR re-enters the maintainer review queue. @bbovenzi — could you take another look when you have a chance? If you agree the feedback was addressed, please mark the threads as resolved so the queue signal stays accurate. If a thread still needs work, please reply in-line — @parkhojeong will follow up. --- _Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._ --- Drafted-by: Claude Code (Opus 4.7); reviewed by @choo121600 before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
parkhojeong commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3246608665
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
-
+
{dag.dag_display_name}
-
+
Review Comment:
Thanks for the catch
Using data-testid on either Chakra Link or React Router's RouterLink
produces the same rendered result in the existing code: `link`.
```tsx
link
link
```
I moved data-testid to Chakra Link. What do you
think?https://github.com/apache/airflow/pull/66945/commits/dfae9f0d9e88ffc990829191d892ec870ea72810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
parkhojeong commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3246608665
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
-
+
{dag.dag_display_name}
-
+
Review Comment:
Using data-testid on either Chakra Link or React Router's RouterLink
produces the same rendered result in the existing code: `link`.
```tsx
link
link
```
I moved data-testid to Chakra Link. What do you
think?https://github.com/apache/airflow/pull/66945/commits/dfae9f0d9e88ffc990829191d892ec870ea72810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
parkhojeong commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3246608665
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
-
+
{dag.dag_display_name}
-
+
Review Comment:
Using data-testid on either Chakra Link or React Router's RouterLink
produces the same rendered result in the existing code: `link`.
```tsx
link
link
```
I moved data-testid to Chakra Link. What do you
think?https://github.com/apache/airflow/pull/66945/commits/dfae9f0d9e88ffc990829191d892ec870ea72810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
parkhojeong commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3246608665
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
-
+
{dag.dag_display_name}
-
+
Review Comment:
Using data-testid on either Chakra Link or React Router's RouterLink
produces the same rendered result in the existing code: `link`.
```tsx
link
link
```
I moved data-testid to Chakra Link. What do you
think?https://github.com/apache/airflow/pull/66945/commits/dfae9f0d9e88ffc990829191d892ec870ea72810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
parkhojeong commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3246608665
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
-
+
{dag.dag_display_name}
-
+
Review Comment:
Using data-testid on either Chakra Link or React Router's RouterLink
produces the same rendered result in the existing code: link.
```tsx
link
link
```
I moved data-testid to Chakra Link. What do you
think?https://github.com/apache/airflow/pull/66945/commits/dfae9f0d9e88ffc990829191d892ec870ea72810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
bbovenzi commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3243156445
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
-
+
{dag.dag_display_name}
-
+
Review Comment:
This one wasn't converted correctly
##
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##
@@ -83,20 +83,18 @@ export const DagCard = ({ dag }: Props) => {
{latestRun ? (
-
-
-
-{isStatePending(latestRun.state) && !dag.is_paused &&
Boolean(refetchInterval) ? (
-
-) : undefined}
-
-
+
Review Comment:
Just rename this one back to `Link`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] UI: Add custom RouterLink component [airflow]
bbovenzi commented on PR #66945: URL: https://github.com/apache/airflow/pull/66945#issuecomment-4451502972 Looks great! Let's apply it everywhere -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
