[jira] [Commented] (AIRFLOW-3223) RBAC with GitHub Authentication

2018-12-13 Thread Sai Phanindhra (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720211#comment-16720211
 ] 

Sai Phanindhra commented on AIRFLOW-3223:
-

[~ashb] I think airflow already supports github authentication

> RBAC with  GitHub Authentication
> 
>
> Key: AIRFLOW-3223
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3223
> Project: Apache Airflow
>  Issue Type: Wish
>  Components: authentication
>Affects Versions: 1.10.0
>Reporter: Vikram Fugro
>Assignee: Sai Phanindhra
>Priority: Major
>
> With airflow 1.10 released having RBAC support, I was wondering how I do 
> configure GitHub Auth with airflow's RBAC.  In which case, I believe we don't 
> have to create any users using airflow.  Are there any notes on this?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-3223) RBAC with GitHub Authentication

2018-12-13 Thread Ash Berlin-Taylor (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720011#comment-16720011
 ] 

Ash Berlin-Taylor commented on AIRFLOW-3223:


FAB uses Flask-OpenID for Oauth, and that should be workable for Github. I 
don't know the exact config you'd need but it feels like it should be doable 
without needing any code changes.

Useful docs:
https://flask-appbuilder.readthedocs.io/en/latest/security.html#authentication-openid
https://pythonhosted.org/Flask-OpenID/
https://help.github.com/articles/authorizing-oauth-apps/

> RBAC with  GitHub Authentication
> 
>
> Key: AIRFLOW-3223
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3223
> Project: Apache Airflow
>  Issue Type: Wish
>  Components: authentication
>Affects Versions: 1.10.0
>Reporter: Vikram Fugro
>Assignee: Sai Phanindhra
>Priority: Major
>
> With airflow 1.10 released having RBAC support, I was wondering how I do 
> configure GitHub Auth with airflow's RBAC.  In which case, I believe we don't 
> have to create any users using airflow.  Are there any notes on this?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-3223) RBAC with GitHub Authentication

2018-12-12 Thread Tao Feng (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719757#comment-16719757
 ] 

Tao Feng commented on AIRFLOW-3223:
---

Would it be suitable to fix / add the feature in flask-appbuilder?

> RBAC with  GitHub Authentication
> 
>
> Key: AIRFLOW-3223
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3223
> Project: Apache Airflow
>  Issue Type: Wish
>  Components: authentication
>Affects Versions: 1.10.0
>Reporter: Vikram Fugro
>Assignee: Sai Phanindhra
>Priority: Major
>
> With airflow 1.10 released having RBAC support, I was wondering how I do 
> configure GitHub Auth with airflow's RBAC.  In which case, I believe we don't 
> have to create any users using airflow.  Are there any notes on this?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)