[GitHub] ashb commented on issue #4195: [AIRFLOW-3353] Pin redis version

2018-11-18 Thread GitBox
ashb commented on issue #4195: [AIRFLOW-3353] Pin redis version URL: https://github.com/apache/incubator-airflow/pull/4195#issuecomment-439676172 No, we aren't planning on releasing a new 1.9 - also celery are working on a proper fix on their side (if you were going to install a new

[GitHub] codecov-io edited a comment on issue #4201: [AIRFLOW-3360] Make the DAGs search respect other querystring parameters

2018-11-18 Thread GitBox
codecov-io edited a comment on issue #4201: [AIRFLOW-3360] Make the DAGs search respect other querystring parameters URL: https://github.com/apache/incubator-airflow/pull/4201#issuecomment-439543567 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4201?src=pr=h1) Report

[GitHub] codecov-io edited a comment on issue #4201: [AIRFLOW-3360] Make the DAGs search respect other querystring parameters

2018-11-18 Thread GitBox
codecov-io edited a comment on issue #4201: [AIRFLOW-3360] Make the DAGs search respect other querystring parameters URL: https://github.com/apache/incubator-airflow/pull/4201#issuecomment-439543567 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4201?src=pr=h1) Report

[jira] [Created] (AIRFLOW-3362) Template to support jinja2 native python types

2018-11-18 Thread Duan Shiqiang (JIRA)
Duan Shiqiang created AIRFLOW-3362: -- Summary: Template to support jinja2 native python types Key: AIRFLOW-3362 URL: https://issues.apache.org/jira/browse/AIRFLOW-3362 Project: Apache Airflow

[jira] [Created] (AIRFLOW-3361) Add the task_id to the Deprecation Warning when passing unsupported keywords to BaseOperator

2018-11-18 Thread Martin Black (JIRA)
Martin Black created AIRFLOW-3361: - Summary: Add the task_id to the Deprecation Warning when passing unsupported keywords to BaseOperator Key: AIRFLOW-3361 URL: https://issues.apache.org/jira/browse/AIRFLOW-3361

[jira] [Commented] (AIRFLOW-3361) Add the task_id to the Deprecation Warning when passing unsupported keywords to BaseOperator

2018-11-18 Thread Martin Black (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690880#comment-16690880 ] Martin Black commented on AIRFLOW-3361: --- PR https://github.com/apache/incubator-airflow/pull/4030

[jira] [Work started] (AIRFLOW-3361) Add the task_id to the Deprecation Warning when passing unsupported keywords to BaseOperator

2018-11-18 Thread Martin Black (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-3361 started by Martin Black. - > Add the task_id to the Deprecation Warning when passing unsupported

[GitHub] mblack20 commented on issue #4030: [AIRFLOW-3361] Log the task_id in the PendingDeprecationWarning for BaseOperator

2018-11-18 Thread GitBox
mblack20 commented on issue #4030: [AIRFLOW-3361] Log the task_id in the PendingDeprecationWarning for BaseOperator URL: https://github.com/apache/incubator-airflow/pull/4030#issuecomment-439688383 Done, JIRA issue [AIRFLOW-3361](https://issues.apache.org/jira/browse/AIRFLOW-3361)

[jira] [Commented] (AIRFLOW-2775) Recent Tasks Label Misleading

2018-11-18 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690833#comment-16690833 ] jack commented on AIRFLOW-2775: --- isn't it better to just say "tasks from the most recent run" ? If it's

[jira] [Updated] (AIRFLOW-3361) Add the task_id to the Deprecation Warning when passing unsupported keywords to BaseOperator

2018-11-18 Thread Martin Black (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Black updated AIRFLOW-3361: -- Description: In 2.0 passing invalid keywords to {{BaseOperator}} will be deprecated. Prior

[GitHub] Fokko commented on a change in pull request #4090: [AIRFLOW-3250] Fix for Redis Hook for not authorised connection calls

2018-11-18 Thread GitBox
Fokko commented on a change in pull request #4090: [AIRFLOW-3250] Fix for Redis Hook for not authorised connection calls URL: https://github.com/apache/incubator-airflow/pull/4090#discussion_r234452823 ## File path: tests/contrib/hooks/test_redis_hook.py ## @@ -19,32

[GitHub] Fokko commented on a change in pull request #4090: [AIRFLOW-3250] Fix for Redis Hook for not authorised connection calls

2018-11-18 Thread GitBox
Fokko commented on a change in pull request #4090: [AIRFLOW-3250] Fix for Redis Hook for not authorised connection calls URL: https://github.com/apache/incubator-airflow/pull/4090#discussion_r234452826 ## File path: tests/contrib/hooks/test_redis_hook.py ## @@ -19,32

[GitHub] Fokko commented on issue #4207: [WIP] Run celery integration test with redis broker.

2018-11-18 Thread GitBox
Fokko commented on issue #4207: [WIP] Run celery integration test with redis broker. URL: https://github.com/apache/incubator-airflow/pull/4207#issuecomment-439707713 Please consult with https://github.com/apache/incubator-airflow/pull/4090 before you do any duplicate work :-)

[jira] [Updated] (AIRFLOW-1252) Experimental API - exception when conf is present in JSON body

2018-11-18 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-1252: --- Fix Version/s: 1.10.2 > Experimental API - exception when conf is present in JSON

[jira] [Updated] (AIRFLOW-3307) Update insecure node dependencies

2018-11-18 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3307: --- Issue Type: Improvement (was: Bug) > Update insecure node dependencies >

[jira] [Resolved] (AIRFLOW-801) Outdated docstring on baseclass

2018-11-18 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-801. --- Resolution: Fixed > Outdated docstring on baseclass >

[jira] [Resolved] (AIRFLOW-3307) Update insecure node dependencies

2018-11-18 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3307. Resolution: Fixed Fix Version/s: 2.0.0 > Update insecure node

[jira] [Resolved] (AIRFLOW-3306) Disable unused flask-sqlalchemy modification tracking

2018-11-18 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3306. Resolution: Fixed Fix Version/s: 1.10.2 2.0.0 >

[jira] [Commented] (AIRFLOW-3361) Add the task_id to the Deprecation Warning when passing unsupported keywords to BaseOperator

2018-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691042#comment-16691042 ] ASF GitHub Bot commented on AIRFLOW-3361: - ashb closed pull request #4030: [AIRFLOW-3361] Log

[GitHub] Fokko closed pull request #2334: [AIRFLOW-1252] API - Fix when conf is in JSON body

2018-11-18 Thread GitBox
Fokko closed pull request #2334: [AIRFLOW-1252] API - Fix when conf is in JSON body URL: https://github.com/apache/incubator-airflow/pull/2334 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[jira] [Commented] (AIRFLOW-1252) Experimental API - exception when conf is present in JSON body

2018-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690980#comment-16690980 ] ASF GitHub Bot commented on AIRFLOW-1252: - Fokko closed pull request #2334: [AIRFLOW-1252] API

[GitHub] Fokko commented on issue #4139: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates

2018-11-18 Thread GitBox
Fokko commented on issue #4139: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates URL: https://github.com/apache/incubator-airflow/pull/4139#issuecomment-439710673 Rerunning the failed tests. This

[jira] [Resolved] (AIRFLOW-1252) Experimental API - exception when conf is present in JSON body

2018-11-18 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-1252. --- Resolution: Fixed Fix Version/s: 2.0.0 > Experimental API - exception when

[GitHub] codecov-io edited a comment on issue #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-18 Thread GitBox
codecov-io edited a comment on issue #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/4209#issuecomment-439729859 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4209?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-18 Thread GitBox
codecov-io commented on issue #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/4209#issuecomment-439729859 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4209?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-18 Thread GitBox
codecov-io edited a comment on issue #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/4209#issuecomment-439729859 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4209?src=pr=h1) Report > Merging

[GitHub] Fokko commented on issue #2799: [AIRFLOW-1836] airflow uses OAuth Provider keycloak

2018-11-18 Thread GitBox
Fokko commented on issue #2799: [AIRFLOW-1836] airflow uses OAuth Provider keycloak URL: https://github.com/apache/incubator-airflow/pull/2799#issuecomment-439710457 I think it is for #3941 hard to implement it generic, i.e. have some logic to test the connection of an arbitrary

[jira] [Commented] (AIRFLOW-2966) KubernetesExecutor + namespace quotas kills scheduler if the pod can't be launched

2018-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690971#comment-16690971 ] ASF GitHub Bot commented on AIRFLOW-2966: - Fokko closed pull request #3960: [AIRFLOW-2966]

[GitHub] Fokko closed pull request #3960: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-18 Thread GitBox
Fokko closed pull request #3960: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/3960 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Closed] (AIRFLOW-2966) KubernetesExecutor + namespace quotas kills scheduler if the pod can't be launched

2018-11-18 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong closed AIRFLOW-2966. - Resolution: Fixed Assignee: John Hofman Fix Version/s: 2.0.0 >

[GitHub] ashb closed pull request #4030: [AIRFLOW-3361] Log the task_id in the PendingDeprecationWarning for BaseOperator

2018-11-18 Thread GitBox
ashb closed pull request #4030: [AIRFLOW-3361] Log the task_id in the PendingDeprecationWarning for BaseOperator URL: https://github.com/apache/incubator-airflow/pull/4030 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[jira] [Updated] (AIRFLOW-3361) Add the task_id to the Deprecation Warning when passing unsupported keywords to BaseOperator

2018-11-18 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3361: --- Issue Type: Improvement (was: Task) > Add the task_id to the Deprecation Warning

[GitHub] johnhofman opened a new pull request #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-18 Thread GitBox
johnhofman opened a new pull request #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/4209 ### Description Creating a pod that exceeds a namespace's resource quota throws an ApiException. This change catches

[jira] [Commented] (AIRFLOW-2966) KubernetesExecutor + namespace quotas kills scheduler if the pod can't be launched

2018-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691099#comment-16691099 ] ASF GitHub Bot commented on AIRFLOW-2966: - johnhofman opened a new pull request #4209:

[GitHub] johnhofman commented on issue #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-18 Thread GitBox
johnhofman commented on issue #4209: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/4209#issuecomment-439727645 @Fokko This is a resubmission of #3960, which was reverted when it broke the CI on master. This was due to

[jira] [Created] (AIRFLOW-3363) Plugin templates not rendered by Flask appbuilder's baseview

2018-11-18 Thread Ran Zvi (JIRA)
Ran Zvi created AIRFLOW-3363: Summary: Plugin templates not rendered by Flask appbuilder's baseview Key: AIRFLOW-3363 URL: https://issues.apache.org/jira/browse/AIRFLOW-3363 Project: Apache Airflow

[GitHub] jmcarp commented on issue #4207: [WIP] Run celery integration test with redis broker.

2018-11-18 Thread GitBox
jmcarp commented on issue #4207: [WIP] Run celery integration test with redis broker. URL: https://github.com/apache/incubator-airflow/pull/4207#issuecomment-439708132 @Fokko: sorry, I didn't realize this was a paid travis account. Anyway, the idea here is to test the redis backend for

[GitHub] Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-18 Thread GitBox
Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r234454702 ## File path: docs/integration.rst ## @@ -186,6 +186,43 @@

[GitHub] Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-18 Thread GitBox
Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r234454674 ## File path: airflow/models.py ## @@ -805,6 +806,9 @@ def get_hook(self):

[GitHub] Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-18 Thread GitBox
Fokko commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r234454490 ## File path: airflow/contrib/hooks/azure_container_registry_hook.py ## @@ -0,0 +1,32 @@

[GitHub] codecov-io edited a comment on issue #4139: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates

2018-11-18 Thread GitBox
codecov-io edited a comment on issue #4139: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates URL: https://github.com/apache/incubator-airflow/pull/4139#issuecomment-438279332 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4139?src=pr=h1)

[GitHub] codecov-io edited a comment on issue #4139: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates

2018-11-18 Thread GitBox
codecov-io edited a comment on issue #4139: [AIRFLOW-2715] Pick up the region setting while launching Dataflow templates URL: https://github.com/apache/incubator-airflow/pull/4139#issuecomment-438279332 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4139?src=pr=h1)

[GitHub] Fokko commented on issue #3960: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-18 Thread GitBox
Fokko commented on issue #3960: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/3960#issuecomment-439722764 @johnhofman I had to revert the commit again. The CI wasn't happy. Please take a look and open a new PR:

[jira] [Commented] (AIRFLOW-3362) Template to support jinja2 native python types

2018-11-18 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691041#comment-16691041 ] Ash Berlin-Taylor commented on AIRFLOW-3362: Oh interesting! I think that is a fairly new

[GitHub] Fokko commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-18 Thread GitBox
Fokko commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-439708448 Would it be possible to add some tests to this PR as well? This is an

[jira] [Resolved] (AIRFLOW-3361) Add the task_id to the Deprecation Warning when passing unsupported keywords to BaseOperator

2018-11-18 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3361. Resolution: Fixed Fix Version/s: 1.10.2 2.0.0 > Add

[GitHub] feng-tao commented on issue #4153: [AIRFLOW-3308] Fix plugins import

2018-11-18 Thread GitBox
feng-tao commented on issue #4153: [AIRFLOW-3308] Fix plugins import URL: https://github.com/apache/incubator-airflow/pull/4153#issuecomment-439774005 @Fokko , could you take a look? I think plugin management functionality is very important.

[GitHub] codecov-io edited a comment on issue #4207: [WIP] Run celery integration test with redis broker.

2018-11-18 Thread GitBox
codecov-io edited a comment on issue #4207: [WIP] Run celery integration test with redis broker. URL: https://github.com/apache/incubator-airflow/pull/4207#issuecomment-439668923 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4207?src=pr=h1) Report > Merging

[jira] [Assigned] (AIRFLOW-3053) Airflow scheduler - high availability ?

2018-11-18 Thread Sai Phanindhra (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Phanindhra reassigned AIRFLOW-3053: --- Assignee: Sai Phanindhra > Airflow scheduler - high availability ? >

[GitHub] omusavi commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-18 Thread GitBox
omusavi commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r234517271 ## File path: airflow/contrib/hooks/azure_container_registry_hook.py ## @@ -0,0 +1,32 @@

[GitHub] omusavi commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-18 Thread GitBox
omusavi commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r234517627 ## File path: airflow/models.py ## @@ -805,6 +806,9 @@ def get_hook(self):

[GitHub] omusavi commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator

2018-11-18 Thread GitBox
omusavi commented on a change in pull request #4121: [AIRFLOW-2568] Azure Container Instances operator URL: https://github.com/apache/incubator-airflow/pull/4121#discussion_r234518339 ## File path: docs/integration.rst ## @@ -186,6 +186,43 @@

[GitHub] Fokko commented on issue #4134: [AIRFLOW-3213] Create ADLS to GCS operator

2018-11-18 Thread GitBox
Fokko commented on issue #4134: [AIRFLOW-3213] Create ADLS to GCS operator URL: https://github.com/apache/incubator-airflow/pull/4134#issuecomment-439706018 @bkvarda Can you rebase on master as well? This is an automated

[GitHub] Fokko commented on issue #4207: [WIP] Run celery integration test with redis broker.

2018-11-18 Thread GitBox
Fokko commented on issue #4207: [WIP] Run celery integration test with redis broker. URL: https://github.com/apache/incubator-airflow/pull/4207#issuecomment-439705915 Hi @jmcarp Thanks for picking this up. Preferably you run the tests against your own Travis instance first,

[GitHub] Fokko commented on issue #3815: [AIRFLOW-2973] Add Python 3.6 to Supported Prog Langs

2018-11-18 Thread GitBox
Fokko commented on issue #3815: [AIRFLOW-2973] Add Python 3.6 to Supported Prog Langs URL: https://github.com/apache/incubator-airflow/pull/3815#issuecomment-439710806 Give me some time to look into this. This is an