kppullin opened a new pull request #4319: [AIRFLOW-2770] Read `dags_in_image` config value as a boolean URL: https://github.com/apache/incubator-airflow/pull/4319 This PR is a minor fix for #3683 The `dags_in_image` config value is read as a string. However, the existing code expects this to be a boolean. For example, in `worker_configuration.py` there is the statement: `if not self.kube_config.dags_in_image:` Since the value is a non-empty string ('False') and not a boolean, this evaluates to true (since non-empty strings are truthy) and skips the logic to add the `dags_volume_claim` volume mount. This results in the CI tests failing because the dag volume is missing in the k8s pod definition. This PR reads the `dags_in_image` using the `conf.getboolean` to fix this error.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
