[GitHub] victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets…

2018-11-16 Thread GitBox
victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets… URL: https://github.com/apache/incubator-airflow/pull/4188#issuecomment-439325577 @ashb I have finally added a test using the mock to validate that the pod operator properly set

[GitHub] victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets…

2018-11-14 Thread GitBox
victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets… URL: https://github.com/apache/incubator-airflow/pull/4188#issuecomment-438757111 @ashb for now I've implemented a test that checks that a failure happen if there is an incorrect

[GitHub] victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets…

2018-11-14 Thread GitBox
victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets… URL: https://github.com/apache/incubator-airflow/pull/4188#issuecomment-438752839 @ashb or I can test that a failure happen when an incorrect `image_pull_secrets` is used to create

[GitHub] victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets…

2018-11-14 Thread GitBox
victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets… URL: https://github.com/apache/incubator-airflow/pull/4188#issuecomment-438751612 @ashb yes, but I'm not familiar with the tests of airflow. Where should they reside? In