[GitHub] victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets…
victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets… URL: https://github.com/apache/incubator-airflow/pull/4188#issuecomment-439325577 @ashb I have finally added a test using the mock to validate that the pod operator properly set the parameter on the pod. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets…
victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets… URL: https://github.com/apache/incubator-airflow/pull/4188#issuecomment-438757111 @ashb for now I've implemented a test that checks that a failure happen if there is an incorrect `image_pull_secret`, because I have trouble finding what should be mocked exactly to test this. Sorry I'm not very familiar with python unit testing framework :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets…
victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets… URL: https://github.com/apache/incubator-airflow/pull/4188#issuecomment-438752839 @ashb or I can test that a failure happen when an incorrect `image_pull_secrets` is used to create a pod (as with `service_account_name`). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets…
victornoel commented on issue #4188: [AIRFLOW-3251] KubernetesPodOperator does not use 'image_pull_secrets… URL: https://github.com/apache/incubator-airflow/pull/4188#issuecomment-438751612 @ashb yes, but I'm not familiar with the tests of airflow. Where should they reside? In `test_kubernetes_pod_operator.py`? This looks like integration tests so I'm not sure. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
