[jira] [Commented] (AIRFLOW-1267) BigQueryCheckOperator is not configurable on the use_legacy_sql flag
[ https://issues.apache.org/jira/browse/AIRFLOW-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350591#comment-16350591 ] Guillermo Rodríguez Cano commented on AIRFLOW-1267: --- As mentioned [here|https://issues.apache.org/jira/browse/AIRFLOW-1874?focusedCommentId=16350585&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16350585] which includes the issue of this Jira, it should be reopened as it is not yet supported in the mentioned operator (although it is in the hook). Changes are minimal and trivial, but for clarity it is not yet resolved. > BigQueryCheckOperator is not configurable on the use_legacy_sql flag > > > Key: AIRFLOW-1267 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1267 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib, db >Reporter: Lan Xu >Priority: Critical > Fix For: 2.0.0 > > > The BigqueryCheckOperator is not configurable to use standard sql, which is > causing our DAGs to fail. It might be due to the BigQuery hook configs using > legacy sql as default, and the check operator class never has access to > change that configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-1267) BigQueryCheckOperator is not configurable on the use_legacy_sql flag
[ https://issues.apache.org/jira/browse/AIRFLOW-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334576#comment-16334576 ] ASF subversion and git services commented on AIRFLOW-1267: -- Commit 1021f680317305e4ceb3a3b06889a8742cc3f6f3 in incubator-airflow's branch refs/heads/master from [~weiqingh] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=1021f68 ] [AIRFLOW-1267][AIRFLOW-1874] Add dialect parameter to BigQueryHook Allows a default BigQuery dialect to be specified at the hook level, which is threaded through to the underlying cursors. This allows standard SQL dialect to be used, while maintaining compatibility with the `DbApiHook` interface. Addresses AIRFLOW-1267 and AIRFLOW-1874 Closes #2964 from ji-han/master > BigQueryCheckOperator is not configurable on the use_legacy_sql flag > > > Key: AIRFLOW-1267 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1267 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib, db >Reporter: Lan Xu >Priority: Critical > > The BigqueryCheckOperator is not configurable to use standard sql, which is > causing our DAGs to fail. It might be due to the BigQuery hook configs using > legacy sql as default, and the check operator class never has access to > change that configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-1267) BigQueryCheckOperator is not configurable on the use_legacy_sql flag
[ https://issues.apache.org/jira/browse/AIRFLOW-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334574#comment-16334574 ] ASF subversion and git services commented on AIRFLOW-1267: -- Commit 1021f680317305e4ceb3a3b06889a8742cc3f6f3 in incubator-airflow's branch refs/heads/master from [~weiqingh] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=1021f68 ] [AIRFLOW-1267][AIRFLOW-1874] Add dialect parameter to BigQueryHook Allows a default BigQuery dialect to be specified at the hook level, which is threaded through to the underlying cursors. This allows standard SQL dialect to be used, while maintaining compatibility with the `DbApiHook` interface. Addresses AIRFLOW-1267 and AIRFLOW-1874 Closes #2964 from ji-han/master > BigQueryCheckOperator is not configurable on the use_legacy_sql flag > > > Key: AIRFLOW-1267 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1267 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib, db >Reporter: Lan Xu >Priority: Critical > > The BigqueryCheckOperator is not configurable to use standard sql, which is > causing our DAGs to fail. It might be due to the BigQuery hook configs using > legacy sql as default, and the check operator class never has access to > change that configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-1267) BigQueryCheckOperator is not configurable on the use_legacy_sql flag
[ https://issues.apache.org/jira/browse/AIRFLOW-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048151#comment-16048151 ] Lan Xu commented on AIRFLOW-1267: - any updates on how long it would take to fix it? > BigQueryCheckOperator is not configurable on the use_legacy_sql flag > > > Key: AIRFLOW-1267 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1267 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib, db >Reporter: Lan Xu >Priority: Critical > > The BigqueryCheckOperator is not configurable to use standard sql, which is > causing our DAGs to fail. It might be due to the BigQuery hook configs using > legacy sql as default, and the check operator class never has access to > change that configuration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AIRFLOW-1267) BigQueryCheckOperator is not configurable on the use_legacy_sql flag
[ https://issues.apache.org/jira/browse/AIRFLOW-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037560#comment-16037560 ] Chris Riccomini commented on AIRFLOW-1267: -- I took a brief look at this. It's a little tricky because the BQ check operator uses the generic DbApiHook methods (e.g. get_first), which obviously don't expose BQ-specific params like use_legacy_sql. We either have to abandon the DbApiHook inheritance, or extend it with a BqDbApiHook that properly sets the use_legacy_sql param where it needs to be set. > BigQueryCheckOperator is not configurable on the use_legacy_sql flag > > > Key: AIRFLOW-1267 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1267 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib, db >Reporter: Lan Xu >Priority: Critical > > The BigqueryCheckOperator is not configurable to use standard sql, which is > causing our DAGs to fail. It might be due to the BigQuery hook configs using > legacy sql as default, and the check operator class never has access to > change that configuration. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (AIRFLOW-1267) BigQueryCheckOperator is not configurable on the use_legacy_sql flag
[ https://issues.apache.org/jira/browse/AIRFLOW-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036930#comment-16036930 ] Lan Xu commented on AIRFLOW-1267: - I'd leave it to someone who's more familiar to the code base for the fix. > BigQueryCheckOperator is not configurable on the use_legacy_sql flag > > > Key: AIRFLOW-1267 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1267 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib, db >Reporter: Lan Xu >Priority: Critical > > The BigqueryCheckOperator is not configurable to use standard sql, which is > causing our DAGs to fail. It might be due to the BigQuery hook configs using > legacy sql as default, and the check operator class never has access to > change that configuration. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (AIRFLOW-1267) BigQueryCheckOperator is not configurable on the use_legacy_sql flag
[ https://issues.apache.org/jira/browse/AIRFLOW-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035325#comment-16035325 ] Chris Riccomini commented on AIRFLOW-1267: -- [~lanxxnal], want to submit a PR to fix it? > BigQueryCheckOperator is not configurable on the use_legacy_sql flag > > > Key: AIRFLOW-1267 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1267 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib, db >Reporter: Lan Xu >Priority: Critical > > The BigqueryCheckOperator is not configurable to use standard sql, which is > causing our DAGs to fail. It might be due to the BigQuery hook configs using > legacy sql as default, and the check operator class never has access to > change that configuration. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
