[jira] [Commented] (AIRFLOW-2467) Improve AirflowImporter warn message

2018-09-02 Thread Apache Spark (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601568#comment-16601568
 ] 

Apache Spark commented on AIRFLOW-2467:
---

User 'dan-sf' has created a pull request for this issue:
https://github.com/apache/incubator-airflow/pull/3361

> Improve AirflowImporter warn message
> 
>
> Key: AIRFLOW-2467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2467
> Project: Apache Airflow
>  Issue Type: Task
>Reporter: Dan Fowler
>Assignee: Dan Fowler
>Priority: Trivial
> Fix For: 1.10.0, 2.0.0
>
>
> Currently when importing modules from airflow.operators there is a warning 
> message that looks like this:
> {code:java}
> [2018-05-14 02:43:19,205] {{logging_mixin.py:84}} WARNING - 
> /usr/local/airflow/code/airflow/utils/helpers.py:351: DeprecationWarning: 
> Importing DummyOperator directly from  '/usr/local/airflow/code/airflow/operators/__init__.py'> has been deprecated. 
> Please import from ' '/usr/local/airflow/code/airflow/operators/__init__.py'>.[operator_module]' 
> instead. Support for direct imports will be dropped entirely in Airflow 2.0.
> {code}
> It's not that clear what the issue is, this message should be improved for 
> clarity. Most likely just use the module name rather than the module class's 
> str repr.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2467) Improve AirflowImporter warn message

2018-05-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AIRFLOW-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477077#comment-16477077
 ] 

ASF subversion and git services commented on AIRFLOW-2467:
--

Commit 802cbd9b9b497a3630aaaf2e6f656a98ffc7d550 in incubator-airflow's branch 
refs/heads/master from [~dfowler]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=802cbd9 ]

[AIRFLOW-2467][AIRFLOW-2] Update import direct warn message to use the module 
name

Closes #3361 from dan-sf/AIRFLOW-2467


> Improve AirflowImporter warn message
> 
>
> Key: AIRFLOW-2467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2467
> Project: Apache Airflow
>  Issue Type: Task
>Reporter: Dan Fowler
>Assignee: Dan Fowler
>Priority: Trivial
> Fix For: 1.10.0, 2.0.0
>
>
> Currently when importing modules from airflow.operators there is a warning 
> message that looks like this:
> {code:java}
> [2018-05-14 02:43:19,205] {{logging_mixin.py:84}} WARNING - 
> /usr/local/airflow/code/airflow/utils/helpers.py:351: DeprecationWarning: 
> Importing DummyOperator directly from  '/usr/local/airflow/code/airflow/operators/__init__.py'> has been deprecated. 
> Please import from ' '/usr/local/airflow/code/airflow/operators/__init__.py'>.[operator_module]' 
> instead. Support for direct imports will be dropped entirely in Airflow 2.0.
> {code}
> It's not that clear what the issue is, this message should be improved for 
> clarity. Most likely just use the module name rather than the module class's 
> str repr.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2467) Improve AirflowImporter warn message

2018-05-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AIRFLOW-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477076#comment-16477076
 ] 

ASF subversion and git services commented on AIRFLOW-2467:
--

Commit 802cbd9b9b497a3630aaaf2e6f656a98ffc7d550 in incubator-airflow's branch 
refs/heads/master from [~dfowler]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=802cbd9 ]

[AIRFLOW-2467][AIRFLOW-2] Update import direct warn message to use the module 
name

Closes #3361 from dan-sf/AIRFLOW-2467


> Improve AirflowImporter warn message
> 
>
> Key: AIRFLOW-2467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2467
> Project: Apache Airflow
>  Issue Type: Task
>Reporter: Dan Fowler
>Assignee: Dan Fowler
>Priority: Trivial
> Fix For: 1.10.0, 2.0.0
>
>
> Currently when importing modules from airflow.operators there is a warning 
> message that looks like this:
> {code:java}
> [2018-05-14 02:43:19,205] {{logging_mixin.py:84}} WARNING - 
> /usr/local/airflow/code/airflow/utils/helpers.py:351: DeprecationWarning: 
> Importing DummyOperator directly from  '/usr/local/airflow/code/airflow/operators/__init__.py'> has been deprecated. 
> Please import from ' '/usr/local/airflow/code/airflow/operators/__init__.py'>.[operator_module]' 
> instead. Support for direct imports will be dropped entirely in Airflow 2.0.
> {code}
> It's not that clear what the issue is, this message should be improved for 
> clarity. Most likely just use the module name rather than the module class's 
> str repr.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2467) Improve AirflowImporter warn message

2018-05-14 Thread Dan Fowler (JIRA)

[ 
https://issues.apache.org/jira/browse/AIRFLOW-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475319#comment-16475319
 ] 

Dan Fowler commented on AIRFLOW-2467:
-

Updated message:
{code:java}
[2018-05-15 04:37:30,434] {{logging_mixin.py:95}} WARNING - 
/usr/local/airflow/code/airflow/utils/helpers.py:346: DeprecationWarning: 
Importing 'DummyOperator' directly from 'airflow.operators' has been 
deprecated. Please import from 'airflow.operators.[operator_module]' instead. 
Support for direct imports will be dropped entirely in Airflow 2.0.
{code}

> Improve AirflowImporter warn message
> 
>
> Key: AIRFLOW-2467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2467
> Project: Apache Airflow
>  Issue Type: Task
>Reporter: Dan Fowler
>Assignee: Dan Fowler
>Priority: Trivial
>
> Currently when importing modules from airflow.operators there is a warning 
> message that looks like this:
> {code:java}
> [2018-05-14 02:43:19,205] {{logging_mixin.py:84}} WARNING - 
> /usr/local/airflow/code/airflow/utils/helpers.py:351: DeprecationWarning: 
> Importing DummyOperator directly from  '/usr/local/airflow/code/airflow/operators/__init__.py'> has been deprecated. 
> Please import from ' '/usr/local/airflow/code/airflow/operators/__init__.py'>.[operator_module]' 
> instead. Support for direct imports will be dropped entirely in Airflow 2.0.
> {code}
> It's not that clear what the issue is, this message should be improved for 
> clarity. Most likely just use the module name rather than the module class's 
> str repr.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-2467) Improve AirflowImporter warn message

2018-05-14 Thread Dan Fowler (JIRA)

[ 
https://issues.apache.org/jira/browse/AIRFLOW-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475317#comment-16475317
 ] 

Dan Fowler commented on AIRFLOW-2467:
-

PR: https://github.com/apache/incubator-airflow/pull/3361

> Improve AirflowImporter warn message
> 
>
> Key: AIRFLOW-2467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2467
> Project: Apache Airflow
>  Issue Type: Task
>Reporter: Dan Fowler
>Assignee: Dan Fowler
>Priority: Trivial
>
> Currently when importing modules from airflow.operators there is a warning 
> message that looks like this:
> {code:java}
> [2018-05-14 02:43:19,205] {{logging_mixin.py:84}} WARNING - 
> /usr/local/airflow/code/airflow/utils/helpers.py:351: DeprecationWarning: 
> Importing DummyOperator directly from  '/usr/local/airflow/code/airflow/operators/__init__.py'> has been deprecated. 
> Please import from ' '/usr/local/airflow/code/airflow/operators/__init__.py'>.[operator_module]' 
> instead. Support for direct imports will be dropped entirely in Airflow 2.0.
> {code}
> It's not that clear what the issue is, this message should be improved for 
> clarity. Most likely just use the module name rather than the module class's 
> str repr.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)