[jira] [Commented] (AIRFLOW-2701) Clean up dangling backfill dagrun
[
https://issues.apache.org/jira/browse/AIRFLOW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716084#comment-16716084
]
ASF GitHub Bot commented on AIRFLOW-2701:
-
feng-tao closed pull request #3562: [WIP][AIRFLOW-2701] Clean up backfill
dangling dagrun
URL: https://github.com/apache/incubator-airflow/pull/3562
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/jobs.py b/airflow/jobs.py
index 00ede5451d..8f19a67231 100644
--- a/airflow/jobs.py
+++ b/airflow/jobs.py
@@ -2008,6 +2008,7 @@ def __init__(
self.verbose = verbose
self.conf = conf
self.rerun_failed_tasks = rerun_failed_tasks
+self.dag_runs = []
super(BackfillJob, self).__init__(*args, **kwargs)
def _update_counters(self, ti_status):
@@ -2469,6 +2470,7 @@ def _execute_for_run_dates(self, run_dates, ti_status,
executor, pickle_id,
session=session)
if dag_run is None:
continue
+self.dag_runs.append(dag_run)
ti_status.active_runs.append(dag_run)
ti_status.to_run.update(tis_map or {})
@@ -2540,9 +2542,32 @@ def _execute(self, session=None):
self.dag_id
)
time.sleep(self.delay_on_limit_secs)
+
+except (KeyboardInterrupt, SystemExit):
+for dag_run in self.dag_runs:
+dag_run.refresh_from_db(session)
+make_transient(dag_run)
+
+# Check all the tasks which are not in success state.
+check_state = State.unfinished() + State.finished()
+check_state.remove(State.SUCCESS)
+
+unfinished_tasks = dag_run.get_task_instances(
+state=check_state,
+session=session
+)
+if unfinished_tasks:
+# if there are unfinished tasks and ctrl^c
+# set dag run state to failed
+for task in unfinished_tasks:
+task.set_state(State.FAILED, session)
+dag_run.state = State.FAILED
+else:
+dag_run.state = State.SUCCESS
+session.merge(dag_run)
finally:
-executor.end()
session.commit()
+executor.end()
self.log.info("Backfill done. Exiting.")
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clean up dangling backfill dagrun
> -
>
> Key: AIRFLOW-2701
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2701
> Project: Apache Airflow
> Issue Type: Bug
>Reporter: Tao Feng
>Assignee: Tao Feng
>Priority: Major
>
> When user tries to backfill and hit ctrol+9, the backfill dagrun will stay as
> running state. We should set it to failed if it has unfinished tasks.
>
> In our production, we see lots of these dangling backfill dagrun which will
> cause as one active dagrun in the next backfill. This may prevent user from
> backfilling if the max_active_run is reached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2701) Clean up dangling backfill dagrun
[
https://issues.apache.org/jira/browse/AIRFLOW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705064#comment-16705064
]
ASF GitHub Bot commented on AIRFLOW-2701:
-
feng-tao closed pull request #3562: [WIP][AIRFLOW-2701] Clean up backfill
dangling dagrun
URL: https://github.com/apache/incubator-airflow/pull/3562
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/jobs.py b/airflow/jobs.py
index 00ede5451d..8f19a67231 100644
--- a/airflow/jobs.py
+++ b/airflow/jobs.py
@@ -2008,6 +2008,7 @@ def __init__(
self.verbose = verbose
self.conf = conf
self.rerun_failed_tasks = rerun_failed_tasks
+self.dag_runs = []
super(BackfillJob, self).__init__(*args, **kwargs)
def _update_counters(self, ti_status):
@@ -2469,6 +2470,7 @@ def _execute_for_run_dates(self, run_dates, ti_status,
executor, pickle_id,
session=session)
if dag_run is None:
continue
+self.dag_runs.append(dag_run)
ti_status.active_runs.append(dag_run)
ti_status.to_run.update(tis_map or {})
@@ -2540,9 +2542,32 @@ def _execute(self, session=None):
self.dag_id
)
time.sleep(self.delay_on_limit_secs)
+
+except (KeyboardInterrupt, SystemExit):
+for dag_run in self.dag_runs:
+dag_run.refresh_from_db(session)
+make_transient(dag_run)
+
+# Check all the tasks which are not in success state.
+check_state = State.unfinished() + State.finished()
+check_state.remove(State.SUCCESS)
+
+unfinished_tasks = dag_run.get_task_instances(
+state=check_state,
+session=session
+)
+if unfinished_tasks:
+# if there are unfinished tasks and ctrl^c
+# set dag run state to failed
+for task in unfinished_tasks:
+task.set_state(State.FAILED, session)
+dag_run.state = State.FAILED
+else:
+dag_run.state = State.SUCCESS
+session.merge(dag_run)
finally:
-executor.end()
session.commit()
+executor.end()
self.log.info("Backfill done. Exiting.")
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clean up dangling backfill dagrun
> -
>
> Key: AIRFLOW-2701
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2701
> Project: Apache Airflow
> Issue Type: Bug
>Reporter: Tao Feng
>Assignee: Tao Feng
>Priority: Major
>
> When user tries to backfill and hit ctrol+9, the backfill dagrun will stay as
> running state. We should set it to failed if it has unfinished tasks.
>
> In our production, we see lots of these dangling backfill dagrun which will
> cause as one active dagrun in the next backfill. This may prevent user from
> backfilling if the max_active_run is reached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2701) Clean up dangling backfill dagrun
[
https://issues.apache.org/jira/browse/AIRFLOW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705066#comment-16705066
]
ASF GitHub Bot commented on AIRFLOW-2701:
-
feng-tao opened a new pull request #3562: [WIP][AIRFLOW-2701] Clean up backfill
dangling dagrun
URL: https://github.com/apache/incubator-airflow/pull/3562
Make sure you have checked _all_ steps below.
### JIRA
- [x] My PR addresses the following [Airflow
JIRA](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2701
- In case you are fixing a typo in the documentation you can prepend
your commit with \[AIRFLOW-XXX\], code changes always need a JIRA issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Still WIP.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Will add the tests after initial review.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clean up dangling backfill dagrun
> -
>
> Key: AIRFLOW-2701
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2701
> Project: Apache Airflow
> Issue Type: Bug
>Reporter: Tao Feng
>Assignee: Tao Feng
>Priority: Major
>
> When user tries to backfill and hit ctrol+9, the backfill dagrun will stay as
> running state. We should set it to failed if it has unfinished tasks.
>
> In our production, we see lots of these dangling backfill dagrun which will
> cause as one active dagrun in the next backfill. This may prevent user from
> backfilling if the max_active_run is reached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2701) Clean up dangling backfill dagrun
[ https://issues.apache.org/jira/browse/AIRFLOW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601356#comment-16601356 ] Apache Spark commented on AIRFLOW-2701: --- User 'feng-tao' has created a pull request for this issue: https://github.com/apache/incubator-airflow/pull/3562 > Clean up dangling backfill dagrun > - > > Key: AIRFLOW-2701 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2701 > Project: Apache Airflow > Issue Type: Bug >Reporter: Tao Feng >Assignee: Tao Feng >Priority: Major > > When user tries to backfill and hit ctrol+9, the backfill dagrun will stay as > running state. We should set it to failed if it has unfinished tasks. > > In our production, we see lots of these dangling backfill dagrun which will > cause as one active dagrun in the next backfill. This may prevent user from > backfilling if the max_active_run is reached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
