[jira] [Commented] (AIRFLOW-3151) FlaskAppBuilder 1.12.0 is installed by default and breaks www_rbac UI.

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638055#comment-16638055
 ] 

ASF GitHub Bot commented on AIRFLOW-3151:
-

ashb closed pull request #3996: [AIRFLOW-3151] Pin FlaskAppBuilder 1.11.1 in 
setup.py
URL: https://github.com/apache/incubator-airflow/pull/3996
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/setup.py b/setup.py
index af8b1958f7..d44bed6223 100644
--- a/setup.py
+++ b/setup.py
@@ -274,7 +274,7 @@ def do_setup():
 'croniter>=0.3.17, <0.4',
 'dill>=0.2.2, <0.3',
 'flask>=0.12.4, <0.13',
-'flask-appbuilder>=1.11.1, <2.0.0',
+'flask-appbuilder==1.11.1',
 'flask-admin==1.4.1',
 'flask-caching>=1.3.3, <1.4.0',
 'flask-login==0.2.11',


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FlaskAppBuilder 1.12.0 is installed by default and breaks www_rbac UI.
> --
>
> Key: AIRFLOW-3151
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3151
> Project: Apache Airflow
>  Issue Type: Bug
>Reporter: Olivier Simard-Morissette
>Priority: Major
> Attachments: Screen Shot 2018-10-03 at 5.11.49 PM.png
>
>
> A new version of FlaskAppBuilder was released 12 hours ago or so. The 
> setup.py in v1-10-stable pins the version of flask-appbuilder to be greater 
> than 1.11.1. Version 1.12.0 breaks the new UI (screenshot attached). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AIRFLOW-3151) FlaskAppBuilder 1.12.0 is installed by default and breaks www_rbac UI.

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637526#comment-16637526
 ] 

ASF GitHub Bot commented on AIRFLOW-3151:
-

oliviersm199 opened a new pull request #3996: [AIRFLOW-3151] Pin 
FlaskAppBuilder 1.11.1 in setup.py
URL: https://github.com/apache/incubator-airflow/pull/3996
 
 
   ### Jira
   
   My PR addresses the following 
[AIRFLOW-3151](https://issues.apache.org/jira/browse/AIRFLOW-3151)
   
   ### Description
   
   The PR pins the version of FlaskAppBuilder to 1.11.1 since the new release 
1.12.0 breaks the www_rbac UI. 
   
   ### Tests
   
   Doesn't require additional tests because not adding any code to source, just 
pinning flaskappbuilder like flask-admin is pinned. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FlaskAppBuilder 1.12.0 is installed by default and breaks www_rbac UI.
> --
>
> Key: AIRFLOW-3151
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3151
> Project: Apache Airflow
>  Issue Type: Bug
>Reporter: Olivier Simard-Morissette
>Priority: Major
> Attachments: Screen Shot 2018-10-03 at 5.11.49 PM.png
>
>
> A new version of FlaskAppBuilder was released 12 hours ago or so. The 
> setup.py in v1-10-stable pins the version of flask-appbuilder to be greater 
> than 1.11.1. Version 1.12.0 breaks the new UI (screenshot attached). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)