[GitHub] [ambari-metrics] arshadmohammad commented on pull request #119: AMBARI-25963: Metrics metadata sync problem, accessing metrics which got created though other collector throws NPE

2023-07-12 Thread via GitHub


arshadmohammad commented on PR #119:
URL: https://github.com/apache/ambari-metrics/pull/119#issuecomment-1633037326

   > Can you squash the commit so that jira number will reflect..? And can you 
raise for branch-2.7 also.
   squashed the commits, raised PR for branch-2.7
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org
For additional commands, e-mail: commits-h...@ambari.apache.org



[GitHub] [ambari-metrics] arshadmohammad commented on pull request #119: AMBARI-25963: Metrics metadata sync problem, accessing metrics which got created though other collector throws NPE

2023-07-03 Thread via GitHub


arshadmohammad commented on PR #119:
URL: https://github.com/apache/ambari-metrics/pull/119#issuecomment-1618971168

   > is it possible to write a UT? otherwise changes look good
   
   Thanks @virajjasani  for review. Added validation for this issue scenario in 
an existing test case TestMetadataSync#testRefreshMetadataOnWrite


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org
For additional commands, e-mail: commits-h...@ambari.apache.org