Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
xijunmu commented on PR #135: URL: https://github.com/apache/ambari-metrics/pull/135#issuecomment-2401205792 @virajjasani @vishalsuvagia @JiaLiangC could somebody review again？ If CI wants to pass, it needs to be installed. I test on rockylinux8 >>> yum install python3-distro python3-kerberos -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
xijunmu commented on PR #135: URL: https://github.com/apache/ambari-metrics/pull/135#issuecomment-2401183208 @sandeep318kumar I resubmitted the PR and test passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
xijunmu commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2378264100 @sandeep318kumar nice work！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
sandeep318kumar commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2376762013 @xijunmu I have resolved these build failures in this PR: https://github.com/apache/ambari-metrics/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
xijunmu commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2376421247 > @xijunmu CI has failed for this. Can you check and update? @sandeep318kumar I checked the code and found that the CI failure was not caused by this PR It is caused by some Python libraries .. [INFO] --- exec:1.2.1:exec (python-test) @ ambari-metrics-host-monitoring --- Running tests testApplicationMetricMap (TestApplicationMetricMap.TestApplicationMetricMap) ... ok testEmptyMapReturnNone (TestApplicationMetricMap.TestApplicationMetricMap) ... ok testFlattenAndClear (TestApplicationMetricMap.TestApplicationMetricMap) ... ok test_flatten_and_align_values_by_minute_mark (TestApplicationMetricMap.TestApplicationMetricMap) ... ok TestEmitter (unittest.loader._FailedTest) ... ERROR TestMetricCollector (unittest.loader._FailedTest) ... ERROR testCombinedDiskUsage (TestHostInfo.TestHostInfo) ... ok testCpuTimes (TestHostInfo.TestHostInfo) ... ok testDiskIOCounters (TestHostInfo.TestHostInfo) ... ok testMemInfo (TestHostInfo.TestHostInfo) ... ERROR testProcessInfo (TestHostInfo.TestHostInfo) ... ok test_get_disk_io_counters_per_disk (TestHostInfo.TestHostInfo) ... ok test_get_network_info_skip_by_pattern (TestHostInfo.TestHostInfo) ... ok test_get_network_info_skip_by_pattern_and_virtual (TestHostInfo.TestHostInfo) ... ok test_get_network_info_virtual_devices (TestHostInfo.TestHostInfo) ... ok test_get_virtual_network_interfaces (TestHostInfo.TestHostInfo) ... ok == ERROR: TestEmitter (unittest.loader._FailedTest) -- ImportError: Failed to import test module: TestEmitter Traceback (most recent call last): File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py", line 27, in import kerberos ModuleNotFoundError: No module named 'kerberos' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 153, in loadTestsFromName module = __import__(module_name) File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py", line 29, in from spnego_kerberos_auth import SPNEGOKerberosAuth File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py", line 29, in from resource_monitoring.core import krberr as kerberos ModuleNotFoundError: No module named 'resource_monitoring' == ERROR: TestMetricCollector (unittest.loader._FailedTest) -- ImportError: Failed to import test module: TestMetricCollector Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 153, in loadTestsFromName module = __import__(module_name) File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestMetricCollector.py", line 25, in from core.metric_collector import MetricsCollector File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/metric_collector.py", line 23, in from resource_monitoring.core.event_definition import HostMetricCollectEvent, ProcessMetricCollectEvent ModuleNotFoundError: No module named 'resource_monitoring' == ERROR: testMemInfo (TestHostInfo.TestHostInfo) -- Traceback (most recent call last): File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/mock/mock.py", line 1199, in patched return func(*args, **keywargs) File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py", line 82, in testMemInfo mem = hostinfo.get_mem_info() File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py", line 125, in get_mem_info 'mem_total': bytes2kilobytes(mem_total) if mem_total else 0, File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py", line 122, in bytes2kilobytes = lambda x: x / 1024 TypeError: unsupported operand type(s) for /: 'MagicMock' and 'int' -- Ran 16 tests in 0.063s FAILED (errors=3) -- Failed tests: ERROR: TestEmitter (unittest.loader._FailedTest) ---
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
sandeep318kumar commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2375261431 @xijunmu CI has failed for this. Can you check and update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
xijunmu commented on code in PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#discussion_r1770747416 ## ambari-metrics-common/pom.xml: ## @@ -103,7 +103,6 @@ com.google.guava guava - 28.0-jre Review Comment: I think the parent pom's guava version should be used, so I deleted the separate version in here ## ambari-metrics-flume-sink/pom.xml: ## @@ -141,7 +141,6 @@ limitations under the License. com.google.guava guava - 18.0 Review Comment: Same as the previous comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
virajjasani commented on code in PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#discussion_r1770651236 ## pom.xml: ## @@ -38,21 +38,21 @@ python3 >= 3.0 python3 (>= 3.0) 2.0.0 -3.5.9 -2.8.1 -5.1.2 -2.4.13 +3.7.2 +2.8.2 +5.1.3 +2.4.17 4.2.0 3.12.0 - http://repo.bigtop.apache.org.s3.amazonaws.com/bigtop-stack-binary/3.2.0/centos-7/x86_64/hbase-2.4.13-bin.tar.gz -hbase-2.4.13 - http://repo.bigtop.apache.org.s3.amazonaws.com/bigtop-stack-binary/3.2.0/centos-7/x86_64/hadoop-3.3.4.tar.gz -hadoop-3.3.4 -3.3.4 + https://archive.apache.org/dist/hbase/2.4.17/hbase-2.4.17-bin.tar.gz +hbase-2.4.17 + https://archive.apache.org/dist/hadoop/common/hadoop-3.3.6/hadoop-3.3.6.tar.gz +hadoop-3.3.6 +3.3.6 Review Comment: Nice one, I think we should bump in ambari also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
vishalsuvagia commented on code in PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#discussion_r1770602582 ## pom.xml: ## @@ -38,21 +38,21 @@ python3 >= 3.0 python3 (>= 3.0) 2.0.0 -3.5.9 -2.8.1 -5.1.2 -2.4.13 +3.7.2 +2.8.2 +5.1.3 +2.4.17 4.2.0 3.12.0 - http://repo.bigtop.apache.org.s3.amazonaws.com/bigtop-stack-binary/3.2.0/centos-7/x86_64/hbase-2.4.13-bin.tar.gz -hbase-2.4.13 - http://repo.bigtop.apache.org.s3.amazonaws.com/bigtop-stack-binary/3.2.0/centos-7/x86_64/hadoop-3.3.4.tar.gz -hadoop-3.3.4 -3.3.4 + https://archive.apache.org/dist/hbase/2.4.17/hbase-2.4.17-bin.tar.gz +hbase-2.4.17 + https://archive.apache.org/dist/hadoop/common/hadoop-3.3.6/hadoop-3.3.6.tar.gz +hadoop-3.3.6 +3.3.6 Review Comment: should we have the hadoop version in sync with ambari where it is 3.3.4 currently ? or bump up the version in ambari as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
vishalsuvagia commented on code in PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#discussion_r1770602220 ## ambari-metrics-flume-sink/pom.xml: ## @@ -141,7 +141,6 @@ limitations under the License. com.google.guava guava - 18.0 Review Comment: can you add a version here as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
vishalsuvagia commented on code in PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#discussion_r1770602202 ## ambari-metrics-common/pom.xml: ## @@ -103,7 +103,6 @@ com.google.guava guava - 28.0-jre Review Comment: it would be good to provide a version here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
virajjasani commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2345090922 Yes I was thinking about the same. It's time to release 3.1. These are some of the good fixes that we should release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
JiaLiangC commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2345088615 > I am not sure what release version we need to use while closing Jira related to metrics repo. Indeed, it's difficult to determine the version in which the issue will be resolved. Ideally, Ambari Metrics should maintain version consistency with Ambari for better management, but Metrics has already released version 3.0... What do you think about 3.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
virajjasani commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2345056892 I am not sure what release version we need to use while closing Jira related to metrics repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
JiaLiangC commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2345046664 @virajjasani Sorry for the late reply. It's strange that I didn't receive any email notifications for Ambari Metrics PRs or mentions. This PR corrects the download URLs for Hadoop binaries, etc. Excluding the Hadoop and HBase dependencies from Phoenix and explicitly declaring them is indeed more elegant. LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
virajjasani commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2339764740 +1, @JiaLiangC any review from your side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
Re: [PR] AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem [ambari-metrics]
virajjasani commented on PR #131: URL: https://github.com/apache/ambari-metrics/pull/131#issuecomment-2338580421 Nice one, this looks good. For those exclusions that you commented, we can remove them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
