Re: [PR] [AMORO-3389][improvement]support add comment to mixed_hive table [amoro]

2025-01-20 Thread via GitHub 


zhoujinsong merged PR #3389:
URL: https://github.com/apache/amoro/pull/3389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [AMORO-3389][improvement]support add comment to mixed_hive table [amoro]

2025-01-14 Thread via GitHub 


Aireed commented on PR #3389:
URL: https://github.com/apache/amoro/pull/3389#issuecomment-2591553756

   > Thanks for the contribution. Have you tested the change, or you may better 
add a unit test case for it.
   
   thanks for your review. i have added uts, PTAK again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [AMORO-3389][improvement]support add comment to mixed_hive table [amoro]

2025-01-09 Thread via GitHub 


zhoujinsong commented on PR #3389:
URL: https://github.com/apache/amoro/pull/3389#issuecomment-2581669191

   Thanks for the contribution.
   Have you tested the change, or you may better add a unit test case for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org