[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

Github user tliron commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 OK. So I guess you don't want to change the imports in `/tests/`? On Wed, Nov 8, 2017 at 4:32 PM, Maxim Orlov wrote: > so, i think we're

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

Github user mxmrlv commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 so, i think we're ready ---

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

Github user mxmrlv commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 OK, np just wanted to make sure we're on the same page... ---

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

Github user tliron commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 Still, I don't see why it should be in `aria/__init__.py` and be always activated. I think it should be in activated only for a module that specifically is using ruamel. It would

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

Github user mxmrlv commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 This code only runs once, it doesn't provide with a patched up ruamel, it patched the loading mechanism...so loading should work everywhere, as long as the code was run... ---

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

Github user tliron commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 @mxmrlv You didn't address these: 1. Let's move this to `from aria.utils.yaml import yaml`. I don't think the aria `__init__.py` is the right place for this. 2. Let's go over

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

Github user mxmrlv commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 @tliron any additional comments? or should i merge? ---

[GitHub] incubator-ariatosca issue #199: ARIA-392 Failing to load ruamel.yaml

Github user asfgit commented on the issue: https://github.com/apache/incubator-ariatosca/pull/199 Can one of the admins verify this patch? ---