atlas git commit: ATLAS-2531 : Lineage display is causing 'Maximum call stack size reached' in underscore.js
Repository: atlas Updated Branches: refs/heads/branch-0.8 6e81a6bca -> e50509255 ATLAS-2531 : Lineage display is causing 'Maximum call stack size reached' in underscore.js Project: http://git-wip-us.apache.org/repos/asf/atlas/repo Commit: http://git-wip-us.apache.org/repos/asf/atlas/commit/e5050925 Tree: http://git-wip-us.apache.org/repos/asf/atlas/tree/e5050925 Diff: http://git-wip-us.apache.org/repos/asf/atlas/diff/e5050925 Branch: refs/heads/branch-0.8 Commit: e50509255e763390b174aa142cef2e22d0e96ac6 Parents: 6e81a6b Author: kevalbhatt Authored: Mon Apr 9 13:31:40 2018 +0530 Committer: kevalbhatt Committed: Mon Apr 9 15:05:54 2018 +0530 -- .../public/js/views/graph/LineageLayoutView.js | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) -- http://git-wip-us.apache.org/repos/asf/atlas/blob/e5050925/dashboardv2/public/js/views/graph/LineageLayoutView.js -- diff --git a/dashboardv2/public/js/views/graph/LineageLayoutView.js b/dashboardv2/public/js/views/graph/LineageLayoutView.js index fcf0c39..bb5d52e 100644 --- a/dashboardv2/public/js/views/graph/LineageLayoutView.js +++ b/dashboardv2/public/js/views/graph/LineageLayoutView.js @@ -160,13 +160,17 @@ define(['require', nodeFound = _.where(relations, { 'fromEntityId': guid }); if (nodeFound.length) { _.each(nodeFound, function(node) { -that.fromToObj[node.toEntityId]['isLineage'] = false; -var styleObj = { -fill: 'none', -stroke: '#fb4200' +if (!node["traversed"]) { +node["traversed"] = true; +that.fromToObj[node.toEntityId]['isLineage'] = false; +var styleObj = { +fill: 'none', +stroke: '#fb4200', +width: 2 +} +that.g.setEdge(node.fromEntityId, node.toEntityId, { 'arrowhead': "arrowPoint", lineInterpolate: 'basis', "style": "fill:" + styleObj.fill + ";stroke:" + styleObj.stroke + ";stroke-width:" + styleObj.width + "", 'styleObj': styleObj }); +that.checkForLineageOrImpactFlag(relations, node.toEntityId); } -that.g.setEdge(node.fromEntityId, node.toEntityId, { 'arrowhead': "arrowPoint", lineInterpolate: 'basis', "style": "fill:" + styleObj.fill + ";stroke:" + styleObj.stroke + "", 'styleObj': styleObj }); -that.checkForLineageOrImpactFlag(relations, node.toEntityId); }); } },
atlas git commit: ATLAS-2531 : Lineage display is causing 'Maximum call stack size reached' in underscore.js
Repository: atlas Updated Branches: refs/heads/master dc71d3d42 -> cd686f6fc ATLAS-2531 : Lineage display is causing 'Maximum call stack size reached' in underscore.js Project: http://git-wip-us.apache.org/repos/asf/atlas/repo Commit: http://git-wip-us.apache.org/repos/asf/atlas/commit/cd686f6f Tree: http://git-wip-us.apache.org/repos/asf/atlas/tree/cd686f6f Diff: http://git-wip-us.apache.org/repos/asf/atlas/diff/cd686f6f Branch: refs/heads/master Commit: cd686f6fc97cf2de4fe0c152476444d3544e4dd1 Parents: dc71d3d Author: kevalbhatt Authored: Mon Apr 9 13:31:40 2018 +0530 Committer: kevalbhatt Committed: Mon Apr 9 15:04:47 2018 +0530 -- .../public/js/views/graph/LineageLayoutView.js | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) -- http://git-wip-us.apache.org/repos/asf/atlas/blob/cd686f6f/dashboardv2/public/js/views/graph/LineageLayoutView.js -- diff --git a/dashboardv2/public/js/views/graph/LineageLayoutView.js b/dashboardv2/public/js/views/graph/LineageLayoutView.js index f17de83..25e7120 100644 --- a/dashboardv2/public/js/views/graph/LineageLayoutView.js +++ b/dashboardv2/public/js/views/graph/LineageLayoutView.js @@ -160,13 +160,17 @@ define(['require', nodeFound = _.where(relations, { 'fromEntityId': guid }); if (nodeFound.length) { _.each(nodeFound, function(node) { -that.fromToObj[node.toEntityId]['isLineage'] = false; -var styleObj = { -fill: 'none', -stroke: '#fb4200' +if (!node["traversed"]) { +node["traversed"] = true; +that.fromToObj[node.toEntityId]['isLineage'] = false; +var styleObj = { +fill: 'none', +stroke: '#fb4200', +width: 2 +} +that.g.setEdge(node.fromEntityId, node.toEntityId, { 'arrowhead': "arrowPoint", lineInterpolate: 'basis', "style": "fill:" + styleObj.fill + ";stroke:" + styleObj.stroke + ";stroke-width:" + styleObj.width + "", 'styleObj': styleObj }); +that.checkForLineageOrImpactFlag(relations, node.toEntityId); } -that.g.setEdge(node.fromEntityId, node.toEntityId, { 'arrowhead': "arrowPoint", lineInterpolate: 'basis', "style": "fill:" + styleObj.fill + ";stroke:" + styleObj.stroke + "", 'styleObj': styleObj }); -that.checkForLineageOrImpactFlag(relations, node.toEntityId); }); } },