[jira] [Commented] (BEAM-3257) Migrate Python Jenkins PreCommits to Gradle

2018-04-11 Thread Scott Wegner (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434205#comment-16434205
 ] 

Scott Wegner commented on BEAM-3257:


This is now done: https://github.com/apache/beam/pull/5006

> Migrate Python Jenkins PreCommits to Gradle
> ---
>
> Key: BEAM-3257
> URL: https://issues.apache.org/jira/browse/BEAM-3257
> Project: Beam
>  Issue Type: Sub-task
>  Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Udi Meiri
>Priority: Major
> Fix For: Not applicable
>
>  Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Code is here: 
> https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_beam_PreCommit_Python_MavenInstall.groovy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3257) Migrate Python Jenkins PreCommits to Gradle

2018-01-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323287#comment-16323287
 ] 

ASF GitHub Bot commented on BEAM-3257:
--

kennknowles closed pull request #4381: [BEAM-3257] Move sdist execution to 
execution phase instead of configuration in Gradle
URL: https://github.com/apache/beam/pull/4381
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/python/build.gradle b/sdks/python/build.gradle
index 7d82afa9220..484adb3629e 100644
--- a/sdks/python/build.gradle
+++ b/sdks/python/build.gradle
@@ -35,8 +35,10 @@ task setupTest {
 }
 
 task sdist {
-  exec {
-commandLine 'python', 'setup.py', 'sdist', '--formats', 'zip,gztar', 
'--dist-dir', project.buildDir
+  doLast {
+exec {
+  commandLine 'python', 'setup.py', 'sdist', '--formats', 'zip,gztar', 
'--dist-dir', project.buildDir
+}
   }
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Migrate Python Jenkins PreCommits to Gradle
> ---
>
> Key: BEAM-3257
> URL: https://issues.apache.org/jira/browse/BEAM-3257
> Project: Beam
>  Issue Type: Sub-task
>  Components: build-system, testing
>Reporter: Luke Cwik
>
> Code is here: 
> https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_beam_PreCommit_Python_MavenInstall.groovy



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)