[jira] [Commented] (BEAM-3637) HBaseIOTest methods do not clean up tables

2018-02-12 Thread Alexey Romanenko (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361056#comment-16361056
 ] 

Alexey Romanenko commented on BEAM-3637:


Disabling and truncating/deleting is quite expensive operation on mini-cluster. 
So I agree that using uniq table name would be better in this case.

> HBaseIOTest methods do not clean up tables
> --
>
> Key: BEAM-3637
> URL: https://issues.apache.org/jira/browse/BEAM-3637
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Kenneth Knowles
>Assignee: Alexey Romanenko
>Priority: Minor
>  Labels: beginner, newbie, starter
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3637) HBaseIOTest methods do not clean up tables

2018-02-08 Thread Kenneth Knowles (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356999#comment-16356999
 ] 

Kenneth Knowles commented on BEAM-3637:
---

Yea, if it is a fake that will be dropped anyhow it might not matter to drop 
the tables one at a time. But maybe another way is to just make a pseudorandom 
suffix on the table name. The fanciest might be {{@Rule TemporaryHBaseTable}}. 
Since it is fixed and pretty stable I set the priority low. We could leave it 
for a starter ticket if someone wanted to just get into the codebase.

> HBaseIOTest methods do not clean up tables
> --
>
> Key: BEAM-3637
> URL: https://issues.apache.org/jira/browse/BEAM-3637
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Kenneth Knowles
>Assignee: Alexey Romanenko
>Priority: Minor
>  Labels: beginner, newbie, starter
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3637) HBaseIOTest methods do not clean up tables

2018-02-08 Thread JIRA

[ 
https://issues.apache.org/jira/browse/BEAM-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356710#comment-16356710
 ] 

Ismaël Mejía commented on BEAM-3637:


Ok just reassigned to Alexey given that he knows well HBase that should be an 
easy one. Only worry here is that deleting the tables will make the tests 
longer, but we'll see.

> HBaseIOTest methods do not clean up tables
> --
>
> Key: BEAM-3637
> URL: https://issues.apache.org/jira/browse/BEAM-3637
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Kenneth Knowles
>Assignee: Alexey Romanenko
>Priority: Minor
>  Labels: beginner, newbie, starter
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3637) HBaseIOTest methods do not clean up tables

2018-02-07 Thread JIRA

[ 
https://issues.apache.org/jira/browse/BEAM-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355721#comment-16355721
 ] 

Jean-Baptiste Onofré commented on BEAM-3637:


Yup, I meant that a first fix has been done. Now we need a better one.

> HBaseIOTest methods do not clean up tables
> --
>
> Key: BEAM-3637
> URL: https://issues.apache.org/jira/browse/BEAM-3637
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Kenneth Knowles
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>  Labels: beginner, newbie, starter
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3637) HBaseIOTest methods do not clean up tables

2018-02-07 Thread Kenneth Knowles (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355683#comment-16355683
 ] 

Kenneth Knowles commented on BEAM-3637:
---

Actually what I did was split the tests that didn't have stable names. This 
ticket is still valid - the tables created in each test method have different 
names otherwise they fail. It would be a little nicer if they dropped the table.

> HBaseIOTest methods do not clean up tables
> --
>
> Key: BEAM-3637
> URL: https://issues.apache.org/jira/browse/BEAM-3637
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Kenneth Knowles
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>  Labels: beginner, newbie, starter
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3637) HBaseIOTest methods do not clean up tables

2018-02-07 Thread JIRA

[ 
https://issues.apache.org/jira/browse/BEAM-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355679#comment-16355679
 ] 

Jean-Baptiste Onofré commented on BEAM-3637:


Actually, it's already merged as part of Kenn's last PR.

> HBaseIOTest methods do not clean up tables
> --
>
> Key: BEAM-3637
> URL: https://issues.apache.org/jira/browse/BEAM-3637
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Kenneth Knowles
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>  Labels: beginner, newbie, starter
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)