[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444389#comment-16444389 ] Łukasz Gajowy commented on BEAM-3942: - fyi: migrating to gradle on "the PerfKitBenchmarker side" is happening here: https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1648 > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > Time Spent: 12h 20m > Remaining Estimate: 0h > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443127#comment-16443127 ] Łukasz Gajowy commented on BEAM-3942: - Sure, I'll gladly do that. :) > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > Time Spent: 12h 20m > Remaining Estimate: 0h > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443001#comment-16443001 ] Scott Wegner commented on BEAM-3942: I've added a sub-task for updating website documentation. [~ŁukaszG] would you mind filling in the new gradle commands? > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > Time Spent: 12h 20m > Remaining Estimate: 0h > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434304#comment-16434304 ] Łukasz Gajowy commented on BEAM-3942: - I think it is. The PR is currently being reveiwed. After it is merged another PR must be done to PerfKitBenchmarker (as descirbed above) to be able to drop maven (perfkit uses beam's mvn commands). > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > Time Spent: 7h 10m > Remaining Estimate: 0h > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434189#comment-16434189 ] Scott Wegner commented on BEAM-3942: How is this going? Is this task a blocker for the Gradle migration? > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > Time Spent: 7h 10m > Remaining Estimate: 0h > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420770#comment-16420770 ] Łukasz Gajowy commented on BEAM-3942: - Thanks! I'll be reaching him on tuesday. > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420757#comment-16420757 ] Luke Cwik commented on BEAM-3942: - [asaksena|https://github.com/asaksena] has volunteered to help review stuff during our fixit promptly PerfkitBenchmarker. > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420716#comment-16420716 ] Luke Cwik commented on BEAM-3942: - Reached out to PerfkitBenchmarker folks here: https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/issues/1617 > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420347#comment-16420347 ] Łukasz Gajowy commented on BEAM-3942: - FYI #2 (just to track things more easily): currently we are not able to run any IOITs successfully due to this issue. I already reached [~tgroh] and we agreed that the issue will be fixed or reverted until tuesday, but for now it's a blocker. > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419786#comment-16419786 ] Luke Cwik commented on BEAM-3942: - I think it makes sense for a few people to work together to target some of these bigger migrations like perfkit and would prefer to target option 1 that you suggest. I think co-ordination with GoogleCloudPlatform (owners of PerfkitBenchmarker) should be reasonable to do within a single day effort. > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419445#comment-16419445 ] Łukasz Gajowy commented on BEAM-3942: - CC: [~reuvenlax] > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419409#comment-16419409 ] Łukasz Gajowy commented on BEAM-3942: - Also, my experience with perfikt is that, their community is responsive. But this obviously doesn't solve the fact that the effort needs to be coordinated between beam and perfkit project maintainers if we want to migrate in one day. > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419390#comment-16419390 ] Łukasz Gajowy commented on BEAM-3942: - Sure, sorry for being so laconic. This command runs perfkit with all the command line arguments it needs. After that perfkit downloads beam repository, performs the "setup" phase (kubernetes and so on) and then, using the above mentioned arguments it, constructs *maven* commands to build beam and run the tests. Build is optional but still possible - "beamPrebuilt" flag turns it on/off. If we want to leave this flow as is, we need to modify this perfkit class to construct gradle commands instead of maven ones: [https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/beam_benchmark_helper.py ]Please notice that the code you mentioned is only for running ITs manually. Jenkins jobs run Perfkit directly: [https://github.com/apache/beam/blob/397688a62b1f9f0f9840a43ed4ad1a59ba77b981/.test-infra/jenkins/common_job_properties.groovy#L311] As for modifying perfkit - I see two ways of doing this: 1. Fully drop maven and use gradle instead at once. 2. Add logic to perfkit to support both maven and gradle for some time. This is in case of obstacles preventing us from migrating to gradle in one day but will take more time and energy. Also, please note that for both ways, Perfkit needs to "know" what gradle command to construct to run the tests. This is why I planned to start with submitting PR to beam and then modify perfkit accordingly. WDYT of all this? > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419215#comment-16419215 ] Luke Cwik commented on BEAM-3942: - Can you provide more details as to why an external project needs to change? It seems like we just invoke perfkitbenchmarker with maven-exec (treating it like an executable) for example here: https://github.com/apache/beam/blob/b6e95a0dc3f78b4961003d44cbb43456faef60c1/sdks/java/io/file-based-io-tests/pom.xml#L101 > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419033#comment-16419033 ] Łukasz Gajowy commented on BEAM-3942: - Thanks! FYI: Despite introducing necessary changes in beam's gradle scripts we will need a person from PerfkitBenchmarker project to merge changes in perfkit too. Currently perfkit uses maven to build and run IOITs, so this must be changed too. I'll submit all necessary PRs bot to beam and perfkit. > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Sub-task > Components: testing >Reporter: Chamikara Jayalath >Assignee: Łukasz Gajowy >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3942) Update performance testing framework to use Gradle.
[ https://issues.apache.org/jira/browse/BEAM-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414785#comment-16414785 ] Chamikara Jayalath commented on BEAM-3942: -- Assigning to Łukasz who has a PoC for this. > Update performance testing framework to use Gradle. > --- > > Key: BEAM-3942 > URL: https://issues.apache.org/jira/browse/BEAM-3942 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Chamikara Jayalath >Priority: Major > > This requires performing updates to PerfKitBenchmarker and Beam so that we > can execute performance tests using Gradle. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
