[jira] [Work logged] (BEAM-3847) Remove the rich wrapper from EnvironmentManager
[
https://issues.apache.org/jira/browse/BEAM-3847?focusedWorklogId=82041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82041
]
ASF GitHub Bot logged work on BEAM-3847:
Author: ASF GitHub Bot
Created on: 19/Mar/18 21:03
Start Date: 19/Mar/18 21:03
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #4866: [BEAM-3847] Use
InstructionRequestHandler in RemoteEnvironment
URL: https://github.com/apache/beam/pull/4866
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/RemoteEnvironment.java
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/RemoteEnvironment.java
index 0c72b374ecc..d9a3ea5d764 100644
---
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/RemoteEnvironment.java
+++
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/RemoteEnvironment.java
@@ -19,21 +19,17 @@
package org.apache.beam.runners.fnexecution.environment;
import org.apache.beam.model.pipeline.v1.RunnerApi.Environment;
-import org.apache.beam.runners.fnexecution.control.SdkHarnessClient;
+import org.apache.beam.runners.fnexecution.control.InstructionRequestHandler;
/**
- * A handle to an available remote {@link Environment}. This environment is
connected to a
- * Fn API Control service, and the associated client is available via {@link
#getClient()}.
+ * A handle to an available remote {@link Environment}. This environment is
connected to a Fn API
+ * Control service, and the associated client is available via {@link
+ * #getInstructionRequestHandler()}.
*/
interface RemoteEnvironment extends AutoCloseable {
- /**
- * Return the environment that the remote handles.
- */
+ /** Return the environment that the remote handles. */
Environment getEnvironment();
- /**
- * Return an {@link SdkHarnessClient} which can communicate with an instance
of the environment.
- */
- SdkHarnessClient getClient();
+ /** Return an {@link InstructionRequestHandler} which can communicate with
the environment. */
+ InstructionRequestHandler getInstructionRequestHandler();
}
-
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 82041)
Time Spent: 50m (was: 40m)
> Remove the rich wrapper from EnvironmentManager
> ---
>
> Key: BEAM-3847
> URL: https://issues.apache.org/jira/browse/BEAM-3847
> Project: Beam
> Issue Type: Bug
> Components: runner-core
>Reporter: Thomas Groh
>Assignee: Thomas Groh
>Priority: Major
> Labels: portability
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The current wrapper couples the rich implementation of the Control Plane
> instead of wrapping the simplest possible wrapper. Using the simple client is
> preferable, as it permits more sophisticated users to enrich the client
> directly, and the additional complexity required for other users is almost
> nonexistent (it consists of one additional call, with access to a
> DataService, and can be wrapped around an EnvironmentManager wrapper)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3847) Remove the rich wrapper from EnvironmentManager
[ https://issues.apache.org/jira/browse/BEAM-3847?focusedWorklogId=82022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82022 ] ASF GitHub Bot logged work on BEAM-3847: Author: ASF GitHub Bot Created on: 19/Mar/18 20:32 Start Date: 19/Mar/18 20:32 Worklog Time Spent: 10m Work Description: axelmagn commented on issue #4866: [BEAM-3847] Use InstructionRequestHandler in RemoteEnvironment URL: https://github.com/apache/beam/pull/4866#issuecomment-374364113 cc: @bsidhom this will change some of the implementation details around how we instantiate a client, but I think it's the right move. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 82022) Time Spent: 40m (was: 0.5h) > Remove the rich wrapper from EnvironmentManager > --- > > Key: BEAM-3847 > URL: https://issues.apache.org/jira/browse/BEAM-3847 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Thomas Groh >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 40m > Remaining Estimate: 0h > > The current wrapper couples the rich implementation of the Control Plane > instead of wrapping the simplest possible wrapper. Using the simple client is > preferable, as it permits more sophisticated users to enrich the client > directly, and the additional complexity required for other users is almost > nonexistent (it consists of one additional call, with access to a > DataService, and can be wrapped around an EnvironmentManager wrapper) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3847) Remove the rich wrapper from EnvironmentManager
[ https://issues.apache.org/jira/browse/BEAM-3847?focusedWorklogId=82021&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82021 ] ASF GitHub Bot logged work on BEAM-3847: Author: ASF GitHub Bot Created on: 19/Mar/18 20:32 Start Date: 19/Mar/18 20:32 Worklog Time Spent: 10m Work Description: axelmagn commented on issue #4866: [BEAM-3847] Use InstructionRequestHandler in RemoteEnvironment URL: https://github.com/apache/beam/pull/4866#issuecomment-374363843 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 82021) Time Spent: 0.5h (was: 20m) > Remove the rich wrapper from EnvironmentManager > --- > > Key: BEAM-3847 > URL: https://issues.apache.org/jira/browse/BEAM-3847 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Thomas Groh >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 0.5h > Remaining Estimate: 0h > > The current wrapper couples the rich implementation of the Control Plane > instead of wrapping the simplest possible wrapper. Using the simple client is > preferable, as it permits more sophisticated users to enrich the client > directly, and the additional complexity required for other users is almost > nonexistent (it consists of one additional call, with access to a > DataService, and can be wrapped around an EnvironmentManager wrapper) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3847) Remove the rich wrapper from EnvironmentManager
[ https://issues.apache.org/jira/browse/BEAM-3847?focusedWorklogId=80166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80166 ] ASF GitHub Bot logged work on BEAM-3847: Author: ASF GitHub Bot Created on: 14/Mar/18 01:16 Start Date: 14/Mar/18 01:16 Worklog Time Spent: 10m Work Description: tgroh commented on issue #4866: [BEAM-3847] Use InstructionRequestHandler in RemoteEnvironment URL: https://github.com/apache/beam/pull/4866#issuecomment-372872077 R: @axelmagn This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 80166) Time Spent: 20m (was: 10m) > Remove the rich wrapper from EnvironmentManager > --- > > Key: BEAM-3847 > URL: https://issues.apache.org/jira/browse/BEAM-3847 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Thomas Groh >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 20m > Remaining Estimate: 0h > > The current wrapper couples the rich implementation of the Control Plane > instead of wrapping the simplest possible wrapper. Using the simple client is > preferable, as it permits more sophisticated users to enrich the client > directly, and the additional complexity required for other users is almost > nonexistent (it consists of one additional call, with access to a > DataService, and can be wrapped around an EnvironmentManager wrapper) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3847) Remove the rich wrapper from EnvironmentManager
[ https://issues.apache.org/jira/browse/BEAM-3847?focusedWorklogId=80165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80165 ] ASF GitHub Bot logged work on BEAM-3847: Author: ASF GitHub Bot Created on: 14/Mar/18 01:15 Start Date: 14/Mar/18 01:15 Worklog Time Spent: 10m Work Description: tgroh opened a new pull request #4866: [BEAM-3847] Use InstructionRequestHandler in RemoteEnvironment URL: https://github.com/apache/beam/pull/4866 This separates the need to construct the rich client, instead allowing callers to wrap with their own rich wrapper as appropriate. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand: - [ ] What the pull request does - [ ] Why it does it - [ ] How it does it - [ ] Why this approach - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 80165) Time Spent: 10m Remaining Estimate: 0h > Remove the rich wrapper from EnvironmentManager > --- > > Key: BEAM-3847 > URL: https://issues.apache.org/jira/browse/BEAM-3847 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Thomas Groh >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 10m > Remaining Estimate: 0h > > The current wrapper couples the rich implementation of the Control Plane > instead of wrapping the simplest possible wrapper. Using the simple client is > preferable, as it permits more sophisticated users to enrich the client > directly, and the additional complexity required for other users is almost > nonexistent (it consists of one additional call, with access to a > DataService, and can be wrapped around an EnvironmentManager wrapper) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
